summaryrefslogtreecommitdiff
path: root/qa/spec
Commit message (Collapse)AuthorAgeFilesLines
* Reduce the CE/EE diff under qa/qa-reduce-ce-ee-diff-in-qa-folderRémy Coutable2019-08-142-1/+29
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable Rubocop Performance/InefficientHashSearchsh-enable-rubocop-hash-searchStan Hu2019-07-241-1/+1
| | | | | | | | | When used with a Hash, `.keys.include?` is bad because: 1. It performs a O(n) search instead of the efficient `.has_key?` 2. It clones all keys into separate array. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
* QA: Prefer `flat_map` over `map` + `flatten`Peter Leitzen2019-07-221-2/+2
|
* Treat element#selector_css string appropriatelyqa-dd-data-qa-selector-replacementddavison2019-07-101-1/+1
| | | | | Proper escaping should be used for page/base.rb#scroll_to as it is a single quoted JS string
* Introduce data-qa-selector to supplant .qa-classddavison2019-07-101-1/+12
| | | | | | | | | | | | | | | | | | | | | In order to break away from using CSS classes as our primary method of element identification, we need to provide the ability to search for data attributes. Make Test::Sanity::Selectors now work Utilize regex to match on literal strings of the element name Suggest the data-qa-selector pattern vs the qa- Add data-qa-selector to login page to start We need a page that is heavily used in order to be confident that this functionality works. Let's start with the Login page Use appropriate HAML data tag practices
* Run tests in parallel via parallel_testsMark Lapierre2019-07-094-8/+70
| | | | | | | | | | | | | Uses the parallel_tests gem to execute tests in multiple processes simultaneously on the same machine. Adds the `--parallel` CLI option that instructs the QA framework to use the parallel_tests executable. Tests need access to global state contained in `Runtime::Scenario` so when `--parallel` is invoked `Runtime::Scenario` is serialized to an environment variable, which is passed to parallel_tests, and then deserialized in `spec_helper`.
* First pass at new automated QA API test for #52703Grant Young2019-07-011-3/+33
| | | | | | Checks that archives of two different user projects with the same name aren't the same via checksum. I.E. a user can't download the archive of another's project by mistake. To enable the test some enhancements were made. Namely updating the client module to handle more than one API instance and the creation a custom rest call method that downloads to tmp.
* Test push limit with admin userMark Lapierre2019-06-182-14/+60
| | | | | | | | | | | Uses `:requires_admin` metadata to specify that a test needs an admin user. Sets the push file size limit test to require an admin user. With an admin access token set as the env var GITLAB_QA_ADMIN_ACCESS_TOKEN, the push size limit test now only uses the API and CLI
* Backport of EE changes from MR 13763Walmyr2019-06-141-2/+2
| | | | https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13763
* Fix Web IDE add template testMark Lapierre2019-06-051-1/+11
| | | | | | | | | Wait for the new file modal to stop animating before clicking it We now need to click the commit button 3 times: 1. To enter commit mode 2. To being staging changes 3. To submit the commit
* Generate knapsack report for review-qa-allMark Lapierre2019-06-032-0/+29
| | | | | | | | | | | | | | | | | | | | | | Add knapsack qa report and use it to run tests in parallel Use the RSpec runner with knapsack The way the Knapsack runner uses exec to start rspec seems incompatible with the way we expect it to work. Plus, it requires specifying KNAPSACK_TEST_DIR. Instead, we use knapsacks AllocatorBuilder to select the spec files to run, and then start rspec as normal, via RSpec::Core::Runner.run This also means we can incorporate tags. Let the job run automatically Include KNAPSACK_TEST_FILE_PATTERN in vars Check all defined knapsack env vars before requiring knapsack
* Implement dynamic validation on QA Pagesddavison2019-05-201-0/+56
| | | | | | Elements now have the ability to be required on pages or not Currently using the default wait mechanism Altered the ElementWithPattern Cop to fit new splat for init
* Only retry failing QA tests in CIqa-retry-in-ci-onlyMark Lapierre2019-05-201-3/+5
| | | | No need to retry automatically when running tests locally
* Merge branch 'qa-ml-fix-branches-test' into 'master'Sanad Liaquat2019-05-131-1/+8
|\ | | | | | | | | Fix E2E test - wait for branches to not be present See merge request gitlab-org/gitlab-ce!27805
| * Add branch_name qa selectorqa-ml-fix-branches-testMark Lapierre2019-05-071-1/+8
| | | | | | | | | | | | Uses the branch_name element to find a branch with a specific name, instead of using a dynamic CSS class that can't be validated by the sanity selector test
* | Swap brackets to avoid false positiveqa-escape-netrc-regexMark Lapierre2019-05-061-1/+1
| |
* | Escape arg used in regexMark Lapierre2019-05-061-0/+9
|/
* Merge branch 'frozen_string_literal_qa' into 'master'Sanad Liaquat2019-04-1521-0/+42
|\ | | | | | | | | Add frozen_string_literal to qa/ See merge request gitlab-org/gitlab-ce!27266
| * Add frozen_string_literal to qa/frozen_string_literal_qaThong Kuah2019-04-1321-0/+42
| | | | | | | | | | This will be default in Ruby 3, so will be good to apply in QA ahead of time to be consistent.
* | Enable RSpec/ExampleWording copThong Kuah2019-04-121-2/+2
|/
* Reduce number of rspec retriesSanad Liaquat2019-04-091-1/+1
| | | | | In both e2e QA tests and unit tests, reduce the number of retires to 2 (i.e., 1 initial and one retry)
* Allow token env var from gitlab-qaMark Lapierre2019-03-281-3/+3
| | | | | | | gitlab-qa accepts an env var named GITLAB_QA_ACCESS_TOKEN, but here we only accepted PERSONAL_ACCESS_TOKEN. This change replaces PERSONAL_ACCESS_TOKEN with GITLAB_QA_ACCESS_TOKEN
* Set feature flag via command lineMark Lapierre2019-03-277-12/+127
| | | | | | | | | | | First attempt at allowing a feature flag to be set via the command line when running tests. This will enable the flag, run the tests, and then disable the flag. Using OptionParser meant changing how scenarios get the instance address, so this also allows the address to be set as a command line option. It's backwards compatible (you can still provide the address as the command line option after the scenario)
* Skip contexts in quarantineMark Lapierre2019-03-113-401/+272
| | | | This avoids running before/after blocks for tests that are in quarantine
* [QA] Fail early if a Git command failsRémy Coutable2019-02-281-2/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Update GitHub Import testSanad Liaquat2019-02-251-5/+10
| | | | | | Removes the unnecessary :orchestrated tag and updates a few selectors. Also wait_for_success for import before proceeding. The test is currently placed in quarantine because of a bug.
* Retry failed tests with rspec-retrySanad Liaquat2019-02-192-0/+63
| | | | Does not retry if tagged :quarantine. Also adds unit tests.
* Move server responding check to scenario before hookMark Lapierre2019-02-141-14/+0
| | | | | This checks that the server is responding before any other actions, including before trying to add a license.
* Skip contexts in quarantineMark Lapierre2019-02-142-173/+226
| | | | This avoids running before/after blocks for tests that are in quarantine
* [CE] Improve `wait_for_push`Mark Lapierre2019-02-1112-8/+184
|
* Load login page only if gitlab_address is definedqa-check-server-responding-before-suitSanad Liaquat2019-02-071-3/+5
|
* Wait for login page to load at the beginning of QA suiteSanad Liaquat2019-02-071-0/+12
|
* Add e2e QA test for logging in using GitHub OAuthSanad Liaquat2019-02-011-0/+9
| | | | | Adds the test itself and the vendor page object model for GitHub login pages.
* Merge branch 'qa-ml-improve-git-repo-auth' into 'master'Rémy Coutable2019-01-311-42/+92
|\ | | | | | | | | | | | | Add git credentials to .netrc when needed Closes gitlab-org/quality/nightly#57 and #56857 See merge request gitlab-org/gitlab-ce!24691
| * Don't use .netrc with SSHMark Lapierre2019-01-301-11/+0
| | | | | | | | | | | | There was a bug that required credentials when using SSH key auth when using LFS. That bug was fixed so we shouldn't need to add credentials to .netrc when using SSH anymore.
| * Add git credentials to .netrc when neededMark Lapierre2019-01-281-42/+103
| | | | | | | | | | Avoid having to remember to call try_add_credentials_to_netrc after setting credentials.
* | Re-enable MethodCallWithoutArgsParentheses CopAndrew Newdigate2019-01-292-2/+2
|/ | | | | Re-enables and autocorrects all instances of the Style/MethodCallWithoutArgsParentheses rule
* Fix failing E2E testMark Lapierre2019-01-251-1/+9
| | | | | | | | | | | | Sometimes add_list_delete_branches_spec.rb would not wait after deleting a branch before checking that the branch was done. It would fail when the UI was still processing. This checks that the loading icon is gone before returning from delete_branch. It also makes sure credentials are added properly after recent changes to QA::Git::Repository
* [QA] Use public_email instead of email since it's availableRémy Coutable2019-01-231-0/+118
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix Resource attribute bugMark Lapierre2019-01-151-0/+36
| | | | | Allow Resources to have the same attribute name but different attribute values
* [QA] Retrieve the current user name and emailRémy Coutable2019-01-101-4/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add specs to remote grid. Raise errors for #remote_grid_credentialsddavison2019-01-091-0/+59
| | | | Signed-off-by: ddavison <ddavison@gitlab.com>
* Quarantine spec code review changesMark Lapierre2019-01-082-20/+19
| | | | | | | - Clarify message shown when skipping quarantined tests because they don't have all the specified tags. - Simplify rejecting item from array - Remove 'pass' from example descriptions to avoid confusion
* Skip quarantined tests via filtersMark Lapierre2019-01-082-0/+299
| | | | | | | | Instead of modifying the runner, use config hooks to skip quarantined tests, and to allow only quarantined tests to be run, if desired. This way quarantined tests are skipped, not excluded completely, so they are still included in test results.
* Revert "Allow tests to be quarantined"Mark Lapierre2019-01-081-77/+14
| | | | This reverts commit 8ef418d57c5a9511b862bf0711aadbb977086c91.
* Allow tests to be quarantinedMark Lapierre2019-01-081-14/+77
| | | | Exclude quarantined tests by default.
* Wait for Web IDE commit animationMark Lapierre2019-01-071-0/+14
| | | | | | | | Wait for the "Commit..." button to disappear and the "Stage & Commit" button to appear before clicking the latter button. The animation that is shown while changing the buttons must complete before clicking "Stage & Commit" will have any effect _even if_ the button is visible before the animation is complete.
* Log text_filter arg of find_elementMark Lapierre2018-12-281-0/+9
|
* Backport page object changes from EEMark Lapierre2018-12-201-0/+7
| | | | | Add new page object methods from EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8937
* Merge branch 'ml-qa-git-protocol-v2-spec' into 'master'Nick Thomas2018-11-083-11/+80
|\ | | | | | | | | Add e2e test of push over SSH using Git protocol v2 See merge request gitlab-org/gitlab-ce!22548
View Lorry Controller Status