| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
The suggestions were made while we were pair programming.
|
| |\
| |
| |
| |
| | |
Minor improvement on resources doc
See merge request gitlab-org/gitlab-ce!28589
|
| | | |
|
| |/
|
|
|
|
| |
This is a second iteration to address the Resources section.
In a third iteration the Page Object section will be addressed.
|
| |\
| |
| |
| |
| | |
Move Chrome variables under conditional
See merge request gitlab-org/gitlab-ce!28505
|
| | |
| |
| |
| | |
Dont specify disable-dev-shm-usage for non-chrome browsers
|
| |\ \
| | |
| | |
| | |
| | | |
Quarantine failing test
See merge request gitlab-org/gitlab-ce!28517
|
| | | | |
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
Delegate CiVariable fabrication to API
See merge request gitlab-org/gitlab-ce!27924
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Convert 'user adds a CI variable' to a :smoke test
Adjust support for API and UI fabrication
Signed-off-by: ddavison <ddavison@gitlab.com>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Instead of Resource::CiVariable fabricating via the browser_ui, let's
delegate to the API instead. (will shave off roughly 3-4s every use)
Override resource_web_url to catch ResourceURLMissingError as there
is no "show" action for a CI/CD var
Signed-off-by: ddavison <ddavison@gitlab.com>
|
| | | | |
|
| | |/
|/|
| |
| | |
No need to retry automatically when running tests locally
|
| | |
| |
| |
| |
| |
| | |
framework that intends to make easier for every engineer to
contribute with the end-to-end tests creation, edition, and
improvements.
|
| |\ \
| | |
| | |
| | |
| | | |
Fix E2E test - wait for branches to not be present
See merge request gitlab-org/gitlab-ce!27805
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Uses the branch_name element to find a branch with a specific
name, instead of using a dynamic CSS class that can't be validated
by the sanity selector test
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As long as `has_no_branch?` is only called in an assertion it
shouldn't matter if it could return false but still allow the test to
continue.
So we don't need the new wait method
|
| | | |
| | |
| | |
| | | |
So it can be used elsewhere in the code
|
| | | |
| | |
| | |
| | |
| | |
| | | |
When testing if branches are deleted, wait for the branch element
to not be present. Do the same for both checks (second and third
branches).
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Ruby 2.6 offers better performance and memory usage:
https://www.rubyguides.com/2018/11/ruby-2-6-new-features/
Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/57323
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The reason for the change is that reading the code it should be si-
milar to reading a newspaper, where high-level information is at
the top, like the title and summary of the news, and low level, or
more specific information, are at the bottom.
This improves code readability.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix GitHub oAuth test
Closes gitlab-org/quality/nightly#98
See merge request gitlab-org/gitlab-ce!27736
|
| | | | |
|
| | |/
|/| |
|
| | |
| |
| |
| | |
By moving methods closer to where they are called.
|
| |/ |
|
| |
|
|
|
| |
This pulls in a fix for libxslt that addresses CVE-2019-11068:
https://github.com/sparklemotion/nokogiri/releases
|
| |
|
|
|
|
|
|
|
|
|
| |
The comments were TODOs but there were no explanation of what
needed to be done.
Also, I think the expectation describes very well how it checks
that the user is logged in.
Finally, as Robert C. Martin said once:
"After you check in a TODO comment it turns into a DON'T DO"
|
| |
|
|
|
|
|
|
| |
- Created DiscussionActions component
- Updated NoteableDiscussion component accordingly
- Wrote Jest tests for DiscussionActions
- Updated Jest config to enable emojis aliases mock
- Updated qa specs to reflect changes in NoteableDiscussions
|
| |\
| |
| |
| |
| |
| |
| | |
Resolve "Add QA tests for the performance bar"
Closes #60356
See merge request gitlab-org/gitlab-ce!27305
|
| | |
| |
| |
| |
| |
| |
| |
| | |
These are very high-level. Currently, they test:
1. That the performance bar appears.
2. That it has detailed metrics for Postgres and Gitaly.
3. That AJAX requests are included in the request selector.
|
| |\ \
| | |
| | |
| | |
| | | |
Add frozen_string_literal to qa/
See merge request gitlab-org/gitlab-ce!27266
|
| | |/
| |
| |
| |
| | |
This will be default in Ruby 3, so will be good to apply in QA ahead of
time to be consistent.
|
| | |
| |
| |
| |
| | |
This reverts commit 026c92d5fa82fac87386d5691c3d5b1e02f2eb5e, reversing
changes made to 8cda9d33a96e34c3809dcaddcde2619cc4923c0b.
|
| |\ \
| | |
| | |
| | |
| | | |
Update capybara and selenium-webdriver
See merge request gitlab-org/gitlab-ce!27201
|
| | |/ |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| | |
Allow unauthenticated downloads of Chrome
Closes #60441
See merge request gitlab-org/gitlab-ce!27297
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The Google GPG key used to sign the apt repository expired today, so all
installs will fail unless `--allow-unauthenticated` is used. We should
revert this once the repository has been updated with the more recent
key.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60441
|
| | |
| |
| |
| | |
Additionally fixes geo rename test.
|
| |/ |
|
| |\
| |
| |
| |
| | |
Add 'bundle exec' to the 'bin/qa' calls in qa/README.md
See merge request gitlab-org/gitlab-ce!27169
|
| | |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
