summaryrefslogtreecommitdiff
path: root/qa
Commit message (Collapse)AuthorAgeFilesLines
* Don't fabricate a default project for the CI/CD testdd-qa-api-delegation-project-cicd-varsddavison2019-05-071-2/+12
| | | | | | | | Convert 'user adds a CI variable' to a :smoke test Adjust support for API and UI fabrication Signed-off-by: ddavison <ddavison@gitlab.com>
* Delegate CiVariable delegation to APIddavison2019-05-062-0/+28
| | | | | | | | | | Instead of Resource::CiVariable fabricating via the browser_ui, let's delegate to the API instead. (will shave off roughly 3-4s every use) Override resource_web_url to catch ResourceURLMissingError as there is no "show" action for a CI/CD var Signed-off-by: ddavison <ddavison@gitlab.com>
* Move test method to the bottomWalmyr Lima2019-04-291-5/+5
| | | | | | | | | The reason for the change is that reading the code it should be si- milar to reading a newspaper, where high-level information is at the top, like the title and summary of the news, and low level, or more specific information, are at the bottom. This improves code readability.
* Merge branch 'qa-nightly-98-fix-oauth-spec' into 'master'Sanad Liaquat2019-04-291-3/+1
|\ | | | | | | | | | | | | Fix GitHub oAuth test Closes gitlab-org/quality/nightly#98 See merge request gitlab-org/gitlab-ce!27736
| * Fix GitHub OAuth e2e specSanad Liaquat2019-04-261-3/+1
| |
* | Quarantine failing testMark Lapierre2019-04-291-1/+2
| |
* | Refactor quarantine helperWalmyr Lima2019-04-261-8/+8
| | | | | | | | By moving methods closer to where they are called.
* | Quaraintine flaky testsSanad Liaquat2019-04-261-1/+2
|/
* Bump Nokogiri to 1.10.3sh-bump-nokogiri-1.10.3Stan Hu2019-04-222-3/+3
| | | | | This pulls in a fix for libxslt that addresses CVE-2019-11068: https://github.com/sparklemotion/nokogiri/releases
* Remove unnecessary comments from login testsWalmyr2019-04-223-10/+0
| | | | | | | | | | | The comments were TODOs but there were no explanation of what needed to be done. Also, I think the expectation describes very well how it checks that the user is logged in. Finally, as Robert C. Martin said once: "After you check in a TODO comment it turns into a DON'T DO"
* Extract discussion actions into separate component58293-extract-discussion-actionsPaul Gascou-Vaillancourt2019-04-171-1/+1
| | | | | | | | - Created DiscussionActions component - Updated NoteableDiscussion component accordingly - Wrote Jest tests for DiscussionActions - Updated Jest config to enable emojis aliases mock - Updated qa specs to reflect changes in NoteableDiscussions
* Merge branch '60356-add-qa-tests-for-the-performance-bar' into 'master'Sanad Liaquat2019-04-176-0/+131
|\ | | | | | | | | | | | | Resolve "Add QA tests for the performance bar" Closes #60356 See merge request gitlab-org/gitlab-ce!27305
| * Add QA tests for the performance bar60356-add-qa-tests-for-the-performance-barSean McGivern2019-04-166-0/+131
| | | | | | | | | | | | | | | | These are very high-level. Currently, they test: 1. That the performance bar appears. 2. That it has detailed metrics for Postgres and Gitaly. 3. That AJAX requests are included in the request selector.
* | Merge branch 'frozen_string_literal_qa' into 'master'Sanad Liaquat2019-04-1598-1/+198
|\ \ | | | | | | | | | | | | Add frozen_string_literal to qa/ See merge request gitlab-org/gitlab-ce!27266
| * | Add frozen_string_literal to qa/frozen_string_literal_qaThong Kuah2019-04-1398-1/+198
| |/ | | | | | | | | This will be default in Ruby 3, so will be good to apply in QA ahead of time to be consistent.
* | Revert "Merge branch 'sh-allow-unauth-chrome' into 'master'"sh-revert-untrusted-chrome-repoStan Hu2019-04-121-1/+1
| | | | | | | | | | This reverts commit 026c92d5fa82fac87386d5691c3d5b1e02f2eb5e, reversing changes made to 8cda9d33a96e34c3809dcaddcde2619cc4923c0b.
* | Merge branch 'update-capybara' into 'master'Stan Hu2019-04-121-1/+1
|\ \ | | | | | | | | | | | | Update capybara and selenium-webdriver See merge request gitlab-org/gitlab-ce!27201
| * | Also update nokogiri for QALin Jen-Shin2019-04-121-1/+1
| |/
* | Enable RSpec/ExampleWording copThong Kuah2019-04-121-2/+2
|/
* Merge branch 'sh-allow-unauth-chrome' into 'master'Grzegorz Bizon2019-04-121-1/+1
|\ | | | | | | | | | | | | Allow unauthenticated downloads of Chrome Closes #60441 See merge request gitlab-org/gitlab-ce!27297
| * Allow unauthenticated downloads of ChromeStan Hu2019-04-121-1/+1
| | | | | | | | | | | | | | | | | | The Google GPG key used to sign the apt repository expired today, so all installs will fail unless `--allow-unauthenticated` is used. We should revert this once the repository has been updated with the more recent key. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60441
* | Update project settings qa selectorsSanad Liaquat2019-04-113-21/+25
| | | | | | | | Additionally fixes geo rename test.
* | Qurantine Issue suggestions specSanad Liaquat2019-04-111-1/+2
|/
* Merge branch 'docs-fix-bin-qa-command' into 'master'Ramya Authappan2019-04-101-8/+10
|\ | | | | | | | | Add 'bundle exec' to the 'bin/qa' calls in qa/README.md See merge request gitlab-org/gitlab-ce!27169
| * Add 'bundle exec' to the 'bin/qa' calls in qa/README.mddocs-fix-bin-qa-commandRémy Coutable2019-04-091-8/+10
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch 'tp-2019-04-08-quarantine' into 'master'Ramya Authappan2019-04-102-3/+4
|\ \ | | | | | | | | | | | | Quarantine failing nightly tests See merge request gitlab-org/gitlab-ce!27174
| * | Quarantine failing nightly teststp-2019-04-08-quarantineTanya Pazitny2019-04-092-3/+4
| | |
* | | Merge branch 'osw-multi-assignees-merge-requests' into 'master'Nick Thomas2019-04-091-1/+1
|\ \ \ | |_|/ |/| | | | | | | | [Backport] Support multiple assignees for merge requests See merge request gitlab-org/gitlab-ce!27089
| * | [CE] Support multiple assignees for merge requestsosw-multi-assignees-merge-requestsOswaldo Ferreira2019-04-081-1/+1
| |/ | | | | | | | | Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161 (code out of ee/ folder).
* | Reduce number of rspec retriesSanad Liaquat2019-04-091-1/+1
| | | | | | | | | | In both e2e QA tests and unit tests, reduce the number of retires to 2 (i.e., 1 initial and one retry)
* | Change value to something that can be maskedfix_qa_auto_devops_ci_masking_variableThong Kuah2019-04-091-2/+2
|/ | | | | | | | | | | | | | | The current value cannot be masked[1] but CI variables default to masked. Rather than implementing a toggle for the masking control, simply change the value to something that can be masked. [1] Currently, "simple" values can be masked: * it should be a single line * it should not have escape characters * it should not use variables * it should not have any whitespace * it should be longer than 8 characters https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25476
* Remove spaces from variable namemc/fix/ci-variable-qaMatija Čupić2019-04-051-5/+4
|
* Adding perf testdata for MR diff tabRamya Authappan2019-04-051-8/+59
|
* Quarantine failing testsSanad Liaquat2019-04-053-3/+6
|
* Merge branch '57602-create-cluster-validations' into 'master'Mike Greiling2019-04-041-1/+1
|\ | | | | | | | | | | | | Display cluster form validation error messages inline Closes #57602 See merge request gitlab-org/gitlab-ce!26502
| * Specify new validation message selectorEnrique Alcantara2019-04-031-1/+1
| | | | | | | | | | Update QA selector to specify that API URL is a input type=url field
* | Replace comment by variableWalmyr2019-04-041-2/+2
| | | | | | | | | | Instead of having a comment describing what a specific value is, better to have a variable with a meaningful name.
* | Externalize strings in helpersMartin Wortschack2019-04-041-1/+1
| | | | | | | | | | - Update qa selector - Update PO file
* | Fix typo on tests style guidedoc/fix-typo-on-tests-style-guideWalmyr Lima2019-04-021-1/+1
| |
* | Document click_ vs. go_to_ standard for e2e testsqa/document_click_vs_go_toWalmyr Lima2019-04-012-0/+47
|/ | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59645.
* Fix typo in QA auto_devops specfix_qa_auto_devops_specThong Kuah2019-04-011-1/+1
|
* Fix push file size testqa-ml-fix-push-file-size-testMark Lapierre2019-03-281-2/+3
| | | | | Don't try to re-create master as a new branch. Expect a Git error raised when the file it too large.
* Standardize usage of `click_` and `go_to` on GUI testsWalmyr2019-03-2855-90/+84
| | | | | | | This MR addresses the following issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/57043 Based on the following comment: https://gitlab.com/gitlab-org/gitlab-ce/issues/57043#note_136663994
* Allow token env var from gitlab-qaMark Lapierre2019-03-285-11/+11
| | | | | | | gitlab-qa accepts an env var named GITLAB_QA_ACCESS_TOKEN, but here we only accepted PERSONAL_ACCESS_TOKEN. This change replaces PERSONAL_ACCESS_TOKEN with GITLAB_QA_ACCESS_TOKEN
* Set feature flag via command lineMark Lapierre2019-03-2719-26/+259
| | | | | | | | | | | First attempt at allowing a feature flag to be set via the command line when running tests. This will enable the flag, run the tests, and then disable the flag. Using OptionParser meant changing how scenarios get the instance address, so this also allows the address to be set as a command line option. It's backwards compatible (you can still provide the address as the command line option after the scenario)
* Unquarantine previously failing auto devops testDan Davison2019-03-271-2/+1
| | | | | The smoke test for AutoDevOps was previously failing. This test is now passing and ready to be unquarantined
* Make the job#successful? method wait by refreshingddavison2019-03-261-1/+5
|
* Merge branch 'qa-fix-load-test-urls-file-format' into 'master'Ramya Authappan2019-03-263-11/+14
|\ | | | | | | | | Fix url property format in urls.yml file See merge request gitlab-org/gitlab-ce!26484
| * Fix url property format and use conn. poolSanad Liaquat2019-03-263-11/+14
| | | | | | | | Also update arrivalRate to a max of 100
* | Move simplest test to the top and more complex to the bottomWalmyr2019-03-251-26/+30
| | | | | | | | | | | | | | Also, make both `it` statments part of the same `describe`. Finally, remove duplication of strings by defining variables and re-using them.