| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
The reason for the change is that reading the code it should be si-
milar to reading a newspaper, where high-level information is at
the top, like the title and summary of the news, and low level, or
more specific information, are at the bottom.
This improves code readability.
|
|\
| |
| |
| |
| |
| |
| | |
Fix GitHub oAuth test
Closes gitlab-org/quality/nightly#98
See merge request gitlab-org/gitlab-ce!27736
|
| | |
|
| | |
|
| |
| |
| |
| | |
By moving methods closer to where they are called.
|
|/ |
|
|
|
|
|
| |
This pulls in a fix for libxslt that addresses CVE-2019-11068:
https://github.com/sparklemotion/nokogiri/releases
|
|
|
|
|
|
|
|
|
|
|
| |
The comments were TODOs but there were no explanation of what
needed to be done.
Also, I think the expectation describes very well how it checks
that the user is logged in.
Finally, as Robert C. Martin said once:
"After you check in a TODO comment it turns into a DON'T DO"
|
|
|
|
|
|
|
|
| |
- Created DiscussionActions component
- Updated NoteableDiscussion component accordingly
- Wrote Jest tests for DiscussionActions
- Updated Jest config to enable emojis aliases mock
- Updated qa specs to reflect changes in NoteableDiscussions
|
|\
| |
| |
| |
| |
| |
| | |
Resolve "Add QA tests for the performance bar"
Closes #60356
See merge request gitlab-org/gitlab-ce!27305
|
| |
| |
| |
| |
| |
| |
| |
| | |
These are very high-level. Currently, they test:
1. That the performance bar appears.
2. That it has detailed metrics for Postgres and Gitaly.
3. That AJAX requests are included in the request selector.
|
|\ \
| | |
| | |
| | |
| | | |
Add frozen_string_literal to qa/
See merge request gitlab-org/gitlab-ce!27266
|
| |/
| |
| |
| |
| | |
This will be default in Ruby 3, so will be good to apply in QA ahead of
time to be consistent.
|
| |
| |
| |
| |
| | |
This reverts commit 026c92d5fa82fac87386d5691c3d5b1e02f2eb5e, reversing
changes made to 8cda9d33a96e34c3809dcaddcde2619cc4923c0b.
|
|\ \
| | |
| | |
| | |
| | | |
Update capybara and selenium-webdriver
See merge request gitlab-org/gitlab-ce!27201
|
| |/ |
|
|/ |
|
|\
| |
| |
| |
| |
| |
| | |
Allow unauthenticated downloads of Chrome
Closes #60441
See merge request gitlab-org/gitlab-ce!27297
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The Google GPG key used to sign the apt repository expired today, so all
installs will fail unless `--allow-unauthenticated` is used. We should
revert this once the repository has been updated with the more recent
key.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60441
|
| |
| |
| |
| | |
Additionally fixes geo rename test.
|
|/ |
|
|\
| |
| |
| |
| | |
Add 'bundle exec' to the 'bin/qa' calls in qa/README.md
See merge request gitlab-org/gitlab-ce!27169
|
| |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|\ \
| | |
| | |
| | |
| | | |
Quarantine failing nightly tests
See merge request gitlab-org/gitlab-ce!27174
|
| | | |
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
[Backport] Support multiple assignees for merge requests
See merge request gitlab-org/gitlab-ce!27089
|
| |/
| |
| |
| |
| | |
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
|
| |
| |
| |
| |
| | |
In both e2e QA tests and unit tests, reduce the number of retires
to 2 (i.e., 1 initial and one retry)
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current value cannot be masked[1] but CI variables default to
masked. Rather than implementing a toggle for the masking control,
simply change the value to something that can be masked.
[1] Currently, "simple" values can be masked:
* it should be a single line
* it should not have escape characters
* it should not use variables
* it should not have any whitespace
* it should be longer than 8 characters
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25476
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Display cluster form validation error messages inline
Closes #57602
See merge request gitlab-org/gitlab-ce!26502
|
| |
| |
| |
| |
| | |
Update QA selector to specify that API URL
is a input type=url field
|
| |
| |
| |
| |
| | |
Instead of having a comment describing what a specific value is,
better to have a variable with a meaningful name.
|
| |
| |
| |
| |
| | |
- Update qa selector
- Update PO file
|
| | |
|
|/
|
|
| |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59645.
|
| |
|
|
|
|
|
| |
Don't try to re-create master as a new branch.
Expect a Git error raised when the file it too large.
|
|
|
|
|
|
|
| |
This MR addresses the following issue:
https://gitlab.com/gitlab-org/gitlab-ce/issues/57043
Based on the following comment:
https://gitlab.com/gitlab-org/gitlab-ce/issues/57043#note_136663994
|
|
|
|
|
|
|
| |
gitlab-qa accepts an env var named GITLAB_QA_ACCESS_TOKEN, but here we
only accepted PERSONAL_ACCESS_TOKEN.
This change replaces PERSONAL_ACCESS_TOKEN with GITLAB_QA_ACCESS_TOKEN
|
|
|
|
|
|
|
|
|
|
|
| |
First attempt at allowing a feature flag to be set via the command line
when running tests. This will enable the flag, run the tests, and then
disable the flag.
Using OptionParser meant changing how scenarios get the instance
address, so this also allows the address to be set as a command line
option. It's backwards compatible (you can still provide the address
as the command line option after the scenario)
|
|
|
|
|
| |
The smoke test for AutoDevOps was previously failing.
This test is now passing and ready to be unquarantined
|
| |
|
|\
| |
| |
| |
| | |
Fix url property format in urls.yml file
See merge request gitlab-org/gitlab-ce!26484
|
| |
| |
| |
| | |
Also update arrivalRate to a max of 100
|
| |
| |
| |
| |
| |
| |
| | |
Also, make both `it` statments part of the same `describe`.
Finally, remove duplication of strings by defining variables and
re-using them.
|
|/
|
|
|
|
|
|
|
| |
The code should be written like a newspaper, wherein the top we
have more high level information, and as we go down we have more
details.
So I'm moving the implementation details to the bottom to make the
test easier to read.
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
'master'
Fix Auto DevOps QA Smoke test hidden banner
Closes gitlab-org/quality/nightly#87
See merge request gitlab-org/gitlab-ce!26254
|