summaryrefslogtreecommitdiff
path: root/qa
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'qa-ml-fix-branches-test' into 'master'Sanad Liaquat2019-05-136-32/+33
|\ | | | | | | | | Fix E2E test - wait for branches to not be present See merge request gitlab-org/gitlab-ce!27805
| * Add branch_name qa selectorqa-ml-fix-branches-testMark Lapierre2019-05-074-15/+27
| | | | | | | | | | | | Uses the branch_name element to find a branch with a specific name, instead of using a dynamic CSS class that can't be validated by the sanity selector test
| * Check test result via an assertionMark Lapierre2019-05-012-11/+3
| | | | | | | | | | | | | | | | As long as `has_no_branch?` is only called in an assertion it shouldn't matter if it could return false but still allow the test to continue. So we don't need the new wait method
| * Make max wait time a constantMark Lapierre2019-05-011-1/+3
| | | | | | | | So it can be used elsewhere in the code
| * Wait for branches to not be presentMark Lapierre2019-04-292-14/+9
| | | | | | | | | | | | When testing if branches are deleted, wait for the branch element to not be present. Do the same for both checks (second and third branches).
* | Upgrade Ruby version to 2.6.3sh-upgrade-ruby-2.6.3-ceStan Hu2019-05-081-1/+1
| | | | | | | | | | | | | | Ruby 2.6 offers better performance and memory usage: https://www.rubyguides.com/2018/11/ruby-2-6-new-features/ Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/57323
* | Quarantine download MR patch and diff test suiteqa-quarantine-download-mr-patch-and-diff-test-suiteWalmyr Lima2019-05-071-1/+2
| |
* | Quarantine login via oauth specWalmyr Lima2019-05-071-1/+2
| |
* | Swap brackets to avoid false positiveqa-escape-netrc-regexMark Lapierre2019-05-061-1/+1
| |
* | Escape arg used in regexMark Lapierre2019-05-062-1/+10
| |
* | Run rubocop -a on CE filessh-upgrade-rubocop-0.68.0-ceStan Hu2019-05-053-3/+0
| |
* | Move test method to the bottomWalmyr Lima2019-04-291-5/+5
| | | | | | | | | | | | | | | | | | The reason for the change is that reading the code it should be si- milar to reading a newspaper, where high-level information is at the top, like the title and summary of the news, and low level, or more specific information, are at the bottom. This improves code readability.
* | Merge branch 'qa-nightly-98-fix-oauth-spec' into 'master'Sanad Liaquat2019-04-291-3/+1
|\ \ | | | | | | | | | | | | | | | | | | Fix GitHub oAuth test Closes gitlab-org/quality/nightly#98 See merge request gitlab-org/gitlab-ce!27736
| * | Fix GitHub OAuth e2e specSanad Liaquat2019-04-261-3/+1
| | |
* | | Quarantine failing testMark Lapierre2019-04-291-1/+2
| |/ |/|
* | Refactor quarantine helperWalmyr Lima2019-04-261-8/+8
| | | | | | | | By moving methods closer to where they are called.
* | Quaraintine flaky testsSanad Liaquat2019-04-261-1/+2
|/
* Bump Nokogiri to 1.10.3sh-bump-nokogiri-1.10.3Stan Hu2019-04-222-3/+3
| | | | | This pulls in a fix for libxslt that addresses CVE-2019-11068: https://github.com/sparklemotion/nokogiri/releases
* Remove unnecessary comments from login testsWalmyr2019-04-223-10/+0
| | | | | | | | | | | The comments were TODOs but there were no explanation of what needed to be done. Also, I think the expectation describes very well how it checks that the user is logged in. Finally, as Robert C. Martin said once: "After you check in a TODO comment it turns into a DON'T DO"
* Extract discussion actions into separate component58293-extract-discussion-actionsPaul Gascou-Vaillancourt2019-04-171-1/+1
| | | | | | | | - Created DiscussionActions component - Updated NoteableDiscussion component accordingly - Wrote Jest tests for DiscussionActions - Updated Jest config to enable emojis aliases mock - Updated qa specs to reflect changes in NoteableDiscussions
* Merge branch '60356-add-qa-tests-for-the-performance-bar' into 'master'Sanad Liaquat2019-04-176-0/+131
|\ | | | | | | | | | | | | Resolve "Add QA tests for the performance bar" Closes #60356 See merge request gitlab-org/gitlab-ce!27305
| * Add QA tests for the performance bar60356-add-qa-tests-for-the-performance-barSean McGivern2019-04-166-0/+131
| | | | | | | | | | | | | | | | These are very high-level. Currently, they test: 1. That the performance bar appears. 2. That it has detailed metrics for Postgres and Gitaly. 3. That AJAX requests are included in the request selector.
* | Merge branch 'frozen_string_literal_qa' into 'master'Sanad Liaquat2019-04-1598-1/+198
|\ \ | | | | | | | | | | | | Add frozen_string_literal to qa/ See merge request gitlab-org/gitlab-ce!27266
| * | Add frozen_string_literal to qa/frozen_string_literal_qaThong Kuah2019-04-1398-1/+198
| |/ | | | | | | | | This will be default in Ruby 3, so will be good to apply in QA ahead of time to be consistent.
* | Revert "Merge branch 'sh-allow-unauth-chrome' into 'master'"sh-revert-untrusted-chrome-repoStan Hu2019-04-121-1/+1
| | | | | | | | | | This reverts commit 026c92d5fa82fac87386d5691c3d5b1e02f2eb5e, reversing changes made to 8cda9d33a96e34c3809dcaddcde2619cc4923c0b.
* | Merge branch 'update-capybara' into 'master'Stan Hu2019-04-121-1/+1
|\ \ | | | | | | | | | | | | Update capybara and selenium-webdriver See merge request gitlab-org/gitlab-ce!27201
| * | Also update nokogiri for QALin Jen-Shin2019-04-121-1/+1
| |/
* | Enable RSpec/ExampleWording copThong Kuah2019-04-121-2/+2
|/
* Merge branch 'sh-allow-unauth-chrome' into 'master'Grzegorz Bizon2019-04-121-1/+1
|\ | | | | | | | | | | | | Allow unauthenticated downloads of Chrome Closes #60441 See merge request gitlab-org/gitlab-ce!27297
| * Allow unauthenticated downloads of ChromeStan Hu2019-04-121-1/+1
| | | | | | | | | | | | | | | | | | The Google GPG key used to sign the apt repository expired today, so all installs will fail unless `--allow-unauthenticated` is used. We should revert this once the repository has been updated with the more recent key. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60441
* | Update project settings qa selectorsSanad Liaquat2019-04-113-21/+25
| | | | | | | | Additionally fixes geo rename test.
* | Qurantine Issue suggestions specSanad Liaquat2019-04-111-1/+2
|/
* Merge branch 'docs-fix-bin-qa-command' into 'master'Ramya Authappan2019-04-101-8/+10
|\ | | | | | | | | Add 'bundle exec' to the 'bin/qa' calls in qa/README.md See merge request gitlab-org/gitlab-ce!27169
| * Add 'bundle exec' to the 'bin/qa' calls in qa/README.mddocs-fix-bin-qa-commandRémy Coutable2019-04-091-8/+10
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch 'tp-2019-04-08-quarantine' into 'master'Ramya Authappan2019-04-102-3/+4
|\ \ | | | | | | | | | | | | Quarantine failing nightly tests See merge request gitlab-org/gitlab-ce!27174
| * | Quarantine failing nightly teststp-2019-04-08-quarantineTanya Pazitny2019-04-092-3/+4
| | |
* | | Merge branch 'osw-multi-assignees-merge-requests' into 'master'Nick Thomas2019-04-091-1/+1
|\ \ \ | |_|/ |/| | | | | | | | [Backport] Support multiple assignees for merge requests See merge request gitlab-org/gitlab-ce!27089
| * | [CE] Support multiple assignees for merge requestsosw-multi-assignees-merge-requestsOswaldo Ferreira2019-04-081-1/+1
| |/ | | | | | | | | Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161 (code out of ee/ folder).
* | Reduce number of rspec retriesSanad Liaquat2019-04-091-1/+1
| | | | | | | | | | In both e2e QA tests and unit tests, reduce the number of retires to 2 (i.e., 1 initial and one retry)
* | Change value to something that can be maskedfix_qa_auto_devops_ci_masking_variableThong Kuah2019-04-091-2/+2
|/ | | | | | | | | | | | | | | The current value cannot be masked[1] but CI variables default to masked. Rather than implementing a toggle for the masking control, simply change the value to something that can be masked. [1] Currently, "simple" values can be masked: * it should be a single line * it should not have escape characters * it should not use variables * it should not have any whitespace * it should be longer than 8 characters https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25476
* Remove spaces from variable namemc/fix/ci-variable-qaMatija Čupić2019-04-051-5/+4
|
* Adding perf testdata for MR diff tabRamya Authappan2019-04-051-8/+59
|
* Quarantine failing testsSanad Liaquat2019-04-053-3/+6
|
* Merge branch '57602-create-cluster-validations' into 'master'Mike Greiling2019-04-041-1/+1
|\ | | | | | | | | | | | | Display cluster form validation error messages inline Closes #57602 See merge request gitlab-org/gitlab-ce!26502
| * Specify new validation message selectorEnrique Alcantara2019-04-031-1/+1
| | | | | | | | | | Update QA selector to specify that API URL is a input type=url field
* | Replace comment by variableWalmyr2019-04-041-2/+2
| | | | | | | | | | Instead of having a comment describing what a specific value is, better to have a variable with a meaningful name.
* | Externalize strings in helpersMartin Wortschack2019-04-041-1/+1
| | | | | | | | | | - Update qa selector - Update PO file
* | Fix typo on tests style guidedoc/fix-typo-on-tests-style-guideWalmyr Lima2019-04-021-1/+1
| |
* | Document click_ vs. go_to_ standard for e2e testsqa/document_click_vs_go_toWalmyr Lima2019-04-012-0/+47
|/ | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59645.
* Fix typo in QA auto_devops specfix_qa_auto_devops_specThong Kuah2019-04-011-1/+1
|
View Lorry Controller Status