summaryrefslogtreecommitdiff
path: root/rubocop
Commit message (Collapse)AuthorAgeFilesLines
* Added Cop to blacklist the use of serializedocument-not-using-serializeYorick Peterse2017-05-312-0/+25
| | | | | This Cop blacklists the use of ActiveRecord's "serialize" method, except for cases where we already use this.
* New Migration/UpdateColumnInBatches copRémy Coutable2017-05-293-2/+47
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add AddColumnWithDefaultToLargeTable copRobert Speicher2017-04-282-0/+52
|
* Rename AddColumnWithDefault to ReversibleAddColumnWithDefaultRobert Speicher2017-04-282-2/+2
| | | | | We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them.
* Refactor the AddColumnWithDefault cop to use node matchersRobert Speicher2017-04-281-9/+10
|
* Add remove_concurrent_index to database helperblackst0ne2017-04-064-1/+58
|
* Add cop to ensure reversibility of add_concurrent_indexDouwe Maan2017-03-072-0/+35
|
* Enable and autocorrect the CustomErrorClass copSean McGivern2017-03-011-0/+1
|
* Add RuboCop cop for custom error classesSean McGivern2017-03-011-0/+64
| | | | | | | | | | | | | | | | | | From the Ruby style guide: # bad class FooError < StandardError end # okish class FooError < StandardError; end # good FooError = Class.new(StandardError) This cop does that, but only for error classes (classes where the superclass ends in 'Error'). We have empty controllers and models, which are perfectly valid empty classes.
* Revert "Enable Style/DotPosition"Douwe Maan2017-02-231-6/+6
| | | | | | | | | | | | | | | This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9. # Conflicts: # .rubocop.yml # .rubocop_todo.yml # lib/gitlab/ci/config/entry/global.rb # lib/gitlab/ci/config/entry/jobs.rb # spec/lib/gitlab/ci/config/entry/factory_spec.rb # spec/lib/gitlab/ci/config/entry/global_spec.rb # spec/lib/gitlab/ci/config/entry/job_spec.rb # spec/lib/gitlab/ci/status/build/factory_spec.rb # spec/lib/gitlab/incoming_email_spec.rb
* Revert "Prefer leading style for Style/DotPosition"Douwe Maan2017-02-232-8/+8
| | | | This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
* Prefer leading style for Style/DotPositionDouwe Maan2017-02-232-8/+8
|
* Enable Style/MutableConstantDouwe Maan2017-02-235-7/+7
|
* Enable Style/DotPositionDouwe Maan2017-02-231-6/+6
|
* Enforce use of add_concurrent_foreign_keyconcurrent-foreign-keysYorick Peterse2017-02-102-0/+28
| | | | | | | This adds a Rubocop rule to enforce the use of add_concurrent_foreign_key instead of the regular add_foreign_key method. This cop has been disabled for existing migrations so we don't need to change those.
* Add a spec for our custom GemFetcher coprs-gemfetcher-cop-specRobert Speicher2017-02-092-9/+18
|
* Explicitly require rubocop migration_helpersdm-add-column-with-default-copDouwe Maan2017-02-083-1/+4
|
* Add cop that checks if add_column_with_default is used with up/down methodsDouwe Maan2017-02-084-5/+40
|
* cop for gem fetched from a git sourceAdam Pahlevi2017-01-312-0/+29
| | | | | | code fix for aesthetic & conventions remove unused proc
* Added RuboCop cops for checking DB migrationsmigration-copsYorick Peterse2016-06-294-0/+109
There are currently two cops for this: * Migration/AddIndex: checks if indexes are added concurrently * Migration/ColumnWithDefault: checks if columns with default values are added in a concurrent manner Both cops are fairly simple and make no attempt at correcting the code as this is quite hard to do (e.g. modifications may need to be applied in various places in the same file). They however should provide enough to catch people ignoring the comments in generated migrations telling them to use add_concurrent_index or add_column_with_default.