| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
`(const nil :Foo)` vs `(const nil? :Foo)`
|
| |
|
|
|
| |
This cop prevents you from using file in API, it points you to the
development documentation about workhorse file acceleration.
|
| |
|
|
|
|
|
| |
This ensures the InjectEnterpriseEditionModule cop is able to detect the
prepend patterns used in the qa/ directory. Previously it would not
detect them as all EE QA modules reside in QA::EE, and not the top-level
EE namespace.
|
| | |
|
| | |
|
| |
|
|
|
| |
Use Rubocop's Include
instead of manually checking the matcher in controllers specs.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BeSuccessMatcher now supports following examples:
```
expect(response).to be_success
expect(response).to_not be_success
expect(response).not_to be_success
is_expected.to be_success
is_expected.to_not be_success
is_expected.not_to be_success
```
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Prevent using `be_success` call in controller specs to avoid
getting following deprecation warning:
```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
|
| |
|
|
| |
Stop checking the file location programmatically.
|
| |
|
|
|
|
|
| |
This cop will analyze migrations that add columns with string, and
report an offense if the string has no limit enforced
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505
|
| |
|
|
|
|
|
|
| |
The RSpec/FilePath cop checks that a spec file's path is correct, but
only if the file describes a constant. We want to check, for any file
with a top-level `describe`, whether the file path ends in
`_spec.rb`. We don't care what comes before that; just that it will be
executed by RSpec at all.
|
| |
|
|
|
|
|
|
|
| |
This extends the InjectEnterpriseEditionModule RuboCop cop so that it
verifies the following:
1. The line number the injection occurs on (as before).
2. The method used (e.g. prepend instead of prepend_if_ee).
3. The argument type passed when using the new module injection methods.
|
| |
|
|
|
|
|
| |
Using quotes within string validations can be messy. Let's
use a typical CSS selector for an unquoted attribute
Update the cop spec to validate appropriate new message
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to break away from using CSS classes as
our primary method of element identification, we
need to provide the ability to search for data
attributes.
Make Test::Sanity::Selectors now work
Utilize regex to match on literal strings of the element name
Suggest the data-qa-selector pattern vs the qa-
Add data-qa-selector to login page to start
We need a page that is heavily used in order to be
confident that this functionality works. Let's start
with the Login page
Use appropriate HAML data tag practices
|
| |
|
|
|
|
| |
Suggests to use a JSON structured log instead
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Implement dynamic validation on QA Pages
Closes gitlab-qa#280
See merge request gitlab-org/gitlab-ce!25704
|
| | |
| |
| |
| |
| |
| | |
Elements now have the ability to be required on pages or not
Currently using the default wait mechanism
Altered the ElementWithPattern Cop to fit new splat for init
|
| |/
|
|
|
| |
This provides the user with some context as to why certain ActiveRecord
methods are blacklisted.
|
| | |
|
| |
|
|
| |
This adds Ruby 2.6 support.
|
| |
|
|
|
|
|
| |
This saves thousands of getcwd() system calls and improves the
performance of running Rubocop, which is also used by HAML linting.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61383
|
| | |
|
| |
|
|
|
|
|
| |
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.
The `#reset` seems to solve exactly that case.
|
| | |
|
| |\
| |
| |
| |
| | |
Fix detecting nested EE constants in RuboCop
See merge request gitlab-org/gitlab-ce!24430
|
| | |
| |
| |
| |
| |
| |
| |
| | |
The InjectEnterpriseEditionModule cop would not detect certain nested EE
constants such as `EE::Foo::Bar::Baz`. This could result in it not
enforcing `prepend` being placed on the last line. This commit fixes
this by just performing a string match on the line, instead of relying
on AST matching.
|
| |/
|
|
|
| |
The Background migration specs also run against a certain version of
the database. So we should avoid using factories.
|
