summaryrefslogtreecommitdiff
path: root/spec/controllers/admin
Commit message (Collapse)AuthorAgeFilesLines
* Remove Git circuit breakerZeger-Jan van de Weg2018-10-101-10/+2
| | | | | | | Was introduced in the time that GitLab still used NFS, which is not required anymore in most cases. By removing this, the API it calls will return empty responses. This interface has to be removed in the next major release, expected to be 12.0.
* Prepare admin/projects/show view to allow EE specific featureGabriel Mazetto2018-10-051-0/+11
| | | | | | | In EE it will render a Geo Status widget when Geo is enabled and it is in a secondary node. Also added minimal specs to that action.
* Simplify runner registration token resettingTomasz Maczukin2018-10-041-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | This icommit adds several changes related to the same topic - resetting a Runner registration token: 1. On Project settings page it adds a button for resetting the registration token and it removes the Runner token field that was confusing all GitLab users. 2. On Group settings page it adds the same button for resetting the registration token. 3. On Admin Runners settings page it moves the button to the same place as in Project and Group settings and it changes slightly the page layout to make it more similar to Group and Project setting pages. 4. It refactorizes a little the partial that prints runner registration description. Thanks to this Project, Group and Admin settings of the Runner are re-using the same code to generate the button. 5. Updates the translations of changed text.
* Add receive_max_input_size setting to Application settingsRubén Dávila2018-09-071-0/+7
| | | | | If user has configure the setting then it will be passed to gitlab-shell and gitlab-workhorse
* Enable frozen string in app/models/*.rbrepo-forks/gitlab-ce-frozen-string-enable-app-modelsgfyoung2018-07-261-1/+1
| | | | Partially addresses #47424.
* Rails5 ActionController::ParameterMissing: param is missing or the value is ↵Jasper Maes2018-06-131-1/+1
| | | | empty: application_setting
* Update invalid test application_settings_controller_spec.rbDmitriy Zaporozhets2018-04-141-3/+2
| | | | | | | | | | | | There are 2 problems with this spec: 1. It checks for default visiblity level however there is not code in controller to handle such default. Same check can be performed on model directly. 2. It passes empty application_setting hash while controller requires application_setting not to be empty by using `require` with `permit` Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Remove N+1 queries in /admin/projects pageStan Hu2018-03-191-0/+10
|
* Gitaly Server info for admin panelZeger-Jan van de Weg2018-01-311-0/+15
| | | | | | | | | | | | Implements the client side for gitlab-org/gitaly#819. Which is a server info command. This checks the server version and git binairy version on the server. A small UI was added for administrators, so they can check the status of the Gitaly server. This is done for each storage the monolith knows. Because of this commit, gitlab-org/gitlab-ce!15580 is now closed. That MR removed the Git version too, but didn't replace it with anything.
* Permits 'password_authentication_enabled_for_git' parameter for ↵Mark Fletcher2018-01-191-0/+7
| | | | ApplicationSettingsController
* reference triggers.values for permitted parametersAlexis Reigel2018-01-171-3/+4
|
* add missing permitted paramAlexis Reigel2018-01-171-0/+1
|
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-221-1/+1
|
* Move the circuitbreaker check out in a separate processbvl-circuitbreaker-processBob Van Landuyt2017-12-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running.
* Refactor `have_http_status` into `have_gitlab_http_status` in the specsJacopo2017-10-207-21/+21
|
* Fix namespace deletion testsZeger-Jan van de Weg2017-10-051-1/+1
|
* Changes the password change workflow for admins.28938-password-change-workflow-for-adminsTiago Botelho2017-08-311-12/+20
|
* Pending delete projects no longer return 500 error in Admins projects view35435-pending-delete-project-error-in-admin-interface-fixTiago Botelho2017-08-111-0/+12
|
* Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-091-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add a Circuitbreaker for storage pathsBob Van Landuyt2017-08-041-0/+25
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-026-8/+8
|
* Ensure all project factories use `:repository` trait or `:empty_project`rs-empty_project-cleanupRobert Speicher2017-08-012-3/+3
|
* Backport gitlab-ee!2456Oswaldo Ferreira2017-07-271-3/+8
|
* Fixes 500 error caused by pending delete projects in admin dashboard35453-pending-delete-projects-error-in-admin-dashboard-fixTiago Botelho2017-07-251-0/+21
|
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-2/+2
|
* Correct RSpec/SingleLineHook cop offensesRobert Speicher2017-06-142-2/+7
|
* Limit non-administrators to adding 100 members at a time to groups and projectsNick Thomas2017-06-061-0/+9
|
* Support hard deletion in Admin::UsersController#destroyNick Thomas2017-06-051-2/+13
|
* CodestyleGabriel Mazetto2017-05-131-1/+1
|
* Make the new repository_update_events configurable in System Hooks UIGabriel Mazetto2017-05-121-0/+28
|
* refactor code based on feedbackJames Lopez2017-05-051-4/+4
|
* refactor a few things based on feedbackJames Lopez2017-05-041-0/+32
|
* Refactor Admin::GroupsController#members_update method and add some specsdz-refactor-admin-group-membersDmitriy Zaporozhets2017-04-201-0/+24
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Port 'Add more usage data to EE ping' to CESean McGivern2017-04-141-0/+37
| | | | CE port of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/735
* Remove redundant code to convert restricted_levels to integersToon Claes2017-03-231-3/+11
| | | | | The ApplicationSetting#restricted_visibility_levels= now takes care of converting string formatted levels to integers.
* Resolve future conflicts with CE -> EE mergeToon Claes2017-03-231-4/+7
| | | | | EE already includes specs for the ApplicationSettingsController, so ensure future changes will be easier to merge to EE.
* Undo explicit conversion to IntegerToon Claes2017-03-201-0/+28
| | | | | With the changes in Gitlab::VisibilityLevel it is no longer needed to explicit conversion to Integer in the controller itself.
* Make sure scopes are loaded in admin OAuth application formMarkus Koller2017-03-071-0/+65
|
* Use expect { }.to change { }use-update-runner-serviceLin Jen-Shin2017-02-151-9/+9
| | | | | Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8664#note_23427575
* Add some tests for admin/project runners pageLin Jen-Shin2017-02-151-0/+85
|
* Use `empty_project` where possible in controller specsrs-empty_project-controllersRobert Speicher2017-01-252-2/+2
|
* Add tests for admin service templateszj-fix-admin-templatesZ.J. van de Weg2017-01-061-0/+26
|
* Allow admins to stop impersonating users without e-mail addressesOren Kanner2016-11-171-7/+21
| | | | | | | | Resolves #24576 Modify the guard clause of the `ApplicationController#require_email` before action to skip requests where an admin is impersonating the current user.
* Only show one error message for an invalid emailSteve Halasz2016-10-271-0/+11
| | | | | | | If notification_email is blank, it's set from email. If an admin attempted to create a user with an invalid email, an error would be displayed for both fields. Only validate the notification_email if it's different from email.
* Fix incorrect "stopped impersonation" log messagefix-impersonation-logStan Hu2016-08-231-0/+2
| | | | Closes #21015
* Merge branch 'akismet-submittable' into 'master' Robert Speicher2016-08-151-0/+12
|\ | | | | | | | | | | | | Submit to Akismet Part 1 (Issues) Related to #5932 #5573 gitlab-com/infrastructure#14 See merge request !5538
| * Further refactor and syntax fixes.Patricio Cano2016-08-151-1/+1
| |
| * Refactored AkismetHelper into AkismetService and cleaned up `Spammable`Patricio Cano2016-08-151-1/+1
| | | | | | | | - Refactored SpamCheckService into SpamService
| * Allow `Issue` to be submitted as spamPatricio Cano2016-08-151-0/+12
| | | | | | | | | | - Added controller actions as reusable concerns - Added controller tests
* | This fixes a long running tests due to changed Sidekiq statefix-failing-testsKamil Trzcinski2016-08-151-2/+3
|/