| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
It consists of two parts:
1. Redirecting users to the configured external storage
1. Allowing the external storage to request the static object(s)
on behalf of the user by means of specific tokens
Part of https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6829
|
| |
|
|
|
|
|
| |
Sorting preference functionality has been extracted
from `IssuableCollections` to a new `SortingPreference`
concern in order to reuse this functionality in projects
(and groups in the future).
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Remove project from NotesFinder constructor
Add project parameter to specs
Also look for methods in private scope
Fix specs to match new NotesFinder constructor
|
| |
|
|
|
| |
'master'"
This reverts merge request !29733
|
| |\
| |
| |
| |
| |
| |
| | |
Use NotesFinder to fetch notes in module IssuableActions
Closes #52123
See merge request gitlab-org/gitlab-ce!29733
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add spec for concern IssuableActions
Add shared samples for discussions endpoint
Add schema validations for discussions
Fix rubocop style issue
Make target assignable
Use new possibility to provide target
|
| |/
|
|
|
| |
These are not required because MySQL is not
supported anymore
|
| |
|
|
|
|
|
| |
We use a leading dash for certain things like the WebIDE, which
had the side effect of losing the `params[:continue][:to]` param when
opening the WebIDE on a project where the user doesn't have push access
and therefore needs to fork the project first.
|
| |
|
|
|
|
|
|
|
|
| |
The check for continue_params&.key?(:to) in Projects::ImportsController
caused an exception in redirect_to if this key contained a nil value.
Since url_for won't add any params for an empty hash, we can just return
that in continue_params if params[:continue] isn't present, and simplify
the code in the controllers to check for the values we actually want to
use.
|
| | |
|
| |
|
|
|
| |
This fixes a regression in mime-types-data:
https://github.com/mime-types/mime-types-data/pull/20
|
| | |
|
| | |
|
| |
|
|
|
|
| |
- Add serializers and Grape::Entity
- Replace to_json
- Add specs
|
| |
|
|
|
|
|
|
| |
Previously import_url would always be present in the update parameters,
which would cause the validation to fail. We now only include this
parameter only if there is URL given.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62708
|
| | |
|
| |\
| |
| |
| |
| | |
Refactor RoutableActions to allow additional not_found checks
See merge request gitlab-org/gitlab-ce!28243
|
| | |
| |
| |
| |
| | |
Since this needs to be called on every find_routable!(Project, ...
we can instead move it to a RoutableActions check.
|
| | | |
|
| |/
|
|
|
|
|
|
| |
String#underscore isn't particularly slow, but it's possible for us to
call it many times in a users autocomplete request, with mostly-static
values ('User', 'Group', etc.). We can memoise this and save a
surprising amount of time (around 10% of the total request time in some
cases).
|
| | |
|
| |
|
|
| |
Try to simplify feature flag checks by using policies
|
| |
|
|
| |
This was removed by a previous MR but broke some links
|
| |
|
|
|
|
|
|
|
|
| |
Adds frozen string to the following:
* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb
xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
|
| |
|
|
| |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
| |
|
| |
This reverts merge request !26823
|
| |
|
|
| |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
| |
|
|
|
| |
This fixes the bug, when approver filter is provided,
but dashboard asks to enter any filter
|
| |
|
|
|
| |
Fixes issue with AWS V4 signatures not working with Ceph S3:
https://github.com/fog/fog-aws/issues/462
|
| |
|
|
|
|
|
| |
Ability to filter confidential issues
Closes #50747
See merge request gitlab-org/gitlab-ce!24960
|
| |
|
|
|
| |
This reverts commit d133bf84c668df3dfc9938bb04150754cb873c8b, reversing
changes made to 7981c0292b07a0138b096fa082341fcb13e9ce2b.
|
| |
|
|
| |
Use internally only boolean params.
|
| |
|
|
|
| |
Add a new search bar filter for confidential issues. Add filtering
support to the IssuesFinder.
|
| |
|
|
|
|
|
|
|
| |
Due to a regression in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24919,
Content-Disposition is hard-coded to `attachment` instead of `inline`.
We now use the argument `disposition` to fix that problem.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57660
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Users downloading non-ASCII attachments would see garbled characters.
When used with object storage, AWS S3 would return an InvalidArgument
error: Header value cannot be represented using ISO-8859-1.
Per RFC 5987 and RFC 6266, Content-Disposition should be encoded
properly. This commit takes the Rails 6 implementation of
ActiveSuppport::Http::ContentDisposition
(https://github.com/rails/rails/pull/33829) and ports it here.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673
|
| |
|
|
|
|
| |
In order to let users' sorting preferences transfer between devices, we
save the preference for issues and MRs (one preference for issues, one
for MRs) in the backend inside the UserPreference object
|
| |
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |
|
|
|
|
|
|
|
|
| |
Updates specs to use new rails5 format.
The old format:
`get :show, { some: params }, { some: headers }`
The new format:
`get :show, params: { some: params }, headers: { some: headers }`
|
| |
|
|
| |
a Hash is deprecated
|
| | |
|
| |
|
|
| |
response body.
|
| | |
|
| | |
|
| |
|
|
| |
This makes to always proxy reports
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were several issues:
1. With Google Cloud Storage, we can't override the Content-Type with
Response-Content-Type once it is set. Setting the value to
`application/octet-stream` doesn't buy us anything. GCS defaults to
`application/octet-stream`, and AWS uses `binary/octet-stream`. Just remove
this `Content-Type` when we upload new files.
2. CarrierWave and fog-google need to support query parameters:
https://github.com/fog/fog-google/pull/409/files, https://github.com/carrierwaveuploader/carrierwave/pull/2332/files.
CarrierWave has been monkey-patched until an official release.
3. Workhorse also needs to remove the Content-Type header in the request
(https://gitlab.com/gitlab-org/gitlab-workhorse/blob/ef80978ff89e628c8eeb66556720e30587d3deb6/internal/objectstore/object.go#L66),
or we'll get a 403 error when uploading due to signed URLs not matching the headers.
Upgrading to Workhorse 6.1.0 for https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/297
will make Workhorse use the headers that are used by Rails.
Closes #49957
|
| |
|
|
| |
Closes #49120
|
| |
|
|
|
|
|
|
|
| |
We need to preload the ancestors of search results after applying
pagination limits. This way the search results itself are paginated,
but not the ancestors.
If we don't do this, we might not preload a parent group of a search
result as it has been cut off by pagination.
|
| | |
|
