summaryrefslogtreecommitdiff
path: root/spec/controllers/groups/milestones_controller_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@13-3-stable-eeGitLab Bot2020-08-201-0/+1
|
* Add latest changes from gitlab-org/gitlab@13-1-stable-eeGitLab Bot2020-06-181-65/+16
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2020-02-061-12/+12
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2020-01-291-0/+47
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2020-01-161-0/+13
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-261-0/+18
|
* Hide disabled project milestones in project settings on group levelAlexandru Croitor2019-09-301-2/+69
|
* Change `be_success` to `be_successful` in specsfix-deprecation-warnings-change-success-to-successfulVitali Tatarintev2019-08-191-1/+1
| | | | | | | | | | Fixes deprecation warning: ``` DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers. ```
* Cleanup usages of `JSON.parse` in specsPeter Leitzen2019-07-161-1/+1
| | | | Prefer `json_response` where applicable.
* Add some frozen string to spec/**/*.rbgfyoung2019-04-151-0/+2
| | | | | | | | | | Adds frozen string to the following: * spec/bin/**/*.rb * spec/config/**/*.rb * spec/controllers/**/*.rb xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
* Move Contribution Analytics related spec in ↵Imre Farkas2019-04-091-0/+6
| | | | spec/features/groups/group_page_with_external_authorization_service_spec to EE
* Revert "Merge branch 'if-57131-external_auth_to_ce' into 'master'"Andreas Brandl2019-04-051-6/+0
| | | This reverts merge request !26823
* Move Contribution Analytics related spec in ↵Imre Farkas2019-04-051-0/+6
| | | | spec/features/groups/group_page_with_external_authorization_service_spec to EE
* Adds milestone searchJacopo2019-01-241-3/+28
| | | | | | | Adds to search ILIKE search for milestones title in: - Milestones dashboard - Group milestones page - Project milestones page
* Add project milestone link to dashboard milestonesccr/49289_milestone_linkFatih Acet2018-12-201-1/+1
| | | | | | One of the steps to deprecate dashboard milestones. Links do dashboard milestone are replaced with links for each project milestone
* Update specs to rails5 formatblackst0ne-convert-specs-rails5-styleblackst0ne2018-12-191-28/+40
| | | | | | | | | | Updates specs to use new rails5 format. The old format: `get :show, { some: params }, { some: headers }` The new format: `get :show, params: { some: params }, headers: { some: headers }`
* Fix typos in comments and specsGeorge Tsiolis2018-11-011-2/+2
|
* Allow to delete group milestonesissue_36138Felipe Artur2018-08-061-0/+11
|
* Resolve "Rename the `Master` role to `Maintainer`" BackendMark Chao2018-07-111-1/+1
|
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-221-1/+1
|
* Refactor `have_http_status` into `have_gitlab_http_status` in the specsJacopo2017-10-201-7/+7
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-021-2/+2
|
* Native group milestonesFelipe Artur2017-07-071-17/+101
|
* Add tests for Groups::MilestonesController#indexTakuya Noguchi2017-06-261-0/+15
|
* Refactor to more robust implementationfix-issue-32506Michael Kozono2017-05-191-3/+132
| | | | | | In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change: When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
* Added controller specsPhil Hughes2017-04-261-0/+12
|
* Use `empty_project` where possible in controller specsrs-empty_project-controllersRobert Speicher2017-01-251-1/+1
|
* fixes part1 of files to start using active tensetiagonbotelho2016-08-091-1/+1
|
* Implement review suggestionsFelipe Artur2016-04-071-1/+1
|
* Improve codeFelipe Artur2016-04-051-1/+1
|
* Fix problem when creating milestones in groups without projectsFelipe Artur2016-04-051-0/+6
|
* Fix Error 500 when creating global milestones with Unicode charactersStan Hu2015-12-051-0/+27
Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
View Lorry Controller Status