summaryrefslogtreecommitdiff
path: root/spec/controllers/groups
Commit message (Collapse)AuthorAgeFilesLines
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-221-1/+1
|
* Bugfix: User can't change the access level of an access requesterRubén Dávila2017-12-111-0/+19
| | | | | The endpoint was returning 404 because it was only searching on the current members of a Group or Project and not the access requesters.
* Support uploads for groupsJarka Kadlecova2017-12-071-0/+10
|
* Remove the selects when counting the last pageBob Van Landuyt2017-11-171-0/+11
| | | | | | | | | | | The last page of the first collection is only loaded into memory when it is being viewed. If it isn't loaded into memory, the `#size` call triggers a count query. This `#count` would generate an invalid query if our custom preloaded counts are included by adding a separate `as count_column` alias on top of the count aliases. Removing the selects in this case will make sure a valid `COUNT(*)` is generated.
* Refactor `have_http_status` into `have_gitlab_http_status` in the specsJacopo2017-10-205-19/+19
|
* Make sure we always return an array of hierarchiesBob Van Landuyt2017-10-131-0/+9
| | | | Even when we pass an array of only a single object
* Nest the group_children_path inside the canonical group pathBob Van Landuyt2017-10-121-0/+277
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-021-2/+2
|
* Native group milestonesFelipe Artur2017-07-071-17/+101
|
* gb nice catchesShinya Maeda2017-07-071-1/+1
|
* Basic BE changeShinya Maeda2017-07-072-0/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Basic BE change Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Implement CURD Rename codes related to VariableGroup and VariableProject FE part Remove unneccesary changes Make Fe code up-to-date Add protected flag to migration file Protected group variables essential package Update schema Improve doc Fix logic and spec for models Fix logic and spec for controllers Fix logic and spec for views(pre feature) Add feature spec Fixed bugs. placeholder. reveal button. doc. Add changelog Remove unnecessary comment godfat nice catches Improve secret_variables_for arctecture Fix spec Fix StaticAnlysys & path_regex spec Revert "Improve secret_variables_for arctecture" This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1. Use ayufan suggestion for secret_variables_for Use find instead of find_by Fix spec message for variable is invalid Fix spec remove variable.group_id = group.id godffat spec nitpicks Use include Gitlab::Routing.url_helpers for presenter spec
* Add tests for Groups::MilestonesController#indexTakuya Noguchi2017-06-261-0/+15
|
* Correct RSpec/SingleLineHook cop offensesRobert Speicher2017-06-141-14/+42
|
* Fix failing specAlfredo Sumaran2017-06-071-1/+1
|
* Add json support to group members leave action in controllerDmitriy Zaporozhets2017-06-061-0/+7
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Refactor to more robust implementationfix-issue-32506Michael Kozono2017-05-191-3/+132
| | | | | | In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change: When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
* Added controller specsPhil Hughes2017-04-261-0/+12
|
* Use `empty_project` where possible in controller specsrs-empty_project-controllersRobert Speicher2017-01-251-1/+1
|
* Add toggle_subscription action to Groups::LabelsControllerDouglas Barbosa Alexandre2016-11-171-0/+22
|
* Make access request specs explicitly enable or disable access requests as ↵Nick Thomas2016-11-111-1/+1
| | | | required
* Refactor create member tests from group_members_controller_specDmitriy Zaporozhets2016-10-241-41/+30
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Gracefully handle adding of no users to projects and groupsLinus G Thiel2016-10-241-0/+54
| | | | | | | | | | | | | | | | - Disable {project, group} members submit button if no users If no users are selected, the submit button should be disabled. - Alert user when no users were added to {project, group}. When no users were selected for adding, an alert message is flashed that no users were added. - Also, this commit adds a feedback when users were actually added to a project, in symmetry with how group members are handled. Closes #22967, #23270.
* Refactor group_members_controller_specdz-refactor-some-specsDmitriy Zaporozhets2016-10-191-86/+34
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Fix a few things after the initial improvment to Members::DestroyServiceRémy Coutable2016-10-031-2/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Ensure Members::ApproveAccessRequestService can fin a requester by IDRémy Coutable2016-09-221-1/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* fixes part1 of files to start using active tensetiagonbotelho2016-08-092-2/+2
|
* Exclude requesters from Project#members, Group#members and User#membersexplicit-requesters-scopeRémy Coutable2016-07-011-3/+3
| | | | | | And create new Project#requesters, Group#requesters scopes. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Use HTTP matchers if possibleZ.J. van de Weg2016-06-271-7/+7
|
* Fix and remove duplicate specs18755-fix-destroy-project-causes-post_decline_request-to-be-executedRémy Coutable2016-06-201-3/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Redirect to the member's source on request withdrawalRémy Coutable2016-06-181-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Re-use notifications dropdown/modal for user profileFelipe Artur2016-06-171-32/+0
|\
| * Re-use notifications dropdown on user profileFelipe Artur2016-06-161-32/+0
| |
* | UI and copywriting improvements13948-access-request-to-projects-and-groupsRémy Coutable2016-06-141-12/+12
| | | | | | | | | | | | | | | | | | + Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Factorize #request_access and #approve_access_request into a new ↵Rémy Coutable2016-06-141-3/+3
| | | | | | | | | | | | AccessRequestActions controller concern Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Add request access for groupsRémy Coutable2016-06-141-2/+196
|/ | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove group members checkFelipe Artur2016-04-181-3/+5
|
* Fix codeFelipe Artur2016-04-181-2/+1
|
* Add specs and fix codeFelipe Artur2016-04-181-0/+19
|
* Improve specs for group/project notification controllerdecouple-member-notificationDouglas Barbosa Alexandre2016-04-121-1/+16
|
* Requires user to be signed in when changing notification settingsDouglas Barbosa Alexandre2016-04-111-0/+17
|
* Implement review suggestionsFelipe Artur2016-04-071-1/+1
|
* Improve codeFelipe Artur2016-04-051-1/+1
|
* Fix problem when creating milestones in groups without projectsFelipe Artur2016-04-051-0/+6
|
* Fix more specsDouwe Maan2016-03-201-1/+2
|
* Fix Error 500 when creating global milestones with Unicode charactersStan Hu2015-12-051-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
* Fix bug where avatar filenames were not actually deleted from the database ↵Stan Hu2015-05-071-0/+17
during removal. This would result in a 404 error in certain views. The `save` call was being rolled back due to an error in the validation step. Relax the validation step so that this works. Closes #1570
View Lorry Controller Status