summaryrefslogtreecommitdiff
path: root/spec/controllers/groups
Commit message (Collapse)AuthorAgeFilesLines
* Refactor group_members_controller_specdz-refactor-some-specsDmitriy Zaporozhets2016-10-191-86/+34
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Fix a few things after the initial improvment to Members::DestroyServiceRémy Coutable2016-10-031-2/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Ensure Members::ApproveAccessRequestService can fin a requester by IDRémy Coutable2016-09-221-1/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* fixes part1 of files to start using active tensetiagonbotelho2016-08-092-2/+2
|
* Exclude requesters from Project#members, Group#members and User#membersexplicit-requesters-scopeRémy Coutable2016-07-011-3/+3
| | | | | | And create new Project#requesters, Group#requesters scopes. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Use HTTP matchers if possibleZ.J. van de Weg2016-06-271-7/+7
|
* Fix and remove duplicate specs18755-fix-destroy-project-causes-post_decline_request-to-be-executedRémy Coutable2016-06-201-3/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Redirect to the member's source on request withdrawalRémy Coutable2016-06-181-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Re-use notifications dropdown/modal for user profileFelipe Artur2016-06-171-32/+0
|\
| * Re-use notifications dropdown on user profileFelipe Artur2016-06-161-32/+0
| |
* | UI and copywriting improvements13948-access-request-to-projects-and-groupsRémy Coutable2016-06-141-12/+12
| | | | | | | | | | | | | | | | | | + Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Factorize #request_access and #approve_access_request into a new ↵Rémy Coutable2016-06-141-3/+3
| | | | | | | | | | | | AccessRequestActions controller concern Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Add request access for groupsRémy Coutable2016-06-141-2/+196
|/ | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove group members checkFelipe Artur2016-04-181-3/+5
|
* Fix codeFelipe Artur2016-04-181-2/+1
|
* Add specs and fix codeFelipe Artur2016-04-181-0/+19
|
* Improve specs for group/project notification controllerdecouple-member-notificationDouglas Barbosa Alexandre2016-04-121-1/+16
|
* Requires user to be signed in when changing notification settingsDouglas Barbosa Alexandre2016-04-111-0/+17
|
* Implement review suggestionsFelipe Artur2016-04-071-1/+1
|
* Improve codeFelipe Artur2016-04-051-1/+1
|
* Fix problem when creating milestones in groups without projectsFelipe Artur2016-04-051-0/+6
|
* Fix more specsDouwe Maan2016-03-201-1/+2
|
* Fix Error 500 when creating global milestones with Unicode charactersStan Hu2015-12-051-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
* Fix bug where avatar filenames were not actually deleted from the database ↵Stan Hu2015-05-071-0/+17
during removal. This would result in a 404 error in certain views. The `save` call was being rolled back due to an error in the validation step. Relax the validation step so that this works. Closes #1570
View Lorry Controller Status