summaryrefslogtreecommitdiff
path: root/spec/controllers/projects/issues_controller_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Update specs to rails5 formatblackst0ne-convert-specs-rails5-styleblackst0ne2018-12-191-74/+107
| | | | | | | | | | Updates specs to use new rails5 format. The old format: `get :show, { some: params }, { some: headers }` The new format: `get :show, params: { some: params }, headers: { some: headers }`
* Do not save user preferences on read-only modeFelipe Artur2018-12-121-0/+2
|
* Merge branch 'security-fix-pat-web-access' into 'master'Cindy Pallares2018-11-281-0/+36
| | | | | [master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request" See merge request gitlab/gitlabhq!2583
* Resolve "Filter discussion (tab) by comments or activity in issues and merge ↵Oswaldo Ferreira2018-10-231-0/+7
| | | | requests"
* Fix issues controller N+1 failureSean McGivern2018-10-051-1/+1
| | | | | | EE needs :request_store to cache license queries - otherwise we will blow past the query limit just with `SELECT * FROM licenses` over and over.
* Banzai project ref- share context more aggresivelyMario de la Ossa2018-10-041-0/+12
| | | | | | | Changes `Banzai::CrossProjectReference#parent_from_ref` to return the project in the context if the project's `full_path` matches the ref we're looking for, as it makes no sense to go to the database to find a Project we already have loaded.
* Show the status of a user in interactionsBob Van Landuyt2018-07-301-0/+23
| | | | | | | | | | | | | | | The status is shown for - The author of a commit when viewing a commit - Notes on a commit (regular/diff) - The user that triggered a pipeline when viewing a pipeline - The author of a merge request when viewing a merge request - The author of notes on a merge request (regular/diff) - The author of an issue when viewing an issue - The author of notes on an issue - The author of a snippet when viewing a snippet - The author of notes on a snippet - A user's profile page - The list of members of a group/user
* Resolve "Rename the `Master` role to `Maintainer`" BackendMark Chao2018-07-111-2/+2
|
* Changes tab VUE refactoringFelipe Artur2018-06-211-1/+1
|
* Reduce CE/EE diff in spec/controllers/projects/issues_controller_spec.rbRémy Coutable2018-05-241-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Spec improvements for speed, reliability and readabilityBob Van Landuyt2018-04-121-1/+1
|
* Correct permissions for creating merge requests from issuesBob Van Landuyt2018-04-111-1/+17
| | | | | | | This could only be possible for users that can create merge requests within a project. So they need to be a allowed to create a branch and create a merge request.
* Refactor discussions/notes codeJan Provaznik2018-04-031-1/+1
|
* Render MR Notes with Vue with behind a cookieFatih Acet2018-02-281-1/+1
|
* Make pagination optional for issuablesJan Provaznik2018-01-301-0/+12
| | | | | | | | | | On epics roadmap page we list all epics in the given time frame without pagination (at least for the first iteration), in this case it would be nice to use the existing issuables index logic except pagination (see MR gitlab-ee!4281). For this reason this patch allows to easily disable pagination. Related gitlab-ee!4281
* Return last edited time instead of update time41247-timestampJan Provaznik2018-01-181-19/+47
| | | | | | | | | | | | | For issuable models we keep two timestamps: updated_at which is updated whenever any model attribute is changed, last_edited_at which is changed when only title or description is changed. In UI bellow description we display who and when updated the item. But last_edited_by (used for 'who') is mistakenly combined with updated_at (when), last_edited_at should be used instead. Closes #41247
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-221-14/+14
|
* Merge branch ↵Douwe Maan2017-12-181-1/+1
|\ | | | | | | | | | | | | | | | | '40871-todo-notification-count-shows-notification-without-having-a-todo' into 'master' Resolve "Todo notification count shows notification without having a todo" Closes #40871 See merge request gitlab-org/gitlab-ce!15807
| * Reset todo counters when the target is deleted40871-todo-notification-count-shows-notification-without-having-a-todoSean McGivern2017-12-181-1/+1
| | | | | | | | | | | | When the target is deleted, todos are destroyed, but we did not reset the todo cache for users with todos on the deleted target. This would only update after the next time the todo cache was updated for that user.
* | Resolve "No feedback when checking on checklist if potential spam was detected"Luke Bennett2017-12-081-5/+18
|/
* Refactor issuable destroy actionJarka Kadlecova2017-11-061-1/+1
|
* CE port of code changed for epicsjk-epic-changes-ce-portJarka Kadlecova2017-11-021-0/+39
|
* Revert "Merge branch '36670-remove-edit-form' into 'master'"39441-bring-edit-form-backSean McGivern2017-10-261-0/+23
| | | | | This reverts commit 915e35a2992a4e51db2ac32aac8d7a29b1f4449e, reversing changes made to 9533786f522e358f372d8a0ec4b4990ae9d88f37.
* Refactor `have_http_status` into `have_gitlab_http_status` in the specsJacopo2017-10-201-22/+22
|
* Merge branch 'security-10-1' into '10-1-stable'Jen-Shin Lin2017-10-171-28/+29
| | | | | Security fixes for 10.1 RC See merge request gitlab/gitlabhq!2209
* refactor issues_controller_spec `update` actionJarka Kadlecova2017-10-031-157/+140
|
* Remove edit action for issuesJarka Kadlecova2017-10-031-29/+7
|
* Eliminate N+1 queries in loading discussions.json endpointsh-optimize-discussion-jsonStan Hu2017-09-181-0/+32
| | | | | | | | | | | | | | In #37955,we see that the profile had a number of N+1 queries from repeated access to `cross_reference_not_visible_for?`. This was optimized in previous versions of GitLab by rendering all notes at once, counting the number of visible references, and then using that number to check whether a system note should be fully redacted. There was also another N+1 query calling `ProjectTeam#member?`, which did not take advantage of an optimization in prepare_notes_for_rendering that would preload the maximum access level per project. Closes #37955
* Move "Move to different project" to sidebar34261-move-move-to-sidebarEric Eastwood2017-09-031-101/+108
| | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34261
* Merge branch 'master' into issue-discussions-refactorDouwe Maan2017-08-301-4/+4
|\ | | | | | | | | # Conflicts: # app/models/issue.rb
| * replace `is_spam?` with `spam?`Maxim Rydkin2017-08-291-4/+4
| |
* | Merge branch 'master' into issue-discussions-refactorDouwe Maan2017-08-171-2/+4
|\ \ | |/ | | | | | | | | # Conflicts: # package.json # spec/support/features/reportable_note_shared_examples.rb
| * Just use the repo. Not sure why master could passLin Jen-Shin2017-08-111-2/+2
| | | | | | | | | | It keeps giving me no repo error from setting up autocrlf, which shouldn't have anything to do with this merge request.
| * Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2017-08-111-3/+3
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 36089-handle-ref-failure-better * upstream/master: (62 commits) Update gitlab.po: Missing 'r' in "Fouché" that comes from "Fourcher" verb. Docs: update user docs index Fix minor typos in views Fix Layout/SpaceBeforeBlockBraces violation in bin/changelog_spec Merge branch 'rs-alphanumeric-ssh-params' into 'security-9-4' Merge branch 'import-symlinks-9-3' into 'security-9-3' Fix wrong method call on prometheus histogram Document new all-in-one Helm chart - docs Fix 404 on link path Fix line numbers not matching up to code in code viewer. Hide overflow-x on collapsed sidebar removed global use of breakpoint checker Increase performance of the breakpoint size checker Filter sensitive query string parameters from NGINX access logs Added a template for database changes Render new issue link in failed job as a regular link instead of a UJS one Include RE2 in the upgrade docs Remove affix plugin from issuable sidebar with new navigation Fix linter error alternative route for download archive ...
| * | Fix more testsLin Jen-Shin2017-08-111-0/+2
| | |
| * | Don't try to create diffs if one of the branch is missingLin Jen-Shin2017-08-101-1/+1
| | | | | | | | | | | | Also fix a few tests
| * | Fix some tests and report the error messageLin Jen-Shin2017-08-091-1/+1
| | |
* | | fix static_analysis (rubocop)Jarka Kadlecova2017-08-141-2/+1
| | |
* | | Use UserNoteEntity instead of UserEntity for notesJarka Kadlecova2017-08-111-0/+16
| |/ |/|
* | Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-091-3/+3
|/ | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-021-3/+3
|
* Merge branch 'dz-update-shoulda' into 'master'Rémy Coutable2017-07-251-1/+1
|\ | | | | | | | | Update shoulda-matchers gem to 3.1.2 See merge request !13040
| * Remove unnecessary set_flash.now from controller specsDmitriy Zaporozhets2017-07-241-1/+1
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Associate Issues tab only with internal issues trackerJarka Kadlecova2017-07-241-19/+40
|/
* Merge branch '34930-fix-edited-by' into 'master'Sean McGivern2017-07-191-0/+30
|\ | | | | | | | | | | | | Fix issue detail if user who last edited an issue was deleted Closes #34930 See merge request !12933
| * Use Ghost user when edited_by, merged_by deleted34930-fix-edited-byJarka Kadlecova2017-07-191-0/+30
| |
* | Fix external issue trackers redirectissue_35132Felipe Artur2017-07-181-6/+10
|/
* Create and use project path helpers that only need a project, no namespaceDouwe Maan2017-07-051-2/+2
|
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-6/+6
|
* Rename "Slash commands" to "Quick actions"Eric Eastwood2017-06-151-1/+1
| | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand`