| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a fairly straightforward refactor to extract the tracing
and correlation-id code from the gitlab rails codebase into the new
LabKit-Ruby project.
The corresponding import into LabKit-Ruby was in
https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1
The code itself remains very similar for now.
Extracting it allows us to reuse it in other projects, such as
Gitaly-Ruby. This will give us the advantages of correlation-ids and
distributed tracing in that project too.
|
| |
|
|
|
|
| |
- In prometheus proxy api, allow variables to be replaced. For example,
if 'up{env="%{ci_environment_slug}"}' is passed to the endpoint, it
becomes 'up{env="production"}' before being sent to prometheus.
|
| |\
| |
| |
| |
| |
| |
| | |
Validate refs used in controllers don't have spaces
Closes #58572 and gitaly#1425
See merge request gitlab-org/gitlab-ce!24037
|
| | |
| |
| |
| |
| |
| |
| | |
This avoids an unnecessary call to Gitaly and reduces gRPC errors.
* Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
* Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58572
|
| |/
|
|
|
|
|
|
|
|
| |
Adds frozen string to the following:
* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb
xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
|
| |
|
|
|
|
|
| |
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
|
| |
|
|
| |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
| |\
| |
| |
| |
| | |
[Backport] Support multiple assignees for merge requests
See merge request gitlab-org/gitlab-ce!27089
|
| | |
| |
| |
| |
| | |
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
|
| | | |
|
| |/
|
|
| |
Also set the release sha and author
|
| |
|
|
|
|
| |
Accessing /namespace/project/tree/master appears to query
FindCommit 5 times with identical parameters. This reduces
the number of FindCommit queries to 1.
|
| |
|
|
|
|
|
|
|
|
|
| |
This enables FindCommit caching to the following actions:
* BlobController#show
* RefsController#logs_tree
It also improves caching in CommitsController since some
duplicate requests were occuring inside the before_action
definitions.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add columns to store project creation settings
Add project creation level column in groups
and default project creation column in application settings
Remove obsolete line from schema
Update migration with project_creation_level column existence check
Rename migrations to avoid conflicts
Update migration methods
Update migration method
|
| |\
| |
| |
| |
| | |
Revert "Merge branch 'if-57131-external_auth_to_ce' into 'master'"
See merge request gitlab-org/gitlab-ce!27051
|
| | |
| |
| | |
This reverts merge request !26823
|
| |/
|
|
|
| |
This reduces a handful of duplicate FindCommit calls while viewing the
projects and commits pages.
|
| |
|
|
| |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
| |\
| |
| |
| |
| |
| |
| | |
Add a prometheus proxy API per environment
Closes #58375
See merge request gitlab-org/gitlab-ce!26841
|
| | | |
|
| | |
| |
| |
| | |
The names can change in different runs of the spec.
|
| | | |
|
| | |
| |
| |
| | |
- It is now being done in ProxyService class.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
The api will proxy requests to the environment's prometheus server.
The Prometheus::ProxyService class can be reused when we add support for
group prometheus servers.
|
| | |
| |
| |
| |
| |
| |
| | |
- rewords examples starting with 'should'
- rewords examples starting with 'it'
Note: I had to manually fixup "onlies" to "only"
|
| |/
|
|
|
|
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26248 added
support for deduplicating FindCommit requests using Gitaly ref name
caching. However, not all endpoints were covered, and in one case the
Gitaly wrapper wasn't actually surrounding the serialization step. We
can safely cache ref names between FindCommit calls for #index and #show
endpoints for merge requests and pipelines. This can significantly
reduce the number of FindCommit requests.
|
| |
|
|
|
|
| |
We're moving from using terminology related to terminals when
we refer to Websockets connections in Workhorse.
It's more appropiate a concept like channel.
|
| |\
| |
| |
| |
| |
| |
| | |
Resolve "Failing group transfer disables expandable sections"
Closes #45511
See merge request gitlab-org/gitlab-ce!26837
|
| | | |
|
| | |
| |
| |
| |
| | |
This fixes the bug, when approver filter is provided,
but dashboard asks to enter any filter
|
| | |
| |
| |
| |
| | |
- added suggestions to mock data
- fixed props to be not required
|
| |/
|
|
|
|
|
|
|
| |
Adds support for start and end parameters in the #additional_metrics
endpoint of the EnvironmentsController. start and end are meant to be
unix timestamps, per the Prometheus API (as the consumer of this
endpoint will eventually be transitioned to a prometheus endpoint).
This functionality is behind the :metrics_time_window feature flag
for development.
|
| |\
| |
| |
| |
| | |
Cache FindCommit results in pipelines view
See merge request gitlab-org/gitlab-ce!26776
|
| | |
| |
| |
| |
| |
| |
| |
| | |
For each pipeline, the controller will call `Pipeline#latest?` to
determine if the pipeline's ref is the latest for that branch.
Since it's likely that the same branches are being used in each
pipeline, we can reduce Gitaly overhead by caching the results
of the FindCommit call.
|
| |\ \
| |/
|/|
| | |
jarv/dev-to-gitlab-2019-04-02
|
| | |\
| | |
| | |
| | |
| | | |
Return cached languages if they've been detected before
See merge request gitlab/gitlabhq!2998
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
Disallow changing namespace of a project in update method
See merge request gitlab/gitlabhq!3028
|
| | | | | |
|
| | | | | |
|
| | | |/ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.
This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.
This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
|
| |/ /
| |
| |
| | |
Check if user can access API on GraphqlController
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
* dev/master:
Update CHANGELOG.md for 11.8.3
Update CHANGELOG.md for 11.7.7
Only return `commands_changes` used in frontend
|
| | |\ \
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
'master'
Fix project serialization in quick actions response
Closes #2826
See merge request gitlab/gitlabhq!3001
|
| | | |
| | |
| | |
| | |
| | | |
When executing quick actions, this limits the `commands_changes`
response to only those used by the frontend
|
