summaryrefslogtreecommitdiff
path: root/spec/controllers
Commit message (Collapse)AuthorAgeFilesLines
* Resolve "Filter discussion (tab) by comments or activity in issues and merge ↵Oswaldo Ferreira2018-10-233-0/+46
| | | | requests"
* Merge branch 'ccr/43034_issues_controller_100_queries' into 'master'Douglas Barbosa Alexandre2018-10-191-2/+47
|\ | | | | | | | | | | | | Add preload for routes and namespaces for issues controller. Closes #43034 See merge request gitlab-org/gitlab-ce!21651
| * Add preload in issues controllerChantal Rollison2018-10-181-2/+47
| |
* | Merge branch 'bvl-remove-forked-project-link' into 'master'Sean McGivern2018-10-191-4/+6
|\ \ | | | | | | | | | | | | | | | | | | Remove ForkedProjectLink model Closes #38883 See merge request gitlab-org/gitlab-ce!22226
| * | Remove the `ForkedProjectLink` modelBob Van Landuyt2018-10-191-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the `ForkedProjectLink` model that has been replaced by the `ForkNetworkMember` and `ForkNetwork` combination. All existing relations have been adjusted to use these new models. The `forked_project_link` table has been dropped. The "Forks" count on the admin dashboard has been updated to count all `ForkNetworkMember` rows and deduct the number of `ForkNetwork` rows. This is because now the "root-project" of a fork network also has a `ForkNetworkMember` row. This count could become inaccurate when the root of a fork network is deleted.
* | | Fixed bug with the content disposition with wiki attachmentsFrancisco Javier López2018-10-171-11/+45
| | |
* | | Resolve "In web editor, when delete a file, should navigate to enclosing ↵George Thomas2018-10-171-0/+72
| | | | | | | | | | | | directory"
* | | Merge branch 'refactor-project-cluster-controller-specs' into 'master'Grzegorz Bizon2018-10-161-180/+106
|\ \ \ | | | | | | | | | | | | | | | | Project::ClustersController spec improvement See merge request gitlab-org/gitlab-ce!22346
| * | | Revert back to go but use arguments for some casesThong Kuah2018-10-161-114/+99
| | | | | | | | | | | | | | | | | | | | | | | | It has been pointed out that `go` is used quite extensively so it's not an unknown idiam here at GitLab. And we have arguments with `go` which is a plus.
| * | | Use subject in controller specThong Kuah2018-10-151-261/+202
| |/ / | | | | | | | | | | | | | | | | | | | | | Swap out `go` method with subject which is the convention. Re-organize 'PUT update' to remove un-necessary context nesting. DRY up repeated blocks to `add_maintainer` and `sign_in`
* | | Merge branch 'rails5-fix-utf' into 'master'Sean McGivern2018-10-161-7/+19
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Use InvalidUTF8ErrorHandler only for rails 4 Closes #51908 See merge request gitlab-org/gitlab-ce!22340
| * | Use InvalidUTF8ErrorHandler only for rails 4Jan Provaznik2018-10-131-7/+19
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 5 catches invalid UTF8 characters in querystring in a params middleware, errors are handled by a params middleware and raises a BadRequest exception. This means that these UTF8 errors are not raised deeper in application stack and these can't also be handled on application level. If we would want to have custom handler for these errors, we would have to create a new middleware and insert it before actionpack's params middleware and rescue BadRequest exceptions there. But there is no need to do this currently (see discussion on https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
* | Merge branch 'zj-remove-linguist' into 'master'Robert Speicher2018-10-151-1/+0
|\ \ | |/ |/| | | | | | | | | Remove dependencies on Linguist Closes #35450 See merge request gitlab-org/gitlab-ce!21008
| * Remove dependencies on LinguistZeger-Jan van de Weg2018-10-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This saves about 128 MB of baseline RAM usage per Unicorn and Sidekiq process (!). Linguist wasn't detecting languages anymore from CE/EE since 9ae8b57467ac8b38f1fa9020a466d94a93cbb9dd. However, Linguist::BlobHelper was still being depended on by BlobLike and others. This removes the Linguist gem, given it isn't required anymore. EscapeUtils were pulled in as dependency, but given Banzai depends on it, it is now added explicitly. Previously, Linguist was used to detect the best ACE mode. Instead, we rely on ACE to guess the best mode based on the file extension.
* | Add stage name in job.json responseSteve Azzopardi2018-10-121-0/+4
|/
* Remove Git circuit breakerZeger-Jan van de Weg2018-10-103-76/+2
| | | | | | | Was introduced in the time that GitLab still used NFS, which is not required anymore in most cases. By removing this, the API it calls will return empty responses. This interface has to be removed in the next major release, expected to be 12.0.
* Merge branch 'sh-handle-invalid-comparison' into 'master'Douwe Maan2018-10-091-0/+24
|\ | | | | | | | | | | | | Reject invalid branch names in repository compare controller Closes #51003 See merge request gitlab-org/gitlab-ce!22186
| * Reject invalid branch names in repository compare controllerStan Hu2018-10-081-0/+24
| | | | | | | | Closes #51003
* | Merge branch 'osw-remove-dead-code-on-mr-show' into 'master'Robert Speicher2018-10-081-22/+0
|\ \ | | | | | | | | | | | | | | | | | | Removes expensive dead code on main MR page request Closes #51172 See merge request gitlab-org/gitlab-ce!22153
| * | Remove dead code on main MR pageOswaldo Ferreira2018-10-051-22/+0
| | |
* | | Merge branch 'Fix-pipeline-redirect' into 'master'Grzegorz Bizon2018-10-081-16/+49
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Redirect to the pipeline builds page when a build is canceled Closes #39161 See merge request gitlab-org/gitlab-ce!21595
| * | | Redirect to the pipeline builds page when a build is canceledEva Kadlecová2018-09-171-16/+49
| | | |
* | | | Merge branch 'backport-ce-to-ee-spec-fix' into 'master'Rémy Coutable2018-10-081-1/+1
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | Fix issues controller N+1 failure See merge request gitlab-org/gitlab-ce!22141
| * | | Fix issues controller N+1 failureSean McGivern2018-10-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | EE needs :request_store to cache license queries - otherwise we will blow past the query limit just with `SELECT * FROM licenses` over and over.
* | | | Prepare admin/projects/show view to allow EE specific featureGabriel Mazetto2018-10-051-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In EE it will render a Geo Status widget when Geo is enabled and it is in a secondary node. Also added minimal specs to that action.
* | | | Merge branch ↵Sean McGivern2018-10-051-9/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '43109-ci_environments_status-json-executes-more-than-100-queries' into 'master' Resolve "Controller Projects::MergeRequestsController#ci_environments_status.json executes more than 100 SQL queries" Closes #43109 See merge request gitlab-org/gitlab-ce!21996
| * | | | Update spec comment to point to correct issueBrett Walker2018-10-051-1/+1
| | | | |
| * | | | Don't build project services unneccesarilyBrett Walker2018-10-041-9/+19
| | | | |
* | | | | Merge branch 'rails5-fix-artifacts-controller-spec' into 'master'Kamil Trzciński2018-10-051-6/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Rails5: fix artifacts controller download spec See merge request gitlab-org/gitlab-ce!22123
| * | | | | Rails5: fix artifacts controller download specJasper Maes2018-10-041-6/+8
| |/ / / / | | | | | | | | | | | | | | | | | | | | Rails5 has params[:file_type] as '' if file_type is included as nil in the request
* | | | | Merge branch 'master-ce' into scheduled-manual-jobsShinya Maeda2018-10-053-3/+39
|\ \ \ \ \
| * | | | | Put issues group search CTE behind a (default on) flag50246-can-t-sort-group-issues-by-popularity-when-searchingSean McGivern2018-10-051-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't think this is needed any more - see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21521, and https://gitlab.com/gitlab-org/gitlab-ce/issues/52271 for removing the flag.
| * | | | | Add spec for group issues search + sortingSean McGivern2018-10-051-2/+22
| | |/ / / | |/| | |
| * | | | Merge branch '50904-remove-icon-env' into 'master'Grzegorz Bizon2018-10-051-1/+0
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Removes icon key from job endpoint See merge request gitlab-org/gitlab-ce!22085
| | * | | | Removes icon key from job endpointFilipa Lacerda2018-10-041-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was added because we thought we'd need to render the environment status but we already have this information in the build status
| * | | | | Merge branch 'mao/48221-issues_show_sql_count' into 'master'Sean McGivern2018-10-051-0/+12
| |\ \ \ \ \ | | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Banzai label ref finder - minimize SQL calls by sharing context more aggresively Closes #48221 See merge request gitlab-org/gitlab-ce!22070
| | * | | | Banzai project ref- share context more aggresivelyMario de la Ossa2018-10-041-0/+12
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes `Banzai::CrossProjectReference#parent_from_ref` to return the project in the context if the project's `full_path` matches the ref we're looking for, as it makes no sense to go to the database to find a Project we already have loaded.
* | | | | Merge branch 'master-ce' into scheduled-manual-jobsShinya Maeda2018-10-053-0/+45
|\ \ \ \ \ | |/ / / /
| * | | | Simplify runner registration token resettingTomasz Maczukin2018-10-043-0/+45
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This icommit adds several changes related to the same topic - resetting a Runner registration token: 1. On Project settings page it adds a button for resetting the registration token and it removes the Runner token field that was confusing all GitLab users. 2. On Group settings page it adds the same button for resetting the registration token. 3. On Admin Runners settings page it moves the button to the same place as in Project and Group settings and it changes slightly the page layout to make it more similar to Group and Project setting pages. 4. It refactorizes a little the partial that prints runner registration description. Thanks to this Project, Group and Admin settings of the Runner are re-using the same code to generate the button. 5. Updates the translations of changed text.
* | | | Merge branch 'master-ce' into scheduled-manual-jobsShinya Maeda2018-10-031-3/+35
|\ \ \ \ | |/ / /
| * | | CE Resolve "Refactor code quality similar to JUnit tests"Matija Čupić2018-10-021-3/+35
| | | |
* | | | fix styleAlessio Caiazza2018-10-021-2/+2
| | | |
* | | | Add integration specShinya Maeda2018-10-021-0/+40
|/ / /
* | | Add custom header for error responsesDavid2018-10-011-0/+76
| | |
* | | Merge branch 'mk/asymmetric-exists-cache' into 'master'Stan Hu2018-09-281-0/+5
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Resolve "Geo: Does not mark repositories as missing on primary due to stale cache" Closes #50211 and #44044 See merge request gitlab-org/gitlab-ce!21789
| * | Cache `Repository#exists?` false in RequestStoreMichael Kozono2018-09-271-0/+5
| | | | | | | | | | | | | | | * Only truthy values are cached in Redis. * All values are cached in RequestStore and in an instance variable.
* | | Add has_trace to Projects::JobController#show.jsonSteve Azzopardi2018-09-271-0/+16
|/ / | | | | | | closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51925
* | Merge branch 'fa-handle_invalid_utf8_errors' into 'master'Stan Hu2018-09-251-0/+34
|\ \ | | | | | | | | | | | | Render 412 when invalid UTF-8 is passed as parameter See merge request gitlab-org/gitlab-ce!21774
| * | Render 412 for invalid UTF-8 parametersfa-handle_invalid_utf8_errorsFelipe Artur2018-09-221-0/+34
| | | | | | | | | | | | | | | Renders 412 error page when invalid UTF-8 is passed as parameters in controllers.
* | | Merge branch 'dm-create-note-return-discussion' into 'master'Filipa Lacerda2018-09-241-0/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Increase performance when creating discussion on diff Closes #49002 See merge request gitlab-org/gitlab-ce!21743
View Lorry Controller Status