summaryrefslogtreecommitdiff
path: root/spec/controllers
Commit message (Collapse)AuthorAgeFilesLines
* Enable the RSpec/HookArgument cop and auto-correct offensesRobert Speicher2017-08-102-2/+2
|
* Fix and improve spec/controllers/autocomplete_controller_spec.rbrc/improve-projects-factoryRémy Coutable2017-08-101-77/+56
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-096-11/+11
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'master' into ideMike Greiling2017-08-074-1/+64
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (177 commits) Add changelog Bump gitlab-shell version to 5.8.0 to fix Git for Windows 2.14 Make contextual sidebar collapsible Fixed sidebar context header hover colors Use correct `Environment`-class within `Gitlab` namespace Remove gl.Activities from Commits page Move `let` calls inside the `describe` block using them Add `/assign me` alias support for assigning issuables to oneself GRPC::Unavailable (< GRPC::BadStatus) is wrapped in a CommandError Use `broken_storage` in the fs_shards_spec. Eager load project creators for project dashboards Memoize a user's personal projects count Remove redundant query from User#recent_push Improve checking if projects would be returned Change spelling of gitlab-shell Remove unused #tree-holder Add custom linter for inline JavaScript to haml_lint Rename user_can_admin? because it's more accurate Synchronous zanata community contribution translation Add Korean translation to i18n ...
| * Add a Circuitbreaker for storage pathsBob Van Landuyt2017-08-043-0/+63
| |
| * fix #3686 make tarball download url to end with extensionhaseeb2017-08-031-1/+1
| |
* | Fix blob_controller_spec plain to raw_pathLuke "Jared" Bennett2017-08-041-1/+1
| |
* | Merge branch 'master' into ideDouwe Maan2017-08-0360-140/+109
|\ \ | |/
| * Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-0260-97/+97
| |
| * Merge branch 'rs-issuables-list-metadata-shared-examples' into 'master'Rémy Coutable2017-08-021-1/+3
| |\ | | | | | | | | | | | | Make the 'issuables list meta-data' shared example less dangerous See merge request !13236
| | * Make the 'issuables list meta-data' shared example less dangerousrs-issuables-list-metadata-shared-examplesRobert Speicher2017-08-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This shared example would take an object's database ID and create a number of objects based on it. If for some reason the ID were a high number, like 20, this would create `20 + 21 + 22` objects. Not only was this dangerous from a performance perspective, it was entirely unnecessary, as the behavior it was testing is already well-tested in the unit test for the underlying object. For a controller test, which is what's including this shared example, all we need to do is verify that the assigned object contains the correct `id => object` Hash, which is what we now test for.
| * | Ensure all project factories use `:repository` trait or `:empty_project`rs-empty_project-cleanupRobert Speicher2017-08-0113-33/+33
| |/
| * Merge branch '28283-legacy-storage-format' into 'master'Sean McGivern2017-08-014-8/+8
| |\ | | | | | | | | | | | | [CE] Added Legacy Storage format See merge request !13149
| | * Rename many path_with_namespace -> full_pathGabriel Mazetto2017-08-014-8/+8
| | |
| * | Add option to use CommitLanguages RPCJacob Vosmaer2017-08-011-33/+0
| |/
* | Merge remote-tracking branch 'origin/master' into ideLuke "Jared" Bennett2017-07-311-1/+61
|\ \ | |/
| * Merge branch 'fix-replying-to-commit-comment-in-mr-from-fork' into 'master'Douwe Maan2017-07-281-1/+61
| |\ | | | | | | | | | | | | | | | | | | Fix replying to commit comments on merge requests created from forks Closes #31772 See merge request !13137
| | * Fix replying to commit comments on MRs from forksSean McGivern2017-07-281-1/+61
| | | | | | | | | | | | | | | | | | A commit comment shows in the MR, but if the MR is from a fork, it will have a different project ID to the MR's target project. In that case, add an note_project_id param so that we can pick the correct project for the note.
* | | Merge remote-tracking branch 'origin/master' into ideLuke "Jared" Bennett2017-07-2811-37/+119
|\ \ \ | |/ /
| * | Merge branch '35224-transform-user-profile-javascript-into-async-bundle' ↵Tim Zallmann2017-07-281-2/+2
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Resolve "Transform user profile javascript into async bundle" Closes #35224 See merge request !12929
| | * | fix broken testsMike Greiling2017-07-191-2/+2
| | | |
| * | | Backport gitlab-ee!2456Oswaldo Ferreira2017-07-272-4/+9
| | |/ | |/|
| * | Remove superfluous type defs in specsKeifer Furzland2017-07-271-1/+1
| | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | Merge branch '35453-pending-delete-projects-error-in-admin-dashboard-fix' ↵Sean McGivern2017-07-261-0/+21
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Fixes 500 error caused by pending delete projects in admin dashboard Closes #35453 See merge request !13067
| | * | Fixes 500 error caused by pending delete projects in admin dashboard35453-pending-delete-projects-error-in-admin-dashboard-fixTiago Botelho2017-07-251-0/+21
| | | |
| * | | Merge branch '30634-protected-pipeline' into 'master'Kamil Trzciński2017-07-252-3/+8
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement "Block pipelines on protected branches" Closes #30634, #34616, and #33130 See merge request !11910
| | * \ \ Merge remote-tracking branch 'upstream/master' into 30634-protected-pipelineLin Jen-Shin2017-07-207-14/+126
| | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (130 commits) Change auto-retry count to a correct value in docs Fix background migration cleanup specs Fix CI/CD job auto-retry specs Fix JS; make buttons sr accessibile; fix overlay remove redundant changelog entries Merge branch '24570-use-re2-for-user-supplied-regexp-9-3' into 'security-9-3' Merge branch '33303-404-for-unauthorized-project' into 'security-9-3' Merge branch '33359-pers-snippet-files-location' into 'security-9-3' Merge branch 'bvl-remove-appearance-symlink' into 'security-9-3' Hide description about protected branches to non-member Update CHANGELOG.md for 9.0.11 Update CHANGELOG.md for 9.1.8 Update CHANGELOG.md for 8.17.7 Update CHANGELOG.md for 9.2.8 Update CHANGELOG.md for 9.3.8 Respect blockquote line breaks in markdown 35209 Add wip message to new navigation preference section Add github imported projects count to usage data Add versions to Prometheus metrics doc Add Bulgarian translations of Pipeline Schedules ...
| | * | | | Instead of adding master, stub_not_protect_default_branchLin Jen-Shin2017-07-182-6/+11
| | | | | |
| | * | | | Merge remote-tracking branch 'upstream/master' into 30634-protected-pipelineLin Jen-Shin2017-07-1734-207/+866
| | |\ \ \ \ | | | | |_|/ | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (638 commits) Simplify background migrations stealing code Expire cached user IDs that can see the performance after 5 minutes Promote visibility level helpers from Group to Namespace Fix off-by-one error in background migration retries Recover from all exceptions when stealing bg migration Fix label creation from new list for subgroup projects move click handler to button. when on the icon it wasn't triggered in firefox Fix incorrect AWS ELB metrics. Fix wrong link to docs in docs styleguide Update issue-related docs Refactor groups docs Add subgroups limitations to Pages docs Update Google launcher details Split docs on IP whitelist for monitoring access Update health check docs Bump fog-core to 1.44.3 and fog providers' plugins to latest Introduce have_gitlab_http_status Remove Repository#search_files Update Pipeline's badge count in Merge Request and Commits view to match real-time content Fixes the user order being overriden in the autocomplete controller ...
| | * | | | Update tests due to permission changesLin Jen-Shin2017-07-042-9/+9
| | | | | |
| * | | | | Merge branch 'dz-update-shoulda' into 'master'Rémy Coutable2017-07-253-5/+5
| |\ \ \ \ \ | | |_|_|_|/ | |/| | | | | | | | | | | | | | | | Update shoulda-matchers gem to 3.1.2 See merge request !13040
| | * | | | Remove unnecessary set_flash.now from controller specsDmitriy Zaporozhets2017-07-243-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | Associate Issues tab only with internal issues trackerJarka Kadlecova2017-07-241-19/+40
| |/ / / /
| * | | | Merge branch 'zj-pipeline-badge-improvements' into 'master'Grzegorz Bizon2017-07-221-0/+28
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pipeline badge improvements Closes #15582 and #20961 See merge request !12966
| | * | | | Rename build to pipeline for status badgesZ.J. van de Weg2017-07-211-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First commit in probably 2, for resolve gitlab-org/gitlab-ce#15582. This commit is renaming files and classes from build to pipeline. Also wording is editted to pipeline. Given `pipeline` had more characters than `build`, I've made the field a bit wider. The width now matchers the one for the coverage badge, so they look nice when in a table format, or in a list. As soon as this commit is merged to master, and released, the build.svg is deprecated, meaning that all users which already placed a badge should update it. However, to make sure it keeps working tests are added for this case.
| * | | | | Merge branch '34549-extract-devise-mappings-into-helper' into 'master'Rémy Coutable2017-07-211-3/+5
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract "@request.env['devise.mapping'] = Devise.mappings[:user]" to a test helper Closes #34549 See merge request !12742
| | * | | | Extract "@request.env['devise.mapping'] = Devise.mappings[:user]" to a test ↵Jacopo2017-07-201-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | helper Extracted `@request.env['devise.mapping'] = Devise.mappings[:user]` and `Rails.application.env_config['devise.mapping'] = Devise.mappings[:user]` in our tests into the helper method `set_devise_mapping`
* | | | | | Merge remote-tracking branch 'origin/master' into ideLuke "Jared" Bennett2017-07-2046-786/+1868
|\ \ \ \ \ \ | |/ / / / /
| * | | | | Wrong data type when testing webhooksAlexander Randa2017-07-201-0/+21
| | |_|_|/ | |/| | |
| * | | | Merge branch 'fix/gb/fix-container-registry-tag-routing' into 'master'Kamil Trzciński2017-07-201-0/+48
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix docker tag reference routing constraints Closes #35220 and gitlab-com/support-forum#2246 See merge request !12961
| | * | | | Fix docker tag reference routing constraintsGrzegorz Bizon2017-07-191-0/+48
| | | |_|/ | | |/| |
| * | | | Merge branch '33303-404-for-unauthorized-project' into 'security-9-3'Sean McGivern2017-07-191-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | [9.3 security fix] Renders 404 if given project is not readable by the user on Todos dashboard See merge request !2118
| * | | | Merge branch '33359-pers-snippet-files-location' into 'security-9-3'Sean McGivern2017-07-192-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Use uploads/system directory for personal snippets See merge request !2123
| * | | | Merge branch '34930-fix-edited-by' into 'master'Sean McGivern2017-07-191-0/+30
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix issue detail if user who last edited an issue was deleted Closes #34930 See merge request !12933
| | * | | | Use Ghost user when edited_by, merged_by deleted34930-fix-edited-byJarka Kadlecova2017-07-191-0/+30
| | |/ / /
| * | | | Merge branch 'authentiq-updates' into 'master'Rémy Coutable2017-07-191-1/+1
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Added authentiq provider to tests and updated documentation, gem and config file. See merge request !12952
| | * | | | Added authentiq provider to tests and updated documentation, gem and config ↵Alexandros Keramidas2017-07-181-1/+1
| | | |/ / | | |/| | | | | | | | | | | | file.
| * | | | Merge branch 'issue_35132' into 'master'Sean McGivern2017-07-191-6/+10
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix external issue trackers redirect Closes #35132 See merge request !12923
| | * | | | Fix external issue trackers redirectissue_35132Felipe Artur2017-07-181-6/+10
| | | |/ / | | |/| |
| * | | | Update Prometheus gem to version that explicitly calls `munmap`Paweł Chojnacki2017-07-191-1/+1
| |/ / /