summaryrefslogtreecommitdiff
path: root/spec/controllers
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'ce-port-315-log-impersonation-actions-in-audit-log' into 'master'Ash McKenzie2019-07-231-0/+6
|\ | | | | | | | | CE Port: Log impersonation actions in audit log See merge request gitlab-org/gitlab-ce!31039
| * CE Port: Log impersonation actions in audit logce-port-315-log-impersonation-actions-in-audit-logmanojmj2019-07-231-0/+6
| | | | | | | | | | | | This change adds audit logs for user impersonation when an admin starts/stops impersonating another user.
* | Bring backward compatibility for request profilesKamil Trzciński2019-07-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | It seems that we missed the backward compatibility support for profiles in the existing folder. This commit also fixes some specs to be idempotent and work in a temporary directory which not always seems to be the case. This commit also brings the profile_spec.rb which seems to be missing.
* | Add review remarksGosia Ksionek2019-07-221-0/+64
| | | | | | | | | | | | Add cr remarks Add cr remarks
* | Merge branch 'maintainers-can-create-subgroup' into 'master'Sean McGivern2019-07-221-0/+8
|\ \ | | | | | | | | | | | | Add a group setting to allow Maintainers to create sub-groups See merge request gitlab-org/gitlab-ce!29718
| * | Style rules; Revert some examplesFabio Papa2019-07-191-4/+2
| | |
| * | Make subgroup_creation_level default to maintainer at SQL levelFabio Papa2019-07-191-4/+3
| | | | | | | | | | | | | | | | | | - Migration updates existing groups to "owner", then sets default to "maintainer" so that new groups will default to that - Update spec examples
| * | Style rules; Revert some examplesFabio Papa2019-07-191-2/+5
| | |
| * | Apply changes recomended by merge request coachFabio Papa2019-07-191-2/+0
| | |
| * | Make subgroup_creation_level default to maintainer at SQL levelFabio Papa2019-07-191-1/+1
| | | | | | | | | | | | | | | | | | - Migration updates existing groups to "owner", then sets default to "maintainer" so that new groups will default to that - Update spec examples
| * | Style rules; Revert some examplesFabio Papa2019-07-191-0/+2
| | |
| * | Apply changes recomended by merge request coachFabio Papa2019-07-191-4/+2
| | |
| * | Make subgroup_creation_level default to maintainer at SQL levelFabio Papa2019-07-191-4/+3
| | | | | | | | | | | | | | | | | | - Migration updates existing groups to "owner", then sets default to "maintainer" so that new groups will default to that - Update spec examples
| * | Style rules; Revert some examplesFabio Papa2019-07-191-2/+7
| | |
| * | Add examples specing the setting to choose who can create subgroupsFabio Papa2019-07-191-0/+6
| | | | | | | | | | | | | | | | | | | | | This setting is at the group level only. The default is specified to be maintainers and owners. **Specs only**, all failing.
* | | Removed project autocomplete paginationJan Provaznik2019-07-221-22/+0
|/ / | | | | | | | | | | This pagination is not used anywhere so there is no reason to keep it. It seems the usage of offset_id was probably removed in 90c60138db4e1f86026aac5760febe4ba066ca30
* | Added Usage Data for some Web IDE actionsFrancisco Javier López2019-07-192-0/+59
| | | | | | | | | | | | | | The actions tracked in the web IDE are: - creation of commits - creation of merge requests - projects loaded
* | Merge branch 'an-sidekiq-chaos' into 'master'Lin Jen-Shin2019-07-181-0/+127
|\ \ | | | | | | | | | | | | | | | | | | Adds chaos endpoints to Sidekiq Closes #64663 See merge request gitlab-org/gitlab-ce!30814
| * | Adds chaos endpoints to Sidekiqan-sidekiq-chaosAndrew Newdigate2019-07-181-0/+127
| | | | | | | | | | | | | | | This allows the chaos endpoints to be invoked in Sidekiq so that this environment can be tested for resilience.
* | | Merge branch 'group-milestones-dashboard-blunceford' into 'master'Sean McGivern2019-07-181-2/+13
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix bug in dashboard display of closed milestones Closes #59381 See merge request gitlab-org/gitlab-ce!30820
| * | | Cleaned up tests for group milestonesblunceford2019-07-171-14/+3
| | | |
| * | | Fix bug with closed milestones in dashboardblunceford2019-07-161-0/+22
| | | |
* | | | Add profile mode to extend request profilingadd-profile-mode-to-extend-request-profilingQingyu Zhao2019-07-181-19/+44
|/ / / | | | | | | | | | | | | | | | | | | Extend the support for "X-Profile-Token: <token>" to have an additional header that defines type of profile we are looking for, like: X-Profile-Mode: execution X-Profile-Mode: memory
* | | Refactor EnvironmentsController#metrics_dashboard endpointSarah Yasonik2019-07-161-71/+128
| | |
* | | Modified spec so a second call to json_response is avoided35757-add-result-to-requestPatrick Derichs2019-07-161-2/+7
| | |
* | | Use match_array instead of includePatrick Derichs2019-07-161-1/+1
| | |
* | | Add result to MoveService#execute_multiplePatrick Derichs2019-07-161-2/+11
|/ / | | | | | | | | | | | | | | It adds a hash response which includes the count, success state and the moved issues itself so the caller has additional information about the result of the process.
* | Cleanup usages of `JSON.parse` in specsPeter Leitzen2019-07-1627-97/+57
| | | | | | | | Prefer `json_response` where applicable.
* | Merge branch 'bvl-rename-routes-after-user-rename' into 'master'Jan Provaznik2019-07-121-1/+1
|\ \ | | | | | | | | | | | | Set the name of a user-namespace to the user name See merge request gitlab-org/gitlab-ce!23272
| * | Use namespace#path for building urls in specsBob Van Landuyt2019-07-091-1/+1
| | | | | | | | | | | | | | | | | | Some of the specs were using namespace names instead of paths for building URLS. This would fail since we now build a namespace with a user's name instead of a user's username.
* | | Upgrade to Rails 5.2upgrade-rails-5-2-ceHeinrich Lee Yu2019-07-121-2/+3
| | | | | | | | | | | | Updates changed method names and fixes spec failures
* | | Add endpoint to move multiple issues35757-move-issues-in-boards-pderichsPatrick Derichs2019-07-111-0/+195
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add specs for new endpoint to move multiple issues. Add changelog entry Just check the first issue for the ability to move / update Add specs for exceeding limits and malformed requests Changed name of shared examples Change title of changelog entry Use %i instead of %w Check permission to update issue on project instead of board Use admin_issue permission to check for issue move ability Changed variable name to avoid shadow issue_params method Rename route to bulk_move Change route definition Check permissions for each issue Combine methods for parameters permit check Remove extra context Change description of context Check param for type Array Add unit tests to MoveService Use before_action for permission check Use set instead of let! Use let's instead of set
* | Resolve Gitaly N+1 for CI/CD environments statusesGrzegorz Bizon2019-07-101-2/+2
| |
* | Add additional test case for Gitaly N+1 for diff filesGrzegorz Bizon2019-07-101-36/+65
| |
* | Add a test for `ci_environments_status` Gitaly N+1Grzegorz Bizon2019-07-101-16/+34
|/
* Add retry:0 for controller specs n+163475-fix-n-1Thong Kuah2019-07-081-1/+1
| | | | As a workaround for https://gitlab.com/gitlab-org/gitlab-ce/issues/64116
* Restore fallback to deployment_platform_clusterThong Kuah2019-07-081-3/+4
| | | | In 12.2 we will remove this fallback.
* Could not address last 5 queriesThong Kuah2019-07-081-1/+4
| | | | Split into followup issue
* Extract deployment_metrics into own objectThong Kuah2019-07-081-48/+26
| | | | | | | We can now share project so that we don't have to load project twice. Also, this extracts non-relevant logic out of Deployment. Update DeploymentsController accordingly
* Add failing test showing N+1Thong Kuah2019-07-081-0/+12
| | | | We have an N+1 problem where N is environments.
* Set default project sort method prior to initial sort on page loadingDavid Palubin2019-07-041-1/+17
|
* Merge branch 'sh-fix-issue-63349' into 'master'Rémy Coutable2019-07-041-0/+47
|\ | | | | | | | | | | | | Make Housekeeping button do a full garbage collection Closes #63349 See merge request gitlab-org/gitlab-ce!30289
| * Make Housekeeping button do a full garbage collectionsh-fix-issue-63349Stan Hu2019-07-031-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the Housekeeping button and API would use the counter of last pushes to determine whether to do a full garbage collection, or whether to do one of the less comprehensive tasks: a full repack, incremental pack, or ref pack. This was confusing behavior, since a project owner might have to click the button dozens of times before a full GC would be initiated. This commit forces a full GC each time this is initiated. Note that the `ExclusiveLease` in `HousekeepingService` prevents users from clicking on the button more than once a day. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63349
* | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceMarin Jankovski2019-07-0310-120/+294
|\ \ | |/
| * Add username to deploy tokensKrasimir Angelov2019-07-021-0/+20
| | | | | | | | | | | | | | | | | | This new attribute is optional and used when set instead of the default format `gitlab+deploy-token-#{id}`. Empty usernames will be saved as null in the database. Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/50228.
| * Revert "Include subgroups in shared_projects"Fabian Schneider2019-07-011-2/+5
| | | | | | | | This reverts commit 4bed2daef935bb4097988e0eff4830fc13a23c37.
| * Merge branch '58583-confidential-mr-branch-backend' into 'master'Rémy Coutable2019-07-012-7/+108
| |\ | | | | | | | | | | | | Support creating an MR/branch on a fork from an issue See merge request gitlab-org/gitlab-ce!29831
| | * Check if user can `update_issue` on projectPatrick Bajao2019-07-011-3/+3
| | | | | | | | | | | | | | | If user can update an issue under the specified confidential issue project, should be able to find the project.
| | * Fix issues when creating system notes58583-confidential-mr-branch-backendPatrick Bajao2019-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `confidential_issue_project_id` is set and the issue is under that project, create the a note about branch creation in that project. If not, do nothing. When creating `new_merge_request` system note, set the project where the MR will be referenced from so it'll be linked to when the MR is created in another project.
| | * Support branch creation from confidential issuePatrick Bajao2019-06-292-6/+107
| | | | | | | | | | | | | | | | | | | | | | | | Accept a `confidential_issue_project_id` param which will be used for the system note target. This also includes some refactoring on the spec to use shared examples.