summaryrefslogtreecommitdiff
path: root/spec/factories
Commit message (Collapse)AuthorAgeFilesLines
* Add traits for the different Event types to the Event factoryrs-event-traitsRobert Speicher2017-02-011-0/+12
|
* Merge branch '27044-fix-explore-sorting-on-trending' into 'master' Fatih Acet2017-01-261-0/+6
|\ | | | | | | | | | | | | Fix /explore sorting (trending) Closes #27044 See merge request !8792
| * Fix /explore sorting (trending)Eric Eastwood2017-01-261-0/+6
| | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27044
* | Merge branch 'rs-empty_project-for-associations' into 'master' Rémy Coutable2017-01-2615-17/+25
|\ \ | | | | | | | | | | | | Factories with a project association use `:empty_project` by default See merge request !8770
| * | Use a project factory with a repository where necessaryrs-empty_project-for-associationsRobert Speicher2017-01-252-3/+10
| | |
| * | Factories with a project association use `:empty_project` by defaultRobert Speicher2017-01-2414-14/+15
| | |
* | | Merge branch 'backport-ee-changes-for-build-minutes' into 'master' Grzegorz Bizon2017-01-252-1/+6
|\ \ \ | |_|/ |/| | | | | | | | Backport changes introduced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1078 See merge request !8657
| * | Merge remote-tracking branch 'origin/master' into ↵Kamil Trzcinski2017-01-241-1/+2
| |\ \ | | |/ | | | | | | backport-ee-changes-for-build-minutes
| * | Backport changes introduced by ↵Kamil Trzcinski2017-01-202-1/+6
| | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1083
* | | Merge branch 'no_project_notes' into 'master' Sean McGivern2017-01-251-0/+6
|\ \ \ | |_|/ |/| | | | | | | | Support notes without a project (personal snippets notes) See merge request !8468
| * | Support notes without projectJarka Kadlecova2017-01-181-0/+6
| | |
* | | Merge branch 'feature/success-warning-icons-in-stages-builds' into 'master' Kamil Trzciński2017-01-231-1/+2
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Use a warning icon for a stage with allowed to fail builds Closes #21948 See merge request !8503
| * | Pass memoizable warnings attribute to stage objectGrzegorz Bizon2017-01-181-1/+2
| | |
* | | Merge branch '23524-notify-automerge-user-of-failed-build' into 'master' Sean McGivern2017-01-191-0/+4
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Notify the user who set auto-merge when merge is not possible Closes #23524 See merge request !8056
| * | Notify the user who set auto-merge when merge conflict occurstwonegatives2017-01-141-0/+4
| | |
* | | Merge branch 'rs-repository-project-trait' into 'master' Rémy Coutable2017-01-181-0/+4
|\ \ \ | | | | | | | | | | | | | | | | Add a `:repository` trait to the `:empty_project` factory See merge request !8605
| * | | Add a `:repository` trait to the `:empty_project` factoryRobert Speicher2017-01-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now this is a no-op. We're going to add it as a trait argument to all existing usages of the `:project` factory, so that later we can flip `:empty_project` to just be `:project`, forcing developers to opt-in to the slower option when their tests truly require it.
* | | | Backport backend work for time tracking.Ruben Davila2017-01-151-0/+9
|/ / /
* | | Merge branch 'move-dashboard-archived-projects-spinach-to-rspec' into 'master' Rémy Coutable2017-01-131-0/+4
|\ \ \ | |_|/ |/| | | | | | | | Move dashboard archived projects spinach tests to rspec See merge request !8431
| * | Move dashboard archived projects spinach tests to rspecSemyon Pupkov2017-01-041-0/+4
| | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | | Add test example for pipeline with yaml errorsGrzegorz Bizon2017-01-041-0/+4
| | |
* | | fix pipelines/index.html.haml merge conflictRegis2017-01-022-1/+7
|\ \ \ | |/ /
| * | Merge branch 'feature/more-storage-statistics' into 'master' Sean McGivern2016-12-262-1/+7
| |\ \ | | | | | | | | | | | | | | | | Add more storage statistics See merge request !7754
| | * | Add more storage statisticsMarkus Koller2016-12-212-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds counters for build artifacts and LFS objects, and moves the preexisting repository_size and commit_count from the projects table into a new project_statistics table. The counters are displayed in the administration area for projects and groups, and also available through the API for admins (on */all) and normal users (on */owned) The statistics are updated through ProjectCacheWorker, which can now do more granular updates with the new :statistics argument.
* | | | Add missing specs for new methods in pipeline classGrzegorz Bizon2016-12-271-0/+4
| | | |
* | | | merge master and fix application.rb conflictRegis2016-12-231-0/+1
|\ \ \ \ | |/ / /
| * | | Fix viewing "build failed" TODOsNick Thomas2016-12-221-0/+1
| |/ /
* | | Add specs for pipeline entity and improve factoryGrzegorz Bizon2016-12-211-0/+4
|/ / | | | | | | [ci skip]
* | Add terminal UI and controller actionsFatih Acet2016-12-191-3/+7
| |
* | Add terminals to the Kubernetes deployment serviceNick Thomas2016-12-191-1/+1
| |
* | Merge branch 'master' into fix-yaml-variablesLin Jen-Shin2016-12-193-1/+15
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (327 commits) Always use `fixture_file_upload` helper to upload files in tests. Add CHANGELOG Move admin application spinach test to rspec Move admin deploy keys spinach test to rspec Fix rubocop failures Store mattermost_url in settings Improve Mattermost Session specs Ensure the session is destroyed Improve session tests Setup mattermost session Fix query in Projects::ProjectMembersController to fetch members Improve test for sort dropdown on members page Fix sort dropdown alignment Undo changes on members search button stylesheet Use factories to create project/group membership on specs Remove unused id from shared members sort dropdown Fix sort functionality on project/group members to return invited users Refactor MembersHelper#filter_group_project_member_path Remove unnecessary curly braces from sort dropdown partial Sort group/project members alphabetically by default ...
| * Add a `scopes` column to the `personal_access_tokens` tableTimothy Andrew2016-12-161-0/+1
| |
| * Merge branch 'jej-note-search-uses-finder' into 'security' Douwe Maan2016-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix missing Note access checks in by moving Note#search to updated NoteFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR? :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested ### Note lookup without access check - [x] :white_check_mark: app/finders/notes_finder.rb:13 :download_code check - [x] :white_check_mark: app/finders/notes_finder.rb:19 `SnippetsFinder` - [x] :white_check_mark: app/models/note.rb:121 [`Issue#visible_to_user`] - [x] :white_check_mark: lib/gitlab/project_search_results.rb:113 - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`. - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked. ### Previous discussions - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223 ### Acceptance criteria met? - [x] Tests added for new code - [x] TODO comments removed - [x] Squashed and removed skipped tests - [x] Changelog entry - [ ] State Gitlab versions affected and issue severity in description - [ ] Create technical debt issue for NotesFinder. - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two. - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)` - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes` See merge request !2035
| * Introduce deployment services, starting with a KubernetesServiceNick Thomas2016-12-141-0/+13
| |
* | Convert CI YAML variables keys into stringsLin Jen-Shin2016-12-151-1/+1
|/ | | | | | | So that this would be more consistent with the other variables, which all of them are string based. Closes #25554
* Merge branch 'build-statuses' into 'master' Rémy Coutable2016-12-141-3/+10
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detailed build statuses ## What does this MR do? Implements detailed statuses for `Ci::Builds` and `CommitStatus`. It also adds a new icon for manual build. ## Screenshots ![manual_builds_icon](/uploads/22b5c594350856c85398ef705a635f8b/manual_builds_icon.png) ## What are the relevant issue numbers? See #24273, closes #22642 See merge request !7989
| * Add tests for build play extended detailed statusGrzegorz Bizon2016-12-121-3/+10
| |
* | Create nested group factoryDmitriy Zaporozhets2016-12-111-0/+4
|/ | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Added Ci::Stage specsKamil Trzcinski2016-12-061-0/+13
|
* Merge branch 'fix/create-pipeline-with-builds-in-transaction' into 'master' Kamil Trzciński2016-11-301-12/+16
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create pipeline along with builds in the transation ## What does this MR do? This MR makes it possible to create pipeline along with all associated builds in the transaction, to avoid having empty pipelines when asynchronous job gets terminated. This will simplify implementation of `PipelineUnlockWorker` in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6988 and improve reliability of the CI as a whole. ## What are the relevant issue numbers? Related to #24361 See merge request !7742
| * Extend pipelines factory with transient config attributefix/create-pipeline-with-builds-in-transactionGrzegorz Bizon2016-11-271-13/+8
| |
| * Improve readability in pipeline test objects factoryGrzegorz Bizon2016-11-251-6/+10
| |
| * Remove pipeline factory that is not used in testsGrzegorz Bizon2016-11-251-6/+0
| |
| * Restore method that ensures builds being createdGrzegorz Bizon2016-11-251-0/+11
| |
* | Merge remote-tracking branch 'upstream/master' into fix-cancelling-pipelinesLin Jen-Shin2016-11-221-0/+6
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (133 commits) Restructure steps for MM slash commands service Add Changelog entry for CI linter validation fix Fix entry lookup in CI config inheritance rules Extend specs for global ci configuration entry Remove unnecessary require_relative calls from service classes Use single quote for strings Ue svg from SVGs object Dont trigger CI builds [ci skip] Revert "Test only migrations" Add custom copy for each empty stage Refactor Mattermost slash commands docs Fetch only one revision Highlight nav item on hover Test only migrations Fix migration paths tests Scroll CA stage panel on mobile Fix CSS declaration administer to administrator Move SVGs to JS objects for easy reuse Improve deploy command message ...
| * Introduce deploy command that allows to start deployment from one ↵chatops-deploy-commandKamil Trzcinski2016-11-211-0/+6
| | | | | | | | environment to second one
* | Add a lot of tests for scopes, feedback:Lin Jen-Shin2016-11-192-0/+8
|/ | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7508#note_18622499
* Merge branch 'feature/subscribe-to-group-level-labels' into 'master' Sean McGivern2016-11-171-0/+7
|\ | | | | | | | | | | | | Support subscribing to group labels https://gitlab.com/gitlab-org/gitlab-ce/issues/23586 See merge request !7215
| * Add unique index to subscriptions on subscribable and user and projectDouglas Barbosa Alexandre2016-11-171-0/+7
| |
* | Merge branch 'chat-name-authorize' into 'master' Rémy Coutable2016-11-171-0/+16
|\ \ | |/ |/| | | | | | | | | Allows to authorize chat user against GitLab. This is needed for: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7438 See merge request !7450