| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change `logout_direct` uses to `gitlab_sign_out_direct`
|
|
|
|
| |
Change single `login_via` use to `gitlab_sign_in_via`
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070
Deprecate "chat commands" in favor of "slash commands"
We looked for things like:
- `slash commmand`
- `slash_command`
- `slash-command`
- `SlashCommand`
|
| |
|
| |
|
|
|
|
|
| |
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
|
|
|
|
|
|
| |
params
Closes #28890
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Adds /target_branch slash command functionality for merge requests
Closes #23619
See merge request !7216
|
| |
| |
| |
| |
| |
| |
| | |
Allows to use slash command /target_branch <target_branch_name> in merge requests notes and description.
Command allows to specify target branch for current merge request.
Proposed in #23619
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add changelog entry
replace local variables `merge_request` with instance ones
modify `MergeRequests::BuildService` to fix failed tests
extract `assign_target_project` method
remove unnecessary instance variables
remove exclamation marks and rewrite conditionals to improve readability
extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`
replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones
refactor `execute` method
return `set_title_and_description` method
rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`
fixes after discussion
renamed method branches_valid?
fix space
return assigning methods into `execute` method
simplify `find_target_branch` and `find_source_project` methods
fix spec `merge request issuable record that supports slash commands in its description and notes`
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
It toggles the 'WIP' prefix in the MR title.
|
| |
|
| |
|
|
|
|
|
|
| |
Check for update_issuable permission in Notes::SlashCommandsService
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Some important things to note:
- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
the right place for advanced logic that has nothing to do with what
models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
only
- the `/merge` command is not handled yet
Other improvements:
- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService
Signed-off-by: Rémy Coutable <remy@rymai.me>
|