summaryrefslogtreecommitdiff
path: root/spec/features
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'rs-trailingwhitespace-cop' into 'master'Rémy Coutable2017-08-164-4/+4
|\ | | | | | | | | Enable Layout/TrailingWhitespace cop and auto-correct offenses See merge request !13573
| * Enable Layout/TrailingWhitespace cop and auto-correct offensesRobert Speicher2017-08-154-4/+4
| |
* | Fix 'Projected tags' typo in protected_tags_spec.rbjej-fix-protected-tags-typoJames Edwards-Jones2017-08-151-1/+1
|/
* Fix edit merge request button inconsistent letter casingClement Ho2017-08-153-11/+11
|
* Merge branch ↵Clement Ho2017-08-144-11/+2
|\ | | | | | | | | | | | | | | | | '34527-make-edit-comment-button-always-available-outside-of-dropdown' into 'master' Resolve "Make edit comment button always available outside of dropdown" Closes #34527 See merge request !12931
| * take edit note button out of dropdown34527-make-edit-comment-button-always-available-outside-of-dropdownSimon Knox2017-08-104-11/+2
| |
* | Merge branch '7-days-cycle-analytics' into 'master'Rémy Coutable2017-08-141-0/+38
|\ \ | | | | | | | | | | | | | | | | | | Add a `Last 7 days` option for Cycle Analytics view Closes #36300 See merge request !13443
| * | Add a `Last 7 days` option for Cycle Analytics viewMehdi Lahmam2017-08-111-0/+14
| | |
| * | Add feature specs for Cycle Analytics pipeline summaryMehdi Lahmam2017-08-111-0/+24
| | |
* | | Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2017-08-149-44/+50
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 36089-handle-ref-failure-better * upstream/master: (47 commits) Update CHANGELOG.md for 9.4.5 Update charlock_holmes add a changelog entry switch to multi-line before block restructure the #new_key notification spec don't send devise notifications to the ghost user reset_delivered_emails before testing #new_key skip the :read_project check for new_project_member move the member spec to be with the other ones add a spec for new_group_member add a spec for never emailing the ghost user rubocop fix a membership with no user is always notifiable check notifiability for more emails add Member#notifiable?(type, opts) make NotificationRecipient a little more customizable Add notes about database performance for MySQL fix confidential border issue as well as confidential styles leaking on new MR Migrate force push check to Gitaly Add option to disable project export on instance ...
| * \ \ Merge branch 'user-edit-files-spec-fix' into 'master'Tim Zallmann2017-08-141-0/+17
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wait for requests to finish before running the ace JS Closes #36191 See merge request !13405
| | * | | Wait for requests to finish before running the ace JSuser-edit-files-spec-fixPhil Hughes2017-08-091-0/+17
| | | | | | | | | | | | | | | | | | | | Closes #36191
| * | | | Merge branch 'bvl-rollback-renamed-system-namespace' into 'master'Douwe Maan2017-08-142-4/+4
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't rename system when migrating from 9.x -> 9.4 Closes #35525 and #36148 See merge request !13228
| | * | | | Make sure uploads for personal snippets are correctly renderedBob Van Landuyt2017-08-112-4/+4
| | | | | |
| * | | | | fix confidential border issue as well as confidential styles leaking on new MRRegis Boudinot2017-08-111-1/+0
| | |_|/ / | |/| | |
| * | | | Merge branch 'disable-project-export' into 'master'Rémy Coutable2017-08-111-0/+2
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add option to disable project export on instance See merge request !13211
| | * | | | Add option to disable project export on instanceRobin Bobbitt2017-08-111-0/+2
| | |/ / /
| * | | | Merge branch '32004-use-timecop-safe-mode' into 'master'Robert Speicher2017-08-112-13/+9
| |\ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | Enable Timecop safe mode Closes #32004 See merge request !13498
| | * | | Enable Timecop safe mode32004-use-timecop-safe-modeRémy Coutable2017-08-112-13/+9
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | Merge branch 'split-events-into-push-events' into 'master'Sean McGivern2017-08-112-26/+18
| |\ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | Use a separate table for storing push events See merge request !12463
| | * | | Migrate events into a new formatYorick Peterse2017-08-102-26/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
* | | | | Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2017-08-1110-19/+18
|\ \ \ \ \ | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 36089-handle-ref-failure-better * upstream/master: Fix merge request diff deserialisation when too_large was absent Bumps omniauth-ldap gem version to 2.0.4 Remove an unnecessary `let` in spec/features/projects/user_edits_files_spec.rb Remove documentation about rules that are now enforced by RuboCop Enable the RSpec/HookArgument cop and auto-correct offenses
| * | | | Merge branch 'rs-rspec-hook-argument-cop' into 'master'Rémy Coutable2017-08-119-14/+14
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Enable the RSpec/HookArgument cop and auto-correct offenses See merge request !13484
| | * | | | Enable the RSpec/HookArgument cop and auto-correct offensesRobert Speicher2017-08-109-14/+14
| | |/ / /
| * | | | Remove an unnecessary `let` in spec/features/projects/user_edits_files_spec.rbMehdi Lahmam2017-08-111-5/+4
| |/ / / | | | | | | | | | | | | It closes #36308
* | | | Just use repository would fix the testLin Jen-Shin2017-08-111-4/+1
| | | |
* | | | Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2017-08-112-3/+3
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 36089-handle-ref-failure-better * upstream/master: (62 commits) Update gitlab.po: Missing 'r' in "Fouché" that comes from "Fourcher" verb. Docs: update user docs index Fix minor typos in views Fix Layout/SpaceBeforeBlockBraces violation in bin/changelog_spec Merge branch 'rs-alphanumeric-ssh-params' into 'security-9-4' Merge branch 'import-symlinks-9-3' into 'security-9-3' Fix wrong method call on prometheus histogram Document new all-in-one Helm chart - docs Fix 404 on link path Fix line numbers not matching up to code in code viewer. Hide overflow-x on collapsed sidebar removed global use of breakpoint checker Increase performance of the breakpoint size checker Filter sensitive query string parameters from NGINX access logs Added a template for database changes Render new issue link in failed job as a regular link instead of a UJS one Include RE2 in the upgrade docs Remove affix plugin from issuable sidebar with new navigation Fix linter error alternative route for download archive ...
| * | | Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-092-3/+3
| |/ / | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | Fix more testsLin Jen-Shin2017-08-113-9/+13
| | |
* | | Don't try to create diffs if one of the branch is missingLin Jen-Shin2017-08-102-14/+12
| | | | | | | | | | | | Also fix a few tests
* | | Fake out Repository#fetch_ref for merge request ifLin Jen-Shin2017-08-091-3/+2
|/ / | | | | | | | | the project didn't have a repository setup. We don't try to stub it if the repository was already there.
* | Fix Profile > Preferences feature specs36168-fix-transient-preferences-specsRémy Coutable2017-08-081-12/+16
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Fixed activity not loading on project homepageproject-homepage-activityPhil Hughes2017-08-081-0/+15
| |
* | Show all labelsRegis Boudinot2017-08-082-5/+5
| |
* | Merge branch '31207-clean-locked-merge-requests' into 'master'Stan Hu2017-08-081-0/+13
|\ \ | | | | | | | | | | | | | | | | | | Resolve "Store MergeWorker JID on merge request, and clean up stuck merges" Closes #31207 See merge request !13207
| * | Store MergeWorker JID on merge request, and clean up stuck mergesOswaldo Ferreira2017-08-071-0/+13
| | |
* | | 33874 confidential issue redesignRegis Boudinot2017-08-071-0/+26
| | |
* | | Resolve "User dropdown in filtered search does not load avatar on `master`"Tim Zallmann2017-08-071-1/+1
| | |
* | | Merge branch '32844-issuables-performance' into 'master'Sean McGivern2017-08-071-5/+9
|\ \ \ | | | | | | | | | | | | | | | | Issuables: Move some code from create services to Sidekiq workers See merge request !13326
| * | | Move some after_create parts to worker to improve performance32844-issuables-performanceJarka Kadlecova2017-08-071-5/+9
| | | |
* | | | Group-level new issue & MR using previously selected projectBryce Johnson2017-08-072-5/+14
| | | |
* | | | Merge branch '15664-remove-jquery-nicescroll' into 'master'Phil Hughes2017-08-071-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Remove jQuery Nicescroll" Closes #15664, #30860, and #35885 See merge request !13262
| * | | | fix failing specs due phantomJS scroll positionMike Greiling2017-08-041-4/+4
| | | | |
* | | | | Merge branch 'zj-project-templates' into 'master'Sean McGivern2017-08-072-12/+23
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | Allow projects to be started from a template Closes #32420 See merge request !13108
| * | | | Fix html structureFilipa Lacerda2017-08-071-11/+0
| | | | | | | | | | | | | | | | | | | | Removes test for removed behavior
| * | | | Port form back to use form_tagZ.J. van de Weg2017-08-071-2/+2
| | | | |
| * | | | Fix last feature test for project templatesZ.J. van de Weg2017-08-071-2/+2
| | | | |
| * | | | After merge cleanupZ.J. van de Weg2017-08-071-5/+1
| | | | |
| * | | | Fixes race condition in project uploadsTiago Botelho2017-08-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally picked as: 3fc0dbcbebcd470fe14f8b5fb7ad55dc3912402e. But given the internals changed, this was changed now. The changelog was removed too.
| * | | | Merge branch 'master' into zj-project-templatesFilipa Lacerda2017-08-07334-669/+1047
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (623 commits) Fix issues with pdf-js dependencies fix missing changelog entries for security release on 2017-01-23 Update top bar issues icon Fix pipeline icon in contextual nav for projects Since mysql is not a priority anymore, test it less Fix order of CI lint ace editor loading Add container registry and spam logs icons Fix different Markdown styles Backport to CE for: Make new dropdown dividers full width Fix spec Fix spec Fix spec Bump GITLAB_SHELL_VERSION and GITALY_VERSION to support unhiding refs Add changelog Install yarn via apt in update guides Use long curl options fix Add a spec for concurrent process Remove monkey-patched Array.prototype.first() and last() methods ...