summaryrefslogtreecommitdiff
path: root/spec/features
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'sh-project-feature-nplus-one' into 'master'Jan Provaznik2019-08-271-0/+22
|\ | | | | | | | | | | | | Remove N+1 SQL query loading project feature in dashboard Closes #66482 See merge request gitlab-org/gitlab-ce!32169
| * Remove N+1 SQL query loading project feature in dashboardsh-project-feature-nplus-oneStan Hu2019-08-231-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Projects that have a pipeline may need to check whether the user has permission to read the build (`can?(current_user, :read_build, project)`), which requires checking the `project_features` table. This would cause an N+1 SQL query for each project. This change also has a beneficial side effect that may avoid a race condition. When a user deletes a project, the project is queued for deletion and the user is redirected back to the dashboard page. However, the following may happen: 1. The dashboard page may load this deleted project in the list of 20 projects. 2. The view will load the project pipeline status from the cache and attempt to show each project. 3. When the view encounters the deleted project, it calls `can?(current_user, :read_build, project)` to determine whether to display the pipeline status. 4. Sidekiq deletes the project from the database. 5. However, since the deleted project is still loaded in memory, it will attempt to call `project.project_feature.access_level`. 6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is made to the database. 7. This `SELECT` call returns nothing, and the user sees a 500 error. By eager loading `project_feature`, we can ensure that we have a consistent view and avoid records from being deleted later. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
* | Update docs and comments about saml with allow_bypass_two_factordodocat2019-08-271-0/+12
| | | | | | | | allow_bypass_two_factor configration dose not work with saml provider
* | Change misleading pipeline status tooltipScott Hampton2019-08-232-3/+3
|/ | | | | | | | | | Some pipeline status icon tooltips were showing "Commit: ..." which customers found to be misleading since it was not the commit that was failing but the pipeline. We are changing all status icon tooltips to say "Pipeline: ..." instead of "Commit: ..." now.
* Hide duplicate board list while draggingWinnie Hellmann2019-08-231-2/+12
|
* Always pre-select "Start a new merge request"Denys Mishunov2019-08-222-4/+16
| | | | | | | | | | One exception: there is an existing MR for the current branch and the branch is non-default and non-protected. Extended mock_data for ide/stores to have different types of branches: default, protected and regular Cleaned new MR checkbox view
* Update GitHub CI/CD import page to use PAT onlyScott Hampton2019-08-221-1/+1
| | | | | | | | | | | Oauth2 tokens are causing issues with mirroring repos, because it effectively limits the number of repos you can mirror. Personal Access Tokens do not have this problem. This change removes the OAuth2 option from the import page for CI/CD only, and only provides the personal access token form.
* New wiki page redirects user to random slug46299-wiki-page-creationLuke Duncalfe2019-08-214-113/+69
| | | | | | | | | | Previously we asked a user to enter a new slug before taking them to the Create Page page. As a UX improvement, we now take them to a randomly generated URI so they can begin creating their new page. https://gitlab.com/gitlab-org/gitlab-ce/issues/46299
* Merge branch 'fe-fix-merge-url-params-with-plus' into 'master'Kushal Pandya2019-08-201-5/+25
|\ | | | | | | | | | | | | Fix `mergeUrlParams` handling of '+' Closes #66152 See merge request gitlab-org/gitlab-ce!31973
| * Add feature spec for search with spacefe-fix-merge-url-params-with-plusminghuan lei2019-08-191-5/+25
| |
* | Merge branch 'add-js-prevent-default-on-click' into 'master'Clement Ho2019-08-191-9/+9
|\ \ | |/ |/| | | | | Replace inline scripts in links to prevent default See merge request gitlab-org/gitlab-ce!31838
| * Replace inline scripts in links to prevent defaultadd-js-prevent-default-on-clickHeinrich Lee Yu2019-08-191-9/+9
| | | | | | | | Use buttons instead of links with javascript:void(0)
* | Add warning when LE certificate can't be obtained64630-add-warning-to-pages-domains-that-obtaining-deploying-ssl-certificates-through-let-s-encrypt-can-take-some-timeVladimir Shushlin2019-08-191-4/+4
|/ | | | * Refactor some tests as well
* UI for disabling group/project email notificationBrett Walker2019-08-175-0/+61
| | | | | | - Adds UI to configure in group and project settings - Removes notification configuration for users when disabled at group or project level
* Merge branch ↵Grzegorz Bizon2019-08-163-25/+131
|\ | | | | | | | | | | | | | | | | '47003-user-onboarding-replace-current-email-confirmation-flow-with-a-soft-email-confirmation-flow' into 'master' Soft email confirmation flow Closes #47003 See merge request gitlab-org/gitlab-ce!31245
| * Fix invite specAlex Buijs2019-08-081-14/+58
| | | | | | | | | | | | | | | | | | The invitation flow changed a bit, because now there is no more need to sign in after confirming. When signing up with a different email address, the user will see the invitation page straight after signing up when redirected, without needing to sign in.
| * Add some feature specsAlex Buijs2019-08-081-0/+35
| |
| * Don't redirect to the Almost there pageAlex Buijs2019-08-081-11/+38
| | | | | | | | | | Don't redirect to the Almost there page after registration and after resending confirmation instructions
* | Merge branch 'dm-fix-quarantined-spec' into 'master'Nick Thomas2019-08-161-5/+2
|\ \ | | | | | | | | | | | | | | | | | | Fix quarantined spec by waiting for requests Closes #65329 See merge request gitlab-org/gitlab-ce!31862
| * | Fix quarantined spec by waiting for requestsdm-fix-quarantined-specDouwe Maan2019-08-151-5/+2
| | |
* | | Add feature specs for multiple group issue boardsFelipe Artur2019-08-161-0/+15
| | | | | | | | | | | | Add feature specs for multiple issue boards for groups
* | | Merge branch '24705-multi-selection-for-delete-on-registry-page' into 'master'Thong Kuah2019-08-151-6/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Multi selection for delete on registry page" Closes #24705 See merge request gitlab-org/gitlab-ce!30837
| * | | Implement multi select deletion for container registryNick Kipling2019-07-301-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added checkboxes to each image row Added delete selected images button Changed row delete button to appear on row hover Changed confirmation modal message Changed delete logic to support multi Added tests for multi select Updated pot file Updated rspec test for new functionality
* | | | Support query parameters in metrics embedsSarah Yasonik2019-08-151-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/62971 Adds support for embedding specific charts from the metrics dashboard. Expected parameters are dashboard, title, group, and y_label.
* | | | Merge branch ↵Stan Hu2019-08-142-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '46548-open-source-alternative-to-recaptcha-for-gitlab-com-registration' into 'master' Open source alternative to reCAPTCHA for GitLab.com registration See merge request gitlab-org/gitlab-ce!31625
| * | | | Add invisible captchaAlex Buijs2019-08-102-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With a time treshold of 4 seconds and a firstname and lastname honeypot input fields when signing up
* | | | | Add link to resend confirmation emailAlex Buijs2019-08-141-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | | This link is shown when a user tries to login with an unconfirmed email address and the grace period has expired
* | | | | Changed selection classes to harmonize with other settingsMarc Schwede2019-08-141-2/+2
| |_|/ / |/| | |
* | | | Return 429 on rate limiter on raw endpointMayra Cabrera2019-08-131-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was originally returning 302 when the rate limit kicks in, because using the the correct status code makes it easier to track rate limiting events Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65974
* | | | Load search result counts asynchronouslyMarkus Koller2019-08-122-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | Querying all counts for the different search results in the same request led to timeouts, so we now only calculate the count for the *current* search results, and request the others in separate asynchronous calls.
* | | | Merge branch 'sh-break-out-invited-group-members' into 'master'Ash McKenzie2019-08-124-22/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it easier to find invited group members Closes #61948 See merge request gitlab-org/gitlab-ce!28436
| * | | | Fix typo in causing failing to test in sorting_spec.rbStan Hu2019-08-091-1/+1
| | | | |
| * | | | Merge branch 'master' into sh-break-out-invited-group-membersStan Hu2019-08-0911-35/+130
| |\ \ \ \
| * \ \ \ \ Merge branch 'master' into sh-break-out-invited-group-membersStan Hu2019-08-075-10/+15
| |\ \ \ \ \
| * | | | | | Fix broken specsMartin Wortschack2019-08-064-22/+22
| | | | | | | | | | | | | | | | | | | | | - Add qa- selector to sort dropdown
| * | | | | | Fix spec for inviting membersStan Hu2019-08-051-0/+2
| | | | | | |
| * | | | | | Make it easier to find invited group membersStan Hu2019-08-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We had a number of team members struggle to find invited members of a group. Searching for the e-mail address did not work because search only works with members with user accounts. This commit changes two things: 1. Breaks out the invited members into a separate table. 2. Adds search capability for the invited members. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61948
* | | | | | | Replace ... with new expansion optionsSamantha Ming2019-08-102-6/+24
| |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - expand upwards - expand downwards - expand all in both inline and parallel views
* | | | | | Add repo-refs control for search pageminghuan lei2019-08-091-8/+61
| |_|/ / / |/| | | | | | | | | | | | | | - only in blobs result
* | | | | Rename githost.log -> git_json.logStan Hu2019-08-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The githost.log name was often confused with GitHost.io. Rename this to git_json.log to make it clear it's coming from Git and that it's JSON data.
* | | | | Bring scoped environment variables to coreHordur Freyr Yngvason2019-08-081-0/+23
| |_|_|/ |/| | | | | | | | | | | As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593
* | | | Merge branch '63181-collapsible-line' into 'master'Kushal Pandya2019-08-081-0/+14
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes section title clickable and collapsible Closes #63181 See merge request gitlab-org/gitlab-ce!31571
| * | | | Makes title section collapsible63181-collapsible-lineFilipa Lacerda2019-08-071-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | In the job log, if the user clicks the section title the job log section will be collapsed
* | | | | Add /starrers view for projectsCamil Staps2019-08-074-24/+24
| | | | |
* | | | | Do not persist notes filter when auto-switchingHeinrich Lee Yu2019-08-071-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Send a `persist_filter: false` param to backend when opening links to notes and auto-switching to show all notes
* | | | | Limiting search-field styling to search only47814-search-view-labelsDenys Mishunov2019-08-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Re-organising search.scss - Rely more on utility-classes instead of component classes - Update relevant specs
* | | | | Replaced breadcrumbs with title on Search pageDenys Mishunov2019-08-071-1/+1
| |_|/ / |/| | |
* | | | Use separate Kubernetes namespaces per environmentTiger Watson2019-08-071-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Kubernetes deployments on new clusters will now have a separate namespace per project environment, instead of sharing a single namespace for the project. Behaviour of existing clusters is unchanged. All new functionality is controlled by the :kubernetes_namespace_per_environment feature flag, which is safe to enable/disable at any time.
* | | | Convert RestClient to Gitlab::HTTP for Prometheus MonitorDavid Wilkins2019-08-072-2/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Closes #60024 - Change PrometheusClient.new to accept a base url instead of an already created RestClient - Use Gitlab::HTTP in PrometheusClient instead of creating RestClient in PrometheusService - Move http_options from PrometheusService to PrometheusClient (follow_redirects: false) - ensure that base urls don't have the trailing slash - Created a `PrometheusClient#url` method that might not be strictly required - Change rescued exceptions from RestClient::* to HTTParty::ResponseError where possible and StandardError for the rest
* | | Merge branch '60664-kubernetes-applications-uninstall-cert-manager' into ↵Thong Kuah2019-08-051-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 'master' Resolve "Kubernetes > Applications > Uninstall Cert Manager" See merge request gitlab-org/gitlab-ce!31166
View Lorry Controller Status