summaryrefslogtreecommitdiff
path: root/spec/features
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@12-3-stableGitLab Bot2019-09-206-31/+31
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-201-25/+19
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-192-4/+3
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-191-0/+6
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-191-2/+1
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-1815-28/+30
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-162-1/+6
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-141-0/+1
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-131-1/+1
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-131-1/+24
|
* Merge branch 'static-objects-external-storage' into 'master'Thong Kuah2019-09-114-1/+19
|\ | | | | | | | | Enable serving static objects from an external storage See merge request gitlab-org/gitlab-ce!31025
| * Enable serving static objects from an external storagestatic-objects-external-storageAhmad Sherif2019-09-104-1/+19
| | | | | | | | | | | | | | | | | | | | It consists of two parts: 1. Redirecting users to the configured external storage 1. Allowing the external storage to request the static object(s) on behalf of the user by means of specific tokens Part of https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6829
* | Make MR pipeline widget text more descriptive (CE)ce-indicator-for-pipeline-for-merge-trainNathan Friend2019-09-111-30/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | This change updates the text of the pipeline widget that appears on the merge request page. The text has been made more consistent between different types of pipelines; this makes the front-end implementation simpler and more maintainable. In addition, the type of pipeline is (i.e. regular pipeline, merge request pipeline, detached pipeline) included in the text, making this type more obvious to the end user. Some information has been removed from the widget as part of this change; however, any information that was removed already appears elsewhere on the merge request page.
* | Enables Run Pipeline button to be renderedFilipa Lacerda2019-09-111-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the Merge Request view, under pipelines tab the user can see a run pipeline button Adds axios post request to button click Adds the logic to handle the user click, refresh the table and disable the button while thee request is being made Updates UI for desktop and mobile Adds specs Regenerates potfile Follow-up after review Uses .finally to avoid code repetition
* | Merge remote-tracking branch 'origin/master' into ↵Douglas Barbosa Alexandre2019-09-099-229/+314
|\ \ | | | | | | | | | camilstaps/gitlab-ce-new-66023-public-private-fork-counts
| * | Create new feature flagged UI for cloud providersEnrique Alcántara2019-09-092-0/+27
| | | | | | | | | | | | | | | | | | | | | - Create HAML UI select a cloud provider to create a cluster. - Add query param to :new cluster view to display a specific cluster provider form depending on the value of the provider query param. - Update unit tests and e2e tests to reflect these changes
| * | Application Statistics APIManoj MJ2019-09-091-1/+1
| | | | | | | | | | | | | | | This change implements Application Statistics API
| * | Fix sharing localStorage with all MRsIgor2019-09-061-3/+8
| | | | | | | | | | | | | | | | | | Expose id field in the serializer in order to store comments content in the localStorage under the correct key
| * | Quote branch names in how to merge instructionsLee Tickett2019-09-061-1/+1
| | |
| * | Extract shared example from feature specsinstance-group-level-knativeAlishan Ladhani2019-09-054-670/+241
| | | | | | | | | | | | For installing applications on a project/group/instance cluster
| * | Enable Knative installation on group and instance level clustersAlishan Ladhani2019-09-052-0/+482
| |/ | | | | | | | | | | | | | | | | | | - Show Knative install button on group/instance cluster pages - Allow Knative to be installed on group/instance clusters - Add feature specs for installing applications on group/instance clusters - Add changelog entry - Update docs to reflect that Knative can now be installed on group-level and instance-level clusters
* | Remove "n private forks you have no access to"Camil Staps2019-09-061-1/+0
|/
* Use stub_rails_env for Rails.env stubbing66966-convert-rails-env-stub-usages-to-use-railshelpers-stub_rails_env-insteadAsh McKenzie2019-09-052-2/+2
| | | | | RailsHelpers.stub_rails_env takes care of stubbing Rails.env
* Let project reporters create issue from group boardsFelipe Artur2019-09-041-0/+40
| | | | | The current state of group issue boards does not show the "Add issues" button on the UI for users that are reporters of group child projects.
* Merge branch '66741-remove-spec-rails_helper-rb' into 'master'Grzegorz Bizon2019-09-03135-135/+135
|\ | | | | | | | | | | | | Remove spec/rails_helper.rb Closes #66741 See merge request gitlab-org/gitlab-ce!32380
| * Replace rails_helper.rb with spec_helper.rb66741-remove-spec-rails_helper-rbAsh McKenzie2019-08-30135-135/+135
| | | | | | | | | | rails_helper.rb's only logic was to require spec_helper.rb.
* | quick action label must be first in issue commentManeschi Romain2019-09-021-0/+17
| |
* | Merge branch '50013-add-browser-platform-flags-sign-in-pages' into 'master'Filipa Lacerda2019-09-021-0/+8
|\ \ | | | | | | | | | | | | Add CSS & JS global flags to represent browser and platform on login pages See merge request gitlab-org/gitlab-ce!32521
| * | Add browser and platform flagsKushal Pandya2019-09-021-0/+8
| | | | | | | | | | | | | | | | | | - Adds CSS classes to represent browser & platform - Adds JS flags to `gl` object to represent browser & platform
* | | Merge branch '65304-add-pages-first-deployment-message' into 'master'Filipa Lacerda2019-09-021-0/+6
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Resolve "Improve pages load wait time experience" Closes #65304 See merge request gitlab-org/gitlab-ce!32122
| * | Add warning about Pages initial deployment delay65304-add-pages-first-deployment-messageNathan Friend2019-08-301-0/+6
| | | | | | | | | | | | | | | | | | This commit adds a warning message that is always displayed that informs users that their GitLab Pages sites will take a bit of time before they can be accessed after being deployed for the first time.
* | | Merge branch '46686-move-k8s-services-out-of-gcp-namespace' into 'master'66783-usage-ping-for-slack-integrationsThong Kuah2019-09-012-2/+2
|\ \ \ | | | | | | | | | | | | | | | | Move generic k8s services out of GCP namespace See merge request gitlab-org/gitlab-ce!32310
| * | | Move generic k8s services out of GCP namespace46686-move-k8s-services-out-of-gcp-namespaceTiger2019-08-282-2/+2
| | | | | | | | | | | | | | | | | | | | These services aren't specific to GCP, and will be used for AWS as part of https://gitlab.com/gitlab-org/gitlab-ce/issues/46686
* | | | Creates Feature Flag for job logFilipa Lacerda2019-08-305-0/+15
| | | | | | | | | | | | | | | | | | | | Updates frontend code and specs to allow for the new feature flag
* | | | Merge branch 'fix-nil-deployable-exception-on-job-controller-show' into 'master'Grzegorz Bizon2019-08-301-0/+8
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | Fix users cannot access job detail page when deployable does not exist Closes #65216 See merge request gitlab-org/gitlab-ce!32247
| * | | Fix deployable nil exception on job controllerfix-nil-deployable-exception-on-job-controller-showShinya Maeda2019-08-301-0/+8
| | | | | | | | | | | | | | | | When deployable is nil, we gracefully take care of the case.
* | | | Improve search result labelsMarkus Koller2019-08-3013-174/+116
|/ / / | | | | | | | | | | | | | | | | | | - Use "results" instead of "blobs", "wiki blobs", "snippet blobs" - Use "comments" instead of "notes" - Use correct pluralization - Don't add "1 - 10 of" if there's only one page
* | | Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhqRobert Speicher2019-08-293-2/+23
|\ \ \ | |_|/ |/| |
| * | Merge branch 'security-59549-add-capcha-for-failed-logins' into 'master'GitLab Release Tools Bot2019-08-291-0/+2
| |\ \ | | | | | | | | | | | | | | | | Require a captcha after unique failed logins from the same IP See merge request gitlab/gitlabhq!3270
| | * | Add captcha if there are multiple failed login attemptsMałgorzata Ksionek2019-07-311-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add method to store session ids by ip Add new specs for storing session ids Add cleaning up records after login Add retrieving anonymous sessions Add login recaptcha setting Add new setting to sessions controller Add conditions for showing captcha Add sessions controller specs Add admin settings specs for login protection Add new settings to api Add stub to devise spec Add new translation key Add cr remarks Rename class call Add cr remarks Change if-clause for consistency Add cr remarks Add code review remarks Refactor AnonymousSession class Add changelog entry Move AnonymousSession class to lib Move store unauthenticated sessions to sessions controller Move link to recaptcha info Regenerate text file Improve copy on the spam page Change action filter for storing anonymous sessions Fix rubocop offences Add code review remarks
| * | | Merge branch 'security-katex-dos-master' into 'master'GitLab Release Tools Bot2019-08-291-2/+4
| |\ \ \ | | | | | | | | | | | | | | | | | | | | Enforce max chars and max render time in markdown math See merge request gitlab/gitlabhq!3277
| | * | | Enforce max chars and max render time in markdown mathMartin Hanzel2019-08-061-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | KaTeX math will now render progressivly and asynchronously. There are upper limits on the character count of each formula, and on cumulative render time.
| * | | | Merge branch 'security-sarcila-fix-weak-session-management' into 'master'GitLab Release Tools Bot2019-08-291-0/+17
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Clear reset_password_tokens when login (email or username) change See merge request gitlab/gitlabhq!3334
| | * | | | Add User#will_save_change_to_login? to clear reset_password_tokensSebastian Arcila Valenzuela2019-08-211-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Devise checks before updating any of the authentication_keys if it needs to clear the reset_password_tokens. This should fix: https://gitlab.com/gitlab-org/gitlab-ce/issues/42733 (Weak authentication and session management)
* | | | | | Remove csslabArun Kumar Mohan2019-08-281-1/+0
| | | | | |
* | | | | | Remove token field from runners edit formPayton Burdette2019-08-281-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add changelog entry Remove unnecessary test checking for form value Translations updated for gitlab.pot Use proper format on changelog entry
* | | | | | Merge branch 'todos/include-issue-mr-titles' into 'master'Stan Hu2019-08-283-33/+33
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add Issue and Merge Request titles to Todo items Closes #63488 See merge request gitlab-org/gitlab-ce!30435
| * | | | | Add Issue and Merge Request titles to Todo itemsArun Kumar Mohan2019-08-273-33/+33
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | Only displays the todo body if the todo has a note. This is to avoid redundant Issue or Merge Request titles displayed both in the Todo title and body.
* | | | | Merge branch 'sh-project-feature-nplus-one' into 'master'Jan Provaznik2019-08-271-0/+22
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove N+1 SQL query loading project feature in dashboard Closes #66482 See merge request gitlab-org/gitlab-ce!32169
| * | | | | Remove N+1 SQL query loading project feature in dashboardsh-project-feature-nplus-oneStan Hu2019-08-231-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Projects that have a pipeline may need to check whether the user has permission to read the build (`can?(current_user, :read_build, project)`), which requires checking the `project_features` table. This would cause an N+1 SQL query for each project. This change also has a beneficial side effect that may avoid a race condition. When a user deletes a project, the project is queued for deletion and the user is redirected back to the dashboard page. However, the following may happen: 1. The dashboard page may load this deleted project in the list of 20 projects. 2. The view will load the project pipeline status from the cache and attempt to show each project. 3. When the view encounters the deleted project, it calls `can?(current_user, :read_build, project)` to determine whether to display the pipeline status. 4. Sidekiq deletes the project from the database. 5. However, since the deleted project is still loaded in memory, it will attempt to call `project.project_feature.access_level`. 6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is made to the database. 7. This `SELECT` call returns nothing, and the user sees a 500 error. By eager loading `project_feature`, we can ensure that we have a consistent view and avoid records from being deleted later. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482