summaryrefslogtreecommitdiff
path: root/spec/features
Commit message (Collapse)AuthorAgeFilesLines
* Add deleted image specvueify-image-diffClement Ho2017-09-191-15/+27
|
* Add test for view file linksClement Ho2017-09-181-0/+14
|
* Merge branch 'update-user_uses_slash_commands_spec' into 'master'Rémy Coutable2017-09-181-4/+4
|\ | | | | | | | | Minor update to address Sean McGivern's comment. See merge request gitlab-org/gitlab-ce!14311
| * Minor update to address Sean McGivern's comment.manolis2017-09-151-4/+4
| | | | | | | | More details are available here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13436/diffs#note_39115837
* | Merge branch 'replace_project_snippets.feature' into 'master'Rémy Coutable2017-09-184-0/+90
|\ \ | | | | | | | | | | | | Replace the 'project/snippets.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14326
| * | Replace the 'project/snippets.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-184-0/+90
| |/
* | Merge branch 'replace_project_commits_revert.feature' into 'master'Rémy Coutable2017-09-181-0/+56
|\ \ | | | | | | | | | | | | Replace the 'project/commits/revert.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14325
| * | Replace the 'project/commits/revert.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-181-0/+56
| |/
* | Merge branch 'replace_project_archived.feature' into 'master'Rémy Coutable2017-09-181-0/+43
|\ \ | | | | | | | | | | | | Replace the 'project/archived.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14322
| * | Replace the 'project/archived.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-171-0/+43
| |/
* | Merge branch 'improve_spec_features_profiles_specs' into 'master'Rémy Coutable2017-09-187-38/+33
|\ \ | | | | | | | | | | | | | | | | | | Improve 'spec/features/profiles/*' specs Closes #37855 et #37856 See merge request gitlab-org/gitlab-ce!14317
| * | Improve 'spec/features/profiles/*' specsVitaliy @blackst0ne Klachkov2017-09-167-38/+33
| |/
* | Replace the 'search.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-1611-310/+554
|/
* Merge branch 'revert-sidebar-title-attribute' into 'master'Filipa Lacerda2017-09-151-1/+1
|\ | | | | | | | | Remove title attribute from sidebar elements See merge request gitlab-org/gitlab-ce!14140
| * fixed merge request specrevert-sidebar-title-attributePhil Hughes2017-09-131-1/+1
| |
* | Merge branch '20824-scope-users-to-members-in-group-issuable-list' into 'master'Phil Hughes2017-09-151-0/+22
|\ \ | | | | | | | | | | | | | | | | | | Resolve "Scope users by group inside dropdowns if I'm on group page (Issue, MRs)" Closes #20824 See merge request gitlab-org/gitlab-ce!14249
| * | Return only group's members in user dropdowns on issuables list pages20824-scope-users-to-members-in-group-issuable-listRémy Coutable2017-09-141-0/+22
| |/ | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Use the new query-recorder features as a PoCbvl-extend-query-recorderBob Van Landuyt2017-09-141-2/+2
| |
* | Merge branch ↵Douwe Maan2017-09-141-0/+13
|\ \ | |/ |/| | | | | | | | | | | | | '37576-renamed-files-have-escaped-html-for-the-inline-diff-in-the-header' into 'master' Resolve "Renamed files have escaped HTML for the inline diff in the header" Closes #37576 See merge request gitlab-org/gitlab-ce!14121
| * rework the html_safe not to use haml's auto escapingmicael.bergeron2017-09-111-0/+13
| | | | | | | | add feature test for inline diff in file header
* | Merge branch 'replace_profile_active_tab.feature' into 'master'Rémy Coutable2017-09-135-4/+74
|\ \ | | | | | | | | | | | | Replace the 'profile/active_tab.feature' spinach test with an rspec analog See merge request !14239
| * | Replace the 'profile/active_tab.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-135-4/+74
| | |
* | | Merge branch ↵Grzegorz Bizon2017-09-131-3/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | '36907-new-issue-from-failed-build-no-longer-links-to-failed-build' into 'master' Resolve "New issue from failed build no longer links to failed build" Closes #36907 See merge request !13790
| * | Fixed Tests + Reverted Try out from before36907-new-issue-from-failed-build-no-longer-links-to-failed-buildTim Zallmann2017-09-121-2/+2
| | |
| * | Implemented the new Description ContentTim Zallmann2017-09-121-1/+1
| | |
| * | Changed Var nameTim Zallmann2017-09-121-2/+2
| | |
| * | Adapting Test for JobsTim Zallmann2017-09-121-2/+2
| | |
* | | Merge branch 'replace_project_issues_award_emoji.feature' into 'master'Rémy Coutable2017-09-121-0/+104
|\ \ \ | | | | | | | | | | | | | | | | Replace the 'project/issues/award_emoji.feature' spinach test with an rspec analog See merge request !14202
| * | | Replace the 'project/issues/award_emoji.feature' spinach test with an rspec ↵Vitaliy @blackst0ne Klachkov2017-09-121-0/+104
| |/ / | | | | | | | | | analog
* | | Replace the 'project/builds/summary.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-122-0/+69
|/ /
* | Use WikiPages::CreateService in ↵Rémy Coutable2017-09-121-12/+2
| | | | | | | | | | | | spec/features/projects/wiki/user_updates_wiki_page_spec.rb Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch 'replace_project_merge_requests_revert.feature' into 'master'Rémy Coutable2017-09-121-0/+59
|\ \ | | | | | | | | | | | | Replace the 'project/merge_requests/revert.feature' spinach test with an rspec analog See merge request !14201
| * | Replace the 'project/merge_requests/revert.feature' spinach test with an ↵Vitaliy @blackst0ne Klachkov2017-09-121-0/+59
| | | | | | | | | | | | rspec analog
* | | Merge branch 'replace_milestone.feature' into 'master'Rémy Coutable2017-09-121-0/+40
|\ \ \ | |/ / |/| | | | | | | | Replace the 'project/milestone.feature' spinach test with an rspec analog See merge request !14171
| * | Replace the project/milestone.feature spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-121-0/+40
| | |
* | | Merge branch 'replace_project_merge_requests_accept.feature' into 'master'Rémy Coutable2017-09-111-0/+65
|\ \ \ | | | | | | | | | | | | | | | | Replace the 'project/merge_requests/accept.feature' spinach test with an rspec analog See merge request !14176
| * | | Replace the 'project/merge_requests/accept.feature' spinach test with an ↵blackst0ne2017-09-111-0/+65
| |/ / | | | | | | | | | rspec analog
* | | Merge branch 'replace_spinach_wiki.feature' into 'master'Rémy Coutable2017-09-115-174/+408
|\ \ \ | | | | | | | | | | | | | | | | Replace 'project/wiki.feature' spinach test with an rspec analog See merge request !13856
| * | | Replace 'project/wiki.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-115-174/+408
| |/ /
* | | Merge branch 'replace_group_links.feature' into 'master'Rémy Coutable2017-09-111-0/+41
|\ \ \ | | | | | | | | | | | | | | | | Replace 'project/group_links.feature' spinach test with an rspec analog See merge request !14169
| * | | Replace project/group_links.feature spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-101-0/+41
| |/ /
* | | Merge branch 'replace_emails.feature' into 'master'Rémy Coutable2017-09-111-0/+78
|\ \ \ | | | | | | | | | | | | | | | | Replace the 'profile/emails.feature' spinach test with an rspec analog See merge request !14172
| * | | Replace the profile/emails.feature spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-101-0/+78
| |/ /
* | | Merge branch 'replace_team_management.feature' into 'master'Rémy Coutable2017-09-111-0/+68
|\ \ \ | | | | | | | | | | | | | | | | Replace the 'project/team_management.feature' spinach test with an rspec analog See merge request !14173
| * | | Replace the project/team_management.feature spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-101-0/+68
| |/ /
* | | Merge branch 'user-recent-push' into 'master'Douwe Maan2017-09-111-1/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Rework how recent push events are retrieved Closes #35990 See merge request !13995
| * | | Rework how recent push events are retrieveduser-recent-pushYorick Peterse2017-09-081-1/+3
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever you push to a branch GitLab will show a button to create a merge request (should one not exist already). The underlying code to display this data was quite inefficient. For example, it involved multiple slow queries just to figure out what the most recent push event was. This commit changes the way this data is retrieved so it's much faster. This is achieved by caching the ID of the last push event on every push, which is then retrieved when loading certain pages. Database queries are only executed if necessary and the cached data is removed automatically once a merge request has been created, or 2 hours after being stored. A trade-off of this approach is that we _only_ track the last event. Previously if you were to push to branch A and B then create a merge request for branch B we'd still show the widget for branch A. As of this commit this is no longer the case, instead we will only show the widget for the branch you pushed to most recently. Once a merge request exists the widget is no longer displayed. Alternative solutions are either too complex and/or too slow, hence the decision was made to settle for this trade-off. Performance Impact ------------------ In the best case scenario (= a user didn't push anything for more than 2 hours) we perform a single Redis GET per page. Should there be cached data we will run a single (and lightweight) SQL query to get the event data from the database. If a merge request already exists we will run an additional DEL to remove the cache key. The difference in response timings can vary a bit per project. On GitLab.com the 99th percentile of time spent in User#recent_push hovers between 100 milliseconds and 1 second, while the mean hovers around 50 milliseconds. With the changes in this MR the expected time spent in User#recent_push is expected to be reduced down to just a few milliseconds. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
* | | Check for sidebar cookie instead of class when resizing windowAnnabel Dunstone Gray2017-09-114-4/+4
| |/ |/|
* | Merge branch ↵Rémy Coutable2017-09-081-0/+20
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | '37569-fix-wrong-number-of-arguments-in-tree_helper-flatten_tree' into 'master' Fix a "Wrong number of arguments" error in TreeHelper#flatten_tree Closes #37569 See merge request !14119
| * | Fix a "Wrong number of arguments" error in TreeHelper#flatten_tree37569-fix-wrong-number-of-arguments-in-tree_helper-flatten_treeRémy Coutable2017-09-071-0/+20
| | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
View Lorry Controller Status