summaryrefslogtreecommitdiff
path: root/spec/finders/todos_finder_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@14-1-stable-eev14.1.0-rc42GitLab Bot2021-07-201-0/+2
|
* Add latest changes from gitlab-org/gitlab@13-3-stable-eeGitLab Bot2020-08-201-18/+36
|
* Add latest changes from gitlab-org/gitlab@13-2-stable-eeGitLab Bot2020-07-201-3/+50
|
* Add latest changes from gitlab-org/gitlab@13-1-stable-eeGitLab Bot2020-06-181-1/+1
|
* Add latest changes from gitlab-org/gitlab@13-0-stable-eeGitLab Bot2020-05-201-2/+2
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-12-201-1/+1
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-11-151-0/+22
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-11-111-0/+13
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-281-0/+23
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-211-13/+17
|
* Add latest changes from gitlab-org/gitlab@masterlistGitLab Bot2019-10-171-6/+35
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-161-0/+2
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-151-0/+22
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-141-0/+37
|
* Remove code related to object hierarchy in MySQLremove-nested-groups-checksHeinrich Lee Yu2019-07-251-1/+1
| | | | | These are not required because MySQL is not supported anymore
* Move Contribution Analytics related spec in ↵Imre Farkas2019-04-091-0/+7
| | | | spec/features/groups/group_page_with_external_authorization_service_spec to EE
* Revert "Merge branch 'if-57131-external_auth_to_ce' into 'master'"Andreas Brandl2019-04-051-7/+0
| | | This reverts merge request !26823
* Move Contribution Analytics related spec in ↵Imre Farkas2019-04-051-0/+7
| | | | spec/features/groups/group_page_with_external_authorization_service_spec to EE
* Clean up ActiveRecord code in TodoServiceYorick Peterse2018-10-081-0/+16
| | | | | | | | | | | | | | | | | | | | | | This refactors the TodoService class according to our code reuse guidelines. The resulting code is a wee bit more verbose, but it allows us to decouple the column names from the input, resulting in fewer changes being necessary when we change the schema. One particular noteworthy line in TodoService is the following: todos_ids = todos.update_state(state) Technically this is a violation of the guidelines, because `update_state` is a class method, which services are not supposed to use (safe for a few allowed ones). I decided to keep this, since there is no alternative. `update_state` doesn't produce a relation so it doesn't belong in a Finder, and we can't move it to another Service either. As such I opted to just use the method directly. Cases like this may happen more frequently, at which point we should update our documentation with some sort of recommendation. For now, I want to refrain from doing so until we have a few more examples.
* Clean up ActiveRecord code in TodosFinderYorick Peterse2018-10-081-1/+0
| | | | | | | | This refactors the TodosFinder finder according to the new code reuse rules, as enforced by the CodeReuse cops. I also changed some of the methods to use regular if statements, instead of assignments and/or early returns. This results in a more natural flow when reading the code, and it makes it harder to accidentally return the wrong result.
* Don’t do authorisation checks for todosJarka Kadlecová2018-08-021-26/+0
|
* Revert "Revert "Merge branch 'ee-5481-epic-todos' into 'master'""Jarka Kadlecová2018-08-021-0/+64
| | | | This reverts commit 8717c7dad9b5a8fa21ec9a652c54718a6b4c2175.
* Revert "Merge branch 'ee-5481-epic-todos' into 'master'"Jarka Kadlecová2018-07-111-64/+0
| | | | | This reverts commit 4d9a3f42f1fd3be21555e19872b7121cca65015e, reversing changes made to ecf9c145f6e4d170cd059df88743393d9e63c489.
* [backend] Addressed review commentsJan Provaznik2018-07-031-1/+12
| | | | | | | * Group filtering now includes also issues/MRs from subgroups/subprojects * fixed due_date * Also DRYed todo controller specs
* Support todos for epics backportJarka Kadlecová2018-07-031-0/+53
|
* Remove default scope from todosremove-default-scope-from-todosSean McGivern2018-03-051-12/+15
| | | | This was causing todo priority sorting to fail.
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-221-1/+1
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-021-1/+1
|
* Correct RSpec/SingleLineHook cop offensesRobert Speicher2017-06-141-1/+3
|
* Todos sorting dropdownissue_18135Felipe Artur2016-08-191-0/+70