summaryrefslogtreecommitdiff
path: root/spec/helpers
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch '66067-pages-domain-doesnt-set-target-blank' into 'master'Dmitriy Zaporozhets2019-09-051-0/+17
|\ | | | | | | | | | | | | Makes custom Pages domain open as external link in new tab Closes #66067 See merge request gitlab-org/gitlab-ce!32130
| * Allow for the passing of options to external_link66067-pages-domain-doesnt-set-target-blankjakeburden2019-09-031-0/+5
| |
| * Create and use external_link helperjakeburden2019-09-031-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Creates a helper method that takes body text and a url. The output is a external link with icon. It contains the noopenner noreferrer attributes for security. Usage: external_link(domain.title, domain.url) Add rspec test for ExternalLinkHelper Add changelog for MR 32130
* | Use stub_rails_env for Rails.env stubbing66966-convert-rails-env-stub-usages-to-use-railshelpers-stub_rails_env-insteadAsh McKenzie2019-09-052-6/+5
| | | | | | | | | | RailsHelpers.stub_rails_env takes care of stubbing Rails.env
* | Let project reporters create issue from group boardsFelipe Artur2019-09-041-1/+1
| | | | | | | | | | The current state of group issue boards does not show the "Add issues" button on the UI for users that are reporters of group child projects.
* | Merge branch '66741-remove-spec-rails_helper-rb' into 'master'Grzegorz Bizon2019-09-037-7/+7
|\ \ | |/ |/| | | | | | | | | Remove spec/rails_helper.rb Closes #66741 See merge request gitlab-org/gitlab-ce!32380
| * Replace rails_helper.rb with spec_helper.rb66741-remove-spec-rails_helper-rbAsh McKenzie2019-08-307-7/+7
| | | | | | | | | | rails_helper.rb's only logic was to require spec_helper.rb.
* | Fix upload URLs in Markdown66803-fix-uploads-relative-link-filterHeinrich Lee Yu2019-09-021-6/+0
| | | | | | | | | | Fixes RelativeLinkFilter for users that don't have access to the project's repository
* | Fix for #56295, https://gitlab.com/gitlab-org/gitlab-ce/issues/56295.Jesse Hall2019-08-301-0/+42
| | | | | | | | All avatars now visible in commit trailers.
* | Improve search result labelsMarkus Koller2019-08-301-1/+42
| | | | | | | | | | | | | | - Use "results" instead of "blobs", "wiki blobs", "snippet blobs" - Use "comments" instead of "notes" - Use correct pluralization - Don't add "1 - 10 of" if there's only one page
* | Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhqRobert Speicher2019-08-293-12/+60
|\ \
| * \ Merge branch 'security-fix-html-injection-for-label-description-ce-master' ↵GitLab Release Tools Bot2019-08-291-0/+10
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Fix HTML injection for label description See merge request gitlab/gitlabhq!3250
| | * | Fix HTML injection for label descriptionPatrick Derichs2019-08-051-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | Add changelog entry Add spec
| * | | Merge branch 'security-hide_merge_request_ids_on_emails' into 'master'GitLab Release Tools Bot2019-08-291-12/+44
| |\ \ \ | | | | | | | | | | | | | | | | | | | | Prevent disclosure of merge request id via email See merge request gitlab/gitlabhq!3313
| | * | | Prevent disclosure of merge request id via emailFelipe Artur2019-08-191-12/+44
| | |/ / | | | | | | | | | | | | | | | | Do not disclosure merge request id via email for unauthorized users when closing issues.
| * | | Merge branch 'security-exposed-default-branch' into 'master'GitLab Release Tools Bot2019-08-291-0/+6
| |\ \ \ | | |_|/ | |/| | | | | | | | | | Avoid exposing unaccessible repo data upon GFM post processing See merge request gitlab/gitlabhq!3344
| | * | Avoid exposing unaccessible repo data upon GFM processingOswaldo Ferreira2019-08-211-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When post-processing relative links to absolute links RelativeLinkFilter didn't take into consideration that internal repository data could be exposed for users that do not have repository access to the project. This commit solves that by checking whether the user can `download_code` at this repository, avoiding any processing of this filter if the user can't. Additionally, if we're processing for a group ( no project was given), we check if the user can read it in order to expand the href as an extra. That doesn't seem necessarily a breach now, but an extra check doesn't hurt as after all the user needs to be able to `read_group`.
* | | | fix: show preferred commit email in empty project pageYuping Zuo2019-08-291-0/+36
| | | |
* | | | Merge branch 'local-test-failures' into 'master'Robert Speicher2019-08-291-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | git-user-related local test failures See merge request gitlab-org/gitlab-ce!31437
| * | | git-user-related local test failuresDavid H. Wilkins2019-08-021-1/+1
| | |/ | |/| | | | | | | | | | | | | Some of the tests fail locally due to the git user being different than it is on the test runners. I'd really like to be able to run all of the tests locally.
* | | Change misleading pipeline status tooltipScott Hampton2019-08-231-0/+76
| |/ |/| | | | | | | | | | | | | | | | | Some pipeline status icon tooltips were showing "Commit: ..." which customers found to be misleading since it was not the commit that was failing but the pipeline. We are changing all status icon tooltips to say "Pipeline: ..." instead of "Commit: ..." now.
* | UI for disabling group/project email notificationBrett Walker2019-08-173-0/+76
| | | | | | | | | | | | - Adds UI to configure in group and project settings - Removes notification configuration for users when disabled at group or project level
* | Add link to resend confirmation emailAlex Buijs2019-08-141-0/+17
| | | | | | | | | | This link is shown when a user tries to login with an unconfirmed email address and the grace period has expired
* | Migrates Snowplow backend from EE to CEJeremy Jackson2019-08-141-2/+26
| | | | | | | | | | This introduces several changes, but these are all just ported from the EE project.
* | Revert "Merge branch '64341-data-and-privacy-agreement-for-gitlab-users' ↵Kushal Pandya2019-08-141-20/+0
| | | | | | | | | | | | into 'master'" This reverts merge request !30808
* | Add notification for updated privacy policyDennis Tang2019-08-141-0/+20
| | | | | | | | | | | | | | | | This adds a notification to let users know of our updated privacy policy. Users can dismiss the notification either by following the link or closing the notification via an "x" icon.
* | Load search result counts asynchronouslyMarkus Koller2019-08-121-0/+44
| | | | | | | | | | | | Querying all counts for the different search results in the same request led to timeouts, so we now only calculate the count for the *current* search results, and request the others in separate asynchronous calls.
* | Add tests for starrers viewsCamil Staps2019-08-071-1/+1
| |
* | Add top navigation analytics linkanalytics-top-navLuke Bennett2019-08-061-1/+1
|/
* Change qa-reverse-sort class references to rspec-reverse-sortTanya Pazitny2019-07-291-1/+1
|
* Merge branch 'remove-nested-groups-checks' into 'master'Lin Jen-Shin2019-07-263-8/+8
|\ | | | | | | | | | | | | Remove code related to object hierarchy and MySQL Closes #65056 and #65055 See merge request gitlab-org/gitlab-ce!31095
| * Remove code related to object hierarchy in MySQLremove-nested-groups-checksHeinrich Lee Yu2019-07-253-8/+8
| | | | | | | | | | These are not required because MySQL is not supported anymore
* | Fix error rendering submodules in MR diffs when there is no .gitmodulesdm-submodule-links-nilDouwe Maan2019-07-261-0/+13
|/ | | | Without this change, we get a NoMethodError on nil
* Merge branch '62217-follow-up-from-fix-display-of-promote-to-group-label' ↵Douwe Maan2019-07-241-21/+3
|\ | | | | | | | | | | | | | | | | into 'master' Remove project param from `#show_label_issuables_link?` Closes #62217 See merge request gitlab-org/gitlab-ce!31038
| * Remove project from show_label_issuables_link?62217-follow-up-from-fix-display-of-promote-to-group-labelHeinrich Lee Yu2019-07-231-21/+3
| | | | | | | | The project param is unnecessary here
* | Add links in admin area overviewce-xanf-add-admin-area-linksIllya Klymov2019-07-241-0/+37
|/ | | | | | Introduces new `feature_entry` helper for dashboard. This helper reduces code duplication when listing available features and relevant links to configuration sections
* Ensure SubmoduleHelper works outside view contextdm-submodule-helper-routingDouwe Maan2019-07-221-36/+45
|
* Fetch latest link in the description for zoom link, add more tests and ↵Rajendra kadam2019-07-171-0/+41
| | | | remove frontend spec unnecessary tests
* Hide restricted and disallowed visibility radioshide-restricted-visibility-radioLuke Bennett2019-07-151-26/+46
| | | | | Show a message if many levels are restricted and a different message if all levels are restricted.
* Add more file extentions to file type icon classPeter Dave Hello2019-07-151-0/+20
|
* Open WebIDE in fork when user doesn't have access51952-redirect-to-webide-in-forkMarkus Koller2019-07-121-7/+31
| | | | | | | When opening the IDE on a project where the user doesn't have push access, we create a fork and then redirect back to the IDE. To make sure the user can actually commit, we need to open the IDE in the forked project rather than the upstream project.
* Merge branch 'upgrade-rails-5-2-ce' into 'master'Bob Van Landuyt2019-07-122-2/+2
|\ | | | | | | | | [CE] Upgrade to Rails 5.2 See merge request gitlab-org/gitlab-ce!30052
| * Upgrade to Rails 5.2upgrade-rails-5-2-ceHeinrich Lee Yu2019-07-122-2/+2
| | | | | | | | Updates changed method names and fixes spec failures
* | Merge branch '60798-follow-up-simplify-sort-direction-logic' into 'master'Sean McGivern2019-07-121-1/+147
|\ \ | | | | | | | | | | | | | | | | | | Resolve "Follow up: Simplify sort direction logic" Closes #60798 See merge request gitlab-org/gitlab-ce!30443
| * | Minor review cleanup60798-follow-up-simplify-sort-direction-logicEzekiel Kigbo2019-07-121-61/+47
| | | | | | | | | | | | Minor refactor specs
| * | Added tests for sort icon currentEzekiel Kigbo2019-07-121-63/+37
| | | | | | | | | | | | Refactor sort direction icon
| * | Added test for admin/projectsEzekiel Kigbo2019-07-121-39/+111
| | | | | | | | | | | | | | | | | | | | | | | | Added tests with project_list_filter_bar set to off Added tests for projects_sort_option_titles Refactor project sort options hash
| * | Added tests for current behaviourEzekiel Kigbo2019-07-121-0/+114
| |/
* | Split and prepend CurrentBoardEntityWinnie Hellmann2019-07-121-2/+14
|/ | | | (cherry picked from commit 1e8bdd01bff96122fe80c51fa8f024f18675b58b)
* Merge branch 'fix_simple_format_undefined' into 'master'Robert Speicher2019-07-101-1/+72
|\ | | | | | | | | | | | | Fix `simple_format` undefined error #60179 Closes #60179 See merge request gitlab-org/gitlab-ce!30366