| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
Remove unused methods from `IssuesHelper` and `IssuablesHelper`
See merge request !13793
|
| |
| |
| |
| | |
Its last usage has been removed at eb3e7bdfd8.
|
|\ \ |
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
Remove issuable finder count caching
See merge request !13959
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We're going to cache the total open count separately, and then just perform
these counts on the list. We already do that to get the pagination information,
through Kaminari, and a future change will make Kaminari reuse the query results
from earlier in the request.
|
|\ \ \ \
| |/ / / |
|
| |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'31273-creating-an-project-within-an-internal-sub-group-gives-the-option-to-set-it-a-public' into 'master'
Resolve various visibility level settings issues
Closes #31273
See merge request !13442
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | |/ / |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.
To fix this:
1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
`Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
like that in several places.
3. Change the initializers to use that new form.
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
[master] Prevent project creation (blank, import or fork) when repository already exists on disk
See merge request gitlab/gitlabhq!2169
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
exists on disk
There are some redundancies in the validation steps, and that is to
preserve current error messages behavior
Also few specs have to be changed in order to fix madness in validation
logic.
|
| |/
|/| |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Remove tooltip from filtered search user
Closes #36696
See merge request !13752
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the style of push events that remove tags or branches so
they don't display the commit details. This prevents displaying commit
details such as:
000000 . --broken encoding
Instead we now simply display the header such as:
Administrator deleted branch example-branch
This is displayed in the same style as events for newly created
branches/tags.
This commit also ensures that if no commit message is present we simply
don't display anything, instead of "--broken encoding".
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36685
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36722
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Don't escape html entities in InlineDiffMarkdownMarker
Closes #36041
See merge request !13553
|
| | |
|
|\ \
| |/
|/|
| |
| | |
Fix race condition with dispatcher.js
See merge request !13377
|
| |
| |
| |
| | |
The dispatcher was trying to create a new instance of a class that is loaded in a file after main.js which would cause the filtered search to not work on issues. This would only happen on the first load when the JS is not cached. If the JS is cached, then everything will be fine.
|
| |
| |
| |
| |
| |
| |
| | |
In some cases we pass an Array to this method which would previously
fail since Array does not respond to "limit_value".
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/3646
|
|/
|
|
|
|
|
|
|
|
| |
This changes the pagination of the "Explore" pages so they use a simpler
pagination system that only shows "Prev" and "Next" buttons. This
removes the need for getting the total number of rows to display, a
process that can easily take up to 2 seconds when browsing through a
large list of projects.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/27390
|
|\
| |
| |
| |
| |
| |
| | |
Support group milestone references
Closes #34778
See merge request !13289
|
| |
| |
| |
| |
| | |
Group milestones can only be referred to by name, not IID. They also do not
support cross-project references.
|
|\ \
| | |
| | |
| | |
| | | |
Improve various parts of Dashboard::ProjectsController
See merge request !13319
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In various places we check if the same relation would return projects.
This is done using "any?" which will run a COUNT query with any
LIMIT/OFFSET values still applied.
To work around all this we introduce 2 helper methods that take care of
doing the right thing. This leads to the produced queries being simpler
and fewer queries being executed.
|
|/ |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Ensure all project factories use `:repository` trait or `:empty_project`
See merge request !13238
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
When you change the diff view (inline / side-by-side), we set a cookie based on
that new view. When you add a comment, we choose the style to use in the
response based on that cookie.
However, when you have just changed diff style, the request cookie will contain
the old value, so we should use the view param instead.
|
|
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fix issue detail if user who last edited an issue was deleted
Closes #34930
See merge request !12933
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Added authentiq provider to tests and updated documentation, gem and config file.
See merge request !12952
|
| | |
| | |
| | |
| | | |
file.
|
| |/
|/| |
|
|\ \
| | |
| | |
| | |
| | | |
Fixes needed when GitLab sign-in is not enabled
See merge request !12491
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
When sign-in is disabled:
- skip password expiration checks
- prevent password reset requests
- don’t show Password tab in User Settings
- don’t allow login with username/password for Git over HTTP requests
- render 404 on requests to Profiles::PasswordsController
|