summaryrefslogtreecommitdiff
path: root/spec/helpers
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'remove-unused-code-issueshelper' into 'master'Rémy Coutable2017-09-041-10/+0
|\ | | | | | | | | Remove unused methods from `IssuesHelper` and `IssuablesHelper` See merge request !13793
| * Remove unused `IssuesHelper#merge_requests_sentence`Mehdi Lahmam2017-08-241-10/+0
| | | | | | | | Its last usage has been removed at eb3e7bdfd8.
* | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceJose Ivan Vargas2017-09-031-106/+0
|\ \
| * \ Merge branch 'remove-finder-caching' into 'master'Robert Speicher2017-09-011-106/+0
| |\ \ | | | | | | | | | | | | | | | | Remove issuable finder count caching See merge request !13959
| | * | Remove issuable finder count cachingSean McGivern2017-08-311-106/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to cache the total open count separately, and then just perform these counts on the list. We already do that to get the pagination information, through Kaminari, and a future change will make Kaminari reuse the query results from earlier in the request.
* | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceMarin Jankovski2017-09-012-16/+63
|\ \ \ \ | |/ / /
| * | | Merge branch ↵Tim Zallmann2017-08-311-14/+61
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '31273-creating-an-project-within-an-internal-sub-group-gives-the-option-to-set-it-a-public' into 'master' Resolve various visibility level settings issues Closes #31273 See merge request !13442
| | * | | enhance disabled group visibility options with links and instructionsMike Greiling2017-08-301-2/+2
| | | | |
| | * | | update test to match new disabled option descriptionMike Greiling2017-08-301-1/+1
| | | | |
| | * | | add tests for new visibility_level_helper methodsMike Greiling2017-08-261-0/+26
| | | | |
| | * | | add tests for groups within visibility level helperMike Greiling2017-08-261-1/+22
| | | | |
| | * | | rename skip_level? to disallowed_visibitility_level?Mike Greiling2017-08-261-13/+13
| | |/ /
| * | | `current_application_settings` belongs on `Gitlab::CurrentSettings`Sean McGivern2017-08-311-2/+2
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form.
* | | Merge branch '36743-existing-repo-master' into 'master'Douwe Maan2017-08-311-2/+2
|\ \ \ | |/ / |/| | | | | | | | [master] Prevent project creation (blank, import or fork) when repository already exists on disk See merge request gitlab/gitlabhq!2169
| * | Prevent new / renamed project from using a repository path that already ↵Gabriel Mazetto2017-08-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | exists on disk There are some redundancies in the validation steps, and that is to preserve current error messages behavior Also few specs have to be changed in order to fix madness in validation logic.
* | | Add support for copying permalink to notes via more actions dropdownDimitrie Hoekstra2017-08-251-0/+63
| |/ |/|
* | Merge branch 'remove-tooltip-filtered-search-user' into 'master'Tim Zallmann2017-08-231-6/+36
|\ \ | | | | | | | | | | | | | | | | | | Remove tooltip from filtered search user Closes #36696 See merge request !13752
| * | Remove tooltip from filtered search userremove-tooltip-filtered-search-userClement Ho2017-08-221-6/+36
| |/
* | Fix display of push events for removed refsfix-push-events-branch-removalsYorick Peterse2017-08-221-0/+4
|/ | | | | | | | | | | | | | | | | | | | | This changes the style of push events that remove tags or branches so they don't display the commit details. This prevents displaying commit details such as: 000000 . --broken encoding Instead we now simply display the header such as: Administrator deleted branch example-branch This is displayed in the same style as events for newly created branches/tags. This commit also ensures that if no commit message is present we simply don't display anything, instead of "--broken encoding". Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36685 Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36722
* Resolve "User profile activity feed contains broken image links"Tim Zallmann2017-08-211-0/+6
|
* Merge branch '36041-notification-title' into 'master'Douwe Maan2017-08-181-4/+4
|\ | | | | | | | | | | | | Don't escape html entities in InlineDiffMarkdownMarker Closes #36041 See merge request !13553
| * Don't escape html entities when rich == raw line36041-notification-titleJarka Kadlecova2017-08-171-4/+4
| |
* | Merge branch 'dispatcher-race-condition-fix' into 'master'Tim Zallmann2017-08-161-1/+1
|\ \ | |/ |/| | | | | Fix race condition with dispatcher.js See merge request !13377
| * Fix race condition with dispatcher.jsdispatcher-race-condition-fixPhil Hughes2017-08-151-1/+1
| | | | | | | | The dispatcher was trying to create a new instance of a class that is loaded in a file after main.js which would cause the filtered search to not work on issues. This would only happen on the first load when the JS is not cached. If the JS is cached, then everything will be fine.
* | Allow usage of any_projects? with an Arrayfix-any-projects-arrayYorick Peterse2017-08-151-3/+9
| | | | | | | | | | | | | | In some cases we pass an Array to this method which would previously fail since Array does not respond to "limit_value". Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/3646
* | Use Prev/Next pagination for exploring projectspagination-projects-exploreYorick Peterse2017-08-141-0/+23
|/ | | | | | | | | | This changes the pagination of the "Explore" pages so they use a simpler pagination system that only shows "Prev" and "Next" buttons. This removes the need for getting the total number of rows to display, a process that can easily take up to 2 seconds when browsing through a large list of projects. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/27390
* Merge branch 'group-milestone-references-system-notes' into 'master'Robert Speicher2017-08-072-40/+46
|\ | | | | | | | | | | | | Support group milestone references Closes #34778 See merge request !13289
| * Support references to group milestonesSean McGivern2017-08-072-40/+46
| | | | | | | | | | Group milestones can only be referred to by name, not IID. They also do not support cross-project references.
* | Merge branch 'dashboard-projects-controller-query-performance' into 'master'Sean McGivern2017-08-071-0/+44
|\ \ | | | | | | | | | | | | Improve various parts of Dashboard::ProjectsController See merge request !13319
| * | Improve checking if projects would be returnedYorick Peterse2017-08-071-0/+44
| |/ | | | | | | | | | | | | | | | | | | In various places we check if the same relation would return projects. This is done using "any?" which will run a COUNT query with any LIMIT/OFFSET values still applied. To work around all this we introduce 2 helper methods that take care of doing the right thing. This leads to the produced queries being simpler and fewer queries being executed.
* | Add a Circuitbreaker for storage pathsBob Van Landuyt2017-08-041-0/+20
|/
* Resolve "Specific Async Script Loading by using a Page Variable"Tim Zallmann2017-08-031-0/+13
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-0222-50/+50
|
* Merge branch 'rs-empty_project-cleanup' into 'master'Rémy Coutable2017-08-027-10/+10
|\ | | | | | | | | Ensure all project factories use `:repository` trait or `:empty_project` See merge request !13238
| * Ensure all project factories use `:repository` trait or `:empty_project`rs-empty_project-cleanupRobert Speicher2017-08-017-10/+10
| |
* | Add filtered search to group issue dashboardClement Ho2017-08-021-0/+34
|/
* Rename many path_with_namespace -> full_pathGabriel Mazetto2017-08-014-8/+8
|
* Fix group milestone path on issuable sidebarfix-group-milestone-link-in-issuable-sidebarSean McGivern2017-07-311-10/+43
|
* Fix diff commenting results just after changing view35695-comment-appears-in-a-wrong-place-after-changing-diff-view-to-inlineSean McGivern2017-07-281-2/+15
| | | | | | | | | When you change the diff view (inline / side-by-side), we set a cookie based on that new view. When you add a comment, we choose the style to use in the response based on that cookie. However, when you have just changed diff style, the request cookie will contain the old value, so we should use the view param instead.
* Remove superfluous type defs in specsKeifer Furzland2017-07-271-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Resolve "Lazy load images on the Frontend"Tim Zallmann2017-07-242-34/+21
|
* Support both internal and external issue trackersJarka Kadlecova2017-07-241-1/+7
|
* Wrong data type when testing webhooksAlexander Randa2017-07-201-0/+20
|
* Merge branch '34930-fix-edited-by' into 'master'Sean McGivern2017-07-191-0/+20
|\ | | | | | | | | | | | | Fix issue detail if user who last edited an issue was deleted Closes #34930 See merge request !12933
| * Use Ghost user when edited_by, merged_by deleted34930-fix-edited-byJarka Kadlecova2017-07-191-0/+20
| |
* | Merge branch 'authentiq-updates' into 'master'Rémy Coutable2017-07-191-1/+1
|\ \ | | | | | | | | | | | | Added authentiq provider to tests and updated documentation, gem and config file. See merge request !12952
| * | Added authentiq provider to tests and updated documentation, gem and config ↵Alexandros Keramidas2017-07-181-1/+1
| | | | | | | | | | | | file.
* | | Update specs for new upload pathBob Van Landuyt2017-07-184-11/+11
| |/ |/|
* | Merge branch 'fixes-for-internal-auth-disabled' into 'master'Sean McGivern2017-07-142-3/+3
|\ \ | | | | | | | | | | | | Fixes needed when GitLab sign-in is not enabled See merge request !12491
| * | Fixes needed when GitLab sign-in is not enabledRobin Bobbitt2017-07-132-3/+3
| |/ | | | | | | | | | | | | | | | | When sign-in is disabled: - skip password expiration checks - prevent password reset requests - don’t show Password tab in User Settings - don’t allow login with username/password for Git over HTTP requests - render 404 on requests to Profiles::PasswordsController