summaryrefslogtreecommitdiff
path: root/spec/javascripts/notes
Commit message (Collapse)AuthorAgeFilesLines
* Move NoteApp tests to JestWinnie Hellmann2019-06-031-331/+0
|
* Fix emoji picker visibility issueFatih Acet2019-05-311-0/+1
|
* Increase global karma timeoutrevert-karma-timeoutHeinrich Lee Yu2019-05-291-2/+2
| | | | Revert useless timeout added in karma spec
* Increase timeout of flaky specsHeinrich Lee Yu2019-05-281-2/+2
|
* Add failing test for saveNote error handlingWinnie Hellmann2019-05-071-0/+45
|
* Resolve discussion when suggestion is applied54405-resolve-discussion-when-applying-a-suggested-changePaul Slaughter2019-05-071-16/+114
| | | | | | | | | - Adds color and a tooltip to describe this new behavior - Does not resolve if discussion is already resolved - Adds an action `resolveDiscussion` to simplify `toggleResolveNote` - Updates docs https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
* Extract discussion notes into new componentPaul Gascou-Vaillancourt2019-05-011-23/+0
| | | | | | | | | - Moved discussion notes out of `NoteableDiscussion` component into a new `DiscussionNotes` component - Wrote Jest tests for the new `DiscussionNotes` component - Updated Jest config for emojis fixtures - Updated Karma tests `NoteableDiscussion` to match its new structure - Convert `DiffDiscussions` tests to use Vue test utils
* Fixed test specsOswaldo Ferreira2019-04-041-4/+2
| | | | | - added suggestions to mock data - fixed props to be not required
* Remove reply_to_individual_notes feature flag58644-remove-reply_to_individual_notes-feature-flagHeinrich Lee Yu2019-04-031-68/+14
| | | | Also removes specs related to the flag
* Upgraded Vue to 2.6.8Tim Zallmann2019-03-271-6/+6
| | | | Upgrade to latest Version
* Remove top-level mount from note_form_spec.jsWinnie Hellmann2019-03-261-6/+12
|
* Move some tests from Karma to JestWinnie Hellmann2019-03-234-178/+0
|
* Pass autosaveKey from NoteableDiscussion to NoteFormWinnie Hellmann2019-03-211-0/+1
|
* Validate NoteForm props in noteable_discussion_spec.jsWinnie Hellmann2019-03-211-1/+12
|
* Use autosave utilities in NoteForm componentWinnie Hellmann2019-03-211-8/+86
|
* Handle transformed notes from polling responseHeinrich Lee Yu2019-03-061-0/+13
| | | | Transforms notes when the note was transformed in some other tab
* Move EE differences in CE diff files into CEPhil Hughes2019-03-011-0/+8
| | | | Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9974, https://gitlab.com/gitlab-org/gitlab-ee/issues/9973, https://gitlab.com/gitlab-org/gitlab-ee/issues/9969
* Merge branch 'winh-note_form_spec-vue-test-utils' into 'master'Fatih Acet2019-03-011-59/+98
|\ | | | | | | | | Refactor note_form_spec.js to use Vue test utils See merge request gitlab-org/gitlab-ce!25571
| * Refactor note_form_spec.js to use Vue test utilsWinnie Hellmann2019-02-281-59/+98
| |
* | Fix misspellings in app/spec executable linesTakuya Noguchi2019-02-271-2/+2
|/ | | | Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
* Add support for toggling discussion filter from notes sectionKushal Pandya2019-02-263-6/+116
| | | | | | Adds discussion note style section under notes app from where user can toggle discussion when they have selected a filter to show only system notes.
* Extract ResolveWithIssueButton from NoteableDiscussion componentWinnie Hellmann2019-02-252-0/+70
|
* Merge branch 'winh-jest-gitlab-ui' into 'master'Kushal Pandya2019-02-211-33/+0
|\ | | | | | | | | | | | | Make Jest work with gitlab-ui Closes #56689 See merge request gitlab-org/gitlab-ce!25440
| * Move discussion_jump_to_next_button_spec.js to JestWinnie Hellmann2019-02-211-33/+0
| |
* | CE backport of design-management-issue-tabPhil Hughes2019-02-201-0/+10
|/ | | | Backports template and Vue changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9632 to CE
* Remove noteId prop from ReplyButton componentWinnie Hellmann2019-02-181-18/+4
| | | | Move convertToDiscussion call from ReplyButton to NoteApp component
* Cancelling reply reverts comment to initial stateConstance Okoghenun2019-02-182-0/+33
| | | | | | When converting a comment to a discussion if the "Cancel" button is used to exit the new discussion note, the comment would revert back to its initial state
* Fix polling for replies to individual notesHeinrich Lee Yu2019-02-142-7/+141
| | | | | Sets `updated_at` so that the transformed note is returned together with the new reply
* Convert noteable_note_spec.js to Vue test utilsWinnie Hellmann2019-02-121-33/+85
| | | | (cherry picked from commit 861f93e6fc72ef4adbc4ace3fd297382e07b619c)
* Merge branch '55209-tool-tip-hides-menu-item' into 'master'Phil Hughes2019-02-121-8/+22
|\ | | | | | | | | | | | | Resolve "Tool Tip Hides Menu Item" Closes #55209 See merge request gitlab-org/gitlab-ce!24285
| * Hide More Actions tooltip when the menu opens55209-tool-tip-hides-menu-itemSimon Knox2019-02-121-8/+22
| |
* | Merge branch 'local-markdown-version' into 'master'Douglas Barbosa Alexandre2019-02-071-1/+0
|\ \ | |/ |/| | | | | | | | | Add local markdown version Closes #32789 See merge request gitlab-org/gitlab-ce!24822
| * Add local markdown versionlocal-markdown-versionJan Provaznik2019-02-061-1/+0
| | | | | | | | | | | | Cached markdown version is composed both from global and local markdown version. This allows admins to bump version locally when needed (e.g. when external URL is changed).
* | Revert "Convert noteable_note_spec.js to Vue test utils"Winnie Hellmann2019-02-061-70/+23
| |
* | Add reply to notes to turn into discussionsHeinrich Lee Yu2019-02-064-38/+194
| |
* | Merge branch 'winh-noteable_note_spec-vue-test-utils' into 'master'Fatih Acet2019-02-061-23/+70
|\ \ | |/ |/| | | | | Convert noteable_note_spec.js to Vue test utils See merge request gitlab-org/gitlab-ce!24801
| * Convert noteable_note_spec.js to Vue test utilsWinnie Hellmann2019-01-301-23/+70
| |
* | Merge branch 'winh-note_app_spec-vue-test-utils' into 'master'sh-bump-supported-ruby-versionsFatih Acet2019-02-061-81/+86
|\ \ | | | | | | | | | | | | Convert note_app_spec.js to Vue test utils See merge request gitlab-org/gitlab-ce!24900
| * | Convert note_app_spec.js to Vue test utilsWinnie Hellmann2019-02-041-81/+86
| |/
* | Extract ReplyPlaceholder from NoteableDiscussion componentWinnie Hellmann2019-02-052-17/+48
|/
* Convert noteable_discussion_spec.js to Vue test utilsWinnie Hellmann2019-01-291-65/+77
|
* refactor(NoteableDiscussion): Extracted ResolveDiscussionButton fromMartin Hobert2019-01-281-0/+74
|
* Merge branch 'refactor/56369-extract-jump-to-next-discussion-button' into ↵Phil Hughes2019-01-281-0/+33
|\ | | | | | | | | | | | | | | | | 'master' Refactor/56369 extract jump to next discussion button Closes #56369 See merge request gitlab-org/gitlab-ce!24506
| * refactor(NoteableDiscussion): Extracted JumpToNextDiscussionButton to its ↵Martin Hobert2019-01-281-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | own component fix #56369 chore(changelog): Added changelog entry chore(prettier): Formated with prettier test(JumpToNextDiscussionButton): Added test for new component test(Refactored tests to use vue test-utils): chore(translations): Added newly generated locales Update spec/javascripts/notes/components/discussion_jump_to_next_button_spec.js chore(prettier): Formated with prettier test(JumpToNextDiscussionButton): Updated tests to use a local vue instance test(JumpToNextDiscussionButton): Running tests in async to prevent maximum stack overflow
* | Convert note_actions_spec.js to Vue test utilsWinnie Hellmann2019-01-251-19/+33
| |
* | Merge branch 'sh-bump-chrome-golang-ci-image' into 'master'Clement Ho2019-01-241-0/+2
|\ \ | | | | | | | | | | | | | | | | | | Bump CI image to use Chrome 71.0 and Golang 1.11 Closes #56614 and #55578 See merge request gitlab-org/gitlab-ce!24572
| * | Fix discussion counter spec mock dataLukas Eipert2019-01-231-0/+2
| |/ | | | | | | | | | | To me it seems like the mock data does not match the actual data anymore. I checked the actual data and to me it seems like the resolved property actually should live in the overall discussion object.
* | Trim first char of diff line text on diff discussionsDouwe Maan2019-01-221-5/+11
|/ | | | | | | | | | | | Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and diff discussion `truncated_diff_lines` were inconsistent: `text` and `rich_text` on the latter included the leading +/-/<space> character, like on the backend, while the former had no `text` and its `rich_text` had dropped this char. This resulted in a bug when the suggestions feature expected these diff line objects to be identical in format and thus interchangeable, which was not the case.
* Discussion filters - ensured note links resolves to the right noteConstance Okoghenun2019-01-101-5/+41
|
* Removed discard comment buttonConstance Okoghenun2019-01-071-1/+0
| | | | | Removed the button and associated tests form notes on Issues and Merge request page.