summaryrefslogtreecommitdiff
path: root/spec/javascripts/notes
Commit message (Collapse)AuthorAgeFilesLines
* Change the way totalNotes is calculatedid-change-total-notes-calculationIgor Drozdov2019-08-281-1/+1
| | | | | | | | | | | | | | | totalNotes is only used to prerender a number of skeleton containers until real notes are loaded issuable.discussions makes multiple requests, so too expensive for this This commit uses mere notes for this and sends actual totalNotes number if it's less than 10; otherwise it sends 10 - it allows us to avoid bunch of skeleton prerenderings, which are not necessary since they doesn't fit into the whole screen and disappear quite fast
* Add edit_note and spec for editing quick actionsPatrick Derichs2019-08-261-3/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Call QuickActionsService on Note update Add support for notes which just contain commands after editing Return http status gone (410) if note was deleted Temporary frontend addition so it is not failing when a note is deleted Move specs to shared examples Fix rubocop style issue Deleting note on frontend when status is 410 Use guard clause for note which got deleted Simplified condition for nil note This method should no longer be called with nil note Refactoring of execute method to reduce complexity Move errors update to delete_note method Note is now deleted visually when it only contains commands after update Add expectation Fix style issues Changing action to fix tests Add tests for removeNote and update deleteNote expectations
* Refactor nextUnresolvedDiscussionId and previousUnresolvedDiscussionId gettersArun Kumar Mohan2019-08-151-41/+89
|
* Add kbd shortcuts for discussion navigationSam Bigelow2019-08-121-0/+48
| | | | Add keyboard shortcuts `p` and `n` to navigate duscussions.
* Do not persist notes filter when auto-switchingHeinrich Lee Yu2019-08-071-0/+27
| | | | | | Send a `persist_filter: false` param to backend when opening links to notes and auto-switching to show all notes
* Backport from EE10646-create-drafts-with-commit-id-cejboyson12019-08-011-0/+2
|
* Resolve "Tooltips on note timestamps not showing for issues"Natalia Tepluhina2019-07-181-3/+2
|
* Remove deleteNote from notes serviceWinnie Hellmann2019-07-101-11/+9
|
* Updates on success of an MR the count on top and in other tabsTim Zallmann2019-07-091-0/+15
| | | | | | | | | | | | | | | | | | | | New API endpoint for merge request count Updates all open tabs at the same time with one call Restructured API response API response changed to 401 if no current_user Added API + JS specs Fix for Static Check Updated Count on Open/Close, Assign/Unassign of MR's Checking if MR Count is refreshed Added # frozen_string_literal: true to spec Added Changelog
* Remove applySuggestion from notes serviceWinnie Hellmann2019-07-051-4/+4
|
* Merge branch 'master' into michel.engelen/gitlab-ce-issue/55953Sean McGivern2019-07-032-8/+14
|\
| * Rebased and squashed commitsNatalia Tepluhina2019-07-031-0/+6
| | | | | | | | - all commits squashed to make danger review happy
| * Fix typo in updateResolvableDiscussionsCounts actionWinnie Hellmann2019-07-021-8/+8
| |
* | prettified noteable_discussion spec fileMichel Engelen2019-07-021-6/+4
| |
* | prettified js testfile for noteable_discussion componentMichel Engelen2019-07-021-3/+3
| |
* | updated karma test for noteable_discussion componentMichel Engelen2019-07-021-1/+1
| |
* | prettified noteable_discussion component and updated testsMichel Engelen2019-07-021-18/+18
|/
* Rearrange discussion resolve buttons & update button displaySamantha Ming2019-06-281-0/+20
| | | | | - next-discuss button is always show unless there is only 1 discussion - regroup buttons arrangements
* Add back trimChar method to remove trailing +/-Samantha Ming2019-06-211-0/+13
| | | | Add test for checking output
* Change "Report abuse to GitLab" to more generic wording.Marc Schwede2019-06-061-1/+1
|
* Move NoteApp tests to JestWinnie Hellmann2019-06-031-331/+0
|
* Fix emoji picker visibility issueFatih Acet2019-05-311-0/+1
|
* Increase global karma timeoutrevert-karma-timeoutHeinrich Lee Yu2019-05-291-2/+2
| | | | Revert useless timeout added in karma spec
* Increase timeout of flaky specsHeinrich Lee Yu2019-05-281-2/+2
|
* Add failing test for saveNote error handlingWinnie Hellmann2019-05-071-0/+45
|
* Resolve discussion when suggestion is applied54405-resolve-discussion-when-applying-a-suggested-changePaul Slaughter2019-05-071-16/+114
| | | | | | | | | - Adds color and a tooltip to describe this new behavior - Does not resolve if discussion is already resolved - Adds an action `resolveDiscussion` to simplify `toggleResolveNote` - Updates docs https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
* Extract discussion notes into new componentPaul Gascou-Vaillancourt2019-05-011-23/+0
| | | | | | | | | - Moved discussion notes out of `NoteableDiscussion` component into a new `DiscussionNotes` component - Wrote Jest tests for the new `DiscussionNotes` component - Updated Jest config for emojis fixtures - Updated Karma tests `NoteableDiscussion` to match its new structure - Convert `DiffDiscussions` tests to use Vue test utils
* Fixed test specsOswaldo Ferreira2019-04-041-4/+2
| | | | | - added suggestions to mock data - fixed props to be not required
* Remove reply_to_individual_notes feature flag58644-remove-reply_to_individual_notes-feature-flagHeinrich Lee Yu2019-04-031-68/+14
| | | | Also removes specs related to the flag
* Upgraded Vue to 2.6.8Tim Zallmann2019-03-271-6/+6
| | | | Upgrade to latest Version
* Remove top-level mount from note_form_spec.jsWinnie Hellmann2019-03-261-6/+12
|
* Move some tests from Karma to JestWinnie Hellmann2019-03-234-178/+0
|
* Pass autosaveKey from NoteableDiscussion to NoteFormWinnie Hellmann2019-03-211-0/+1
|
* Validate NoteForm props in noteable_discussion_spec.jsWinnie Hellmann2019-03-211-1/+12
|
* Use autosave utilities in NoteForm componentWinnie Hellmann2019-03-211-8/+86
|
* Handle transformed notes from polling responseHeinrich Lee Yu2019-03-061-0/+13
| | | | Transforms notes when the note was transformed in some other tab
* Move EE differences in CE diff files into CEPhil Hughes2019-03-011-0/+8
| | | | Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9974, https://gitlab.com/gitlab-org/gitlab-ee/issues/9973, https://gitlab.com/gitlab-org/gitlab-ee/issues/9969
* Merge branch 'winh-note_form_spec-vue-test-utils' into 'master'Fatih Acet2019-03-011-59/+98
|\ | | | | | | | | Refactor note_form_spec.js to use Vue test utils See merge request gitlab-org/gitlab-ce!25571
| * Refactor note_form_spec.js to use Vue test utilsWinnie Hellmann2019-02-281-59/+98
| |
* | Fix misspellings in app/spec executable linesTakuya Noguchi2019-02-271-2/+2
|/ | | | Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
* Add support for toggling discussion filter from notes sectionKushal Pandya2019-02-263-6/+116
| | | | | | Adds discussion note style section under notes app from where user can toggle discussion when they have selected a filter to show only system notes.
* Extract ResolveWithIssueButton from NoteableDiscussion componentWinnie Hellmann2019-02-252-0/+70
|
* Merge branch 'winh-jest-gitlab-ui' into 'master'Kushal Pandya2019-02-211-33/+0
|\ | | | | | | | | | | | | Make Jest work with gitlab-ui Closes #56689 See merge request gitlab-org/gitlab-ce!25440
| * Move discussion_jump_to_next_button_spec.js to JestWinnie Hellmann2019-02-211-33/+0
| |
* | CE backport of design-management-issue-tabPhil Hughes2019-02-201-0/+10
|/ | | | Backports template and Vue changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9632 to CE
* Remove noteId prop from ReplyButton componentWinnie Hellmann2019-02-181-18/+4
| | | | Move convertToDiscussion call from ReplyButton to NoteApp component
* Cancelling reply reverts comment to initial stateConstance Okoghenun2019-02-182-0/+33
| | | | | | When converting a comment to a discussion if the "Cancel" button is used to exit the new discussion note, the comment would revert back to its initial state
* Fix polling for replies to individual notesHeinrich Lee Yu2019-02-142-7/+141
| | | | | Sets `updated_at` so that the transformed note is returned together with the new reply
* Convert noteable_note_spec.js to Vue test utilsWinnie Hellmann2019-02-121-33/+85
| | | | (cherry picked from commit 861f93e6fc72ef4adbc4ace3fd297382e07b619c)
* Merge branch '55209-tool-tip-hides-menu-item' into 'master'Phil Hughes2019-02-121-8/+22
|\ | | | | | | | | | | | | Resolve "Tool Tip Hides Menu Item" Closes #55209 See merge request gitlab-org/gitlab-ce!24285