| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
into 'master'
Avoid a TypeError when initializing MergeRequest JS class with no arg
## What does this MR do?
Avoid a TypeError when initializing MergeRequest JS class with no arg.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
Without this sane default you would get the following error when you
tried to instantiate a new MergeRequest object with no argument (i.e.
`new MergeRequest();`):
TypeError: undefined is not an object (evaluating 'this.opts.action')
## What are the relevant issue numbers?
Fixes #13525.
## Does this MR meet the acceptance criteria?
- [x] No CHANGELOG since it's a trivial internal change
- [x] Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !4667
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without this sane default you would get the following error when you
tried to instantiate a new MergeRequest object with no argument (i.e.
`new MergeRequest();`):
TypeError: undefined is not an object (evaluating 'this.opts.action')
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
category-search-dropdown
# Conflicts:
# app/assets/javascripts/lib/common_utils.js.coffee
|
| | | | |
|
| | |/
| |
| |
| |
| | |
- We added a `current_user.two_factor_via_otp?` check to the view. When
rendering the view via the teaspoon fixture, `current_user` is `nil`.
|
| |\ \
| |/
| |
| | |
category-search-dropdown
|
| | | |
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Notes are awardables
## What does this MR do?
Makes sure we can :thunder_cloud_rain: comments/notes.
## What are the relevant issue numbers?
Follows up upon !2901, depends on !3785
Closes #3655
## Screenshots (if relevant)
TODO
See merge request !4291
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Upgraded jQuery to version 2
## What does this MR do?
Upgrades jQuery to 2.2.1.
Had to include the task_list JS file directly as it includes jQuery 1 directly https://github.com/github-archive/task_list/blob/master/app/assets/javascripts/task_list.coffee#L8 so when we change jQuery to `jquery2` it was including both jQuery 1 & 2.
## Are there points in the code the reviewer needs to double check?
For any JS errors
## What are the relevant issue numbers?
Closes #12440
See merge request !4384
|
| | |/
| |
| |
| | |
CHANGELOG item
|
| | |
| |
| |
| |
| |
| | |
- Move the `authenticate_with_two_factor` method from
`ApplicationController` to the `AuthenticatesWithTwoFactor` module,
where it should be.
|
| |/
|
|
|
|
|
|
|
|
|
| |
- Move the `TwoFactorAuthsController`'s `new` action to `show`, since
the page is not used to create a single "two factor auth" anymore. We
can have a single 2FA authenticator app, along with any number of U2F
devices, in any combination, so the page will be accessed after the
first "two factor auth" is created.
- Add the `u2f` javascript library, which provides an API to the
browser's U2F implementation.
- Add tests for the JS components
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
# Conflicts:
# app/assets/stylesheets/pages/issuable.scss
|
| | | |
|
| |/ |
|
| |
|
|
| |
didn't change
|
| | |
|
| |
|
|
| |
correctly again
|
| |
|
|
| |
Updated JS spec to include gl_form
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Fix data check in update issue response
See merge request !3548
|
| | | |
|
| |/ |
|
| |
|
|
|
| |
Now it will work on any field inside that form, and it's easier to scope
new behavior, which is what we're adding next!
|
| | |
|
| |
|
|
|
|
| |
Moved the positioning of the dropdown to be more aligned with the title
Closes #13219 and #13214
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added dropdown to list all projects on project header
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/4212
When clicking the current project name, it shows a dropdown menu with a list of all projects for that group or user.
When closed:
When open:
cc. @jschatz1
See merge request !2438
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, the autosize library was being too controlling and removed the
`resize` property from any elements to which it was attached, removing
the drag handle.
Second, we detect when the user manually resizes an autosize textarea,
and then remove the autosize behavior from it and increase its
max-height.
This should allow for the best of both worlds.
Closes #12832
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
- No longer depends on the "hidden checkbox".
- No longer depends on manually storing/restoring the scroll position.
Instead, we take advantage of jquery.scrollTo.
- Event-based.
- Simplifies the state-based styling.
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| | |
open and close issue via ajax request. With tests
Close and Reopen issues with ajax request.
See merge request !2164
|
| | |
| |
| |
| | |
*implementation* instead of the spec.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
https://robots.thoughtbot.com/four-phase-test
|
| | | |
|
