| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Update specs to exclude possible false positive pass | blackst0ne | 2018-12-18 | 1 | -1/+1 |
| | | |||||
| * | Fix Error 500s due to encoding issues when Wiki hooks fire | Stan Hu | 2018-08-29 | 1 | -0/+12 |
| | | | | | | | | | | | | | Saved Wiki content goes through the GitalyClient::WikiService, which calls StringIO#set_encoding on the input stream. The problem is that this call mutates the encoding of the given string object to ASCII-88BIT, which causes problems for models expecting the data to still be in UTF-8. Freezing the input disables this behavior: https://github.com/ruby/ruby/blob/v2_4_4/ext/stringio/stringio.c#L1583 Closes #50590 | ||||
| * | Fix EncodingHelper#clean blowing up on UTF-16BE stringsfix/encoding-helper-clean-blowing-up-on-utf-16be | Ahmad Sherif | 2018-03-22 | 1 | -0/+5 |
| | | | | | Closes gitaly#1101 | ||||
| * | Return a warning string if we try to encode to unsupported encoding | Ahmad Sherif | 2018-02-09 | 1 | -0/+5 |
| | | | | | Fixes gitlab-development-kit#321 | ||||
| * | Fix a bug where charlock_holmes was used needlessly to encode strings41677-branch-name-omitted-due-to-bad-utf-8-conversion-by-gitaly-ref-handler | Alejandro Rodríguez | 2018-01-04 | 1 | -0/+18 |
| | | |||||
| * | Move encoding methods to the more general EncodingHelpergitaly-encoding-helpers | Alejandro Rodríguez | 2017-12-28 | 1 | -0/+14 |
| | | |||||
| * | Fix encoding bugs in Gitlab::Git::User | Jacob Vosmaer (GitLab) | 2017-11-23 | 1 | -0/+1 |
| | | |||||
| * | Avoind unnecesary `force_encoding` operations | Alejandro Rodríguez | 2017-10-18 | 1 | -2/+14 |
| | | | | | | | They're costly. This will also avoid some edge cases where charlock_holmes assigns a weird encoding to a perfectly valid UTF-8 string. | ||||
| * | Make sure that we have author and committer | Lin Jen-Shin | 2017-08-08 | 1 | -0/+3 |
| | | | | | In case we don't have it setup in ~/.gitconfig | ||||
| * | Add a test to show that threshold 40 would corrupt35098-raise-encoding-confidence-threshold | Lin Jen-Shin | 2017-08-08 | 1 | -0/+44 |
| | | | | | | | | | | | | If we set `ENCODING_CONFIDENCE_THRESHOLD` to 40, this test case would not pass. If we raise to 50, this would pass. Note that if in the future rugged didn't return corrupt data, this would be less relevant. But still icu recommend the threshold to be 50, we should just stick with 50. | ||||
| * | Rename `Gitlab::Git::EncodingHelper` to `Gitlab::EncodingHelper` | Bob Van Landuyt | 2017-06-01 | 1 | -0/+88 |
 |
index : delta/gitlab/gitlab-ce.git | |
| gitlab.com: gitlab-org/gitlab-ce.git |
| summaryrefslogtreecommitdiff |