Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-11-08 | 1 | -0/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-10-07 | 1 | -0/+1 |
| | |||||
* | Use stub_rails_env for Rails.env stubbing66966-convert-rails-env-stub-usages-to-use-railshelpers-stub_rails_env-instead | Ash McKenzie | 2019-09-05 | 1 | -2/+0 |
| | | | | | RailsHelpers.stub_rails_env takes care of stubbing Rails.env | ||||
* | Merge branch '13988-add-rails-helpers' into 'master' | Stan Hu | 2019-09-03 | 1 | -3/+5 |
|\ | | | | | | | | | | | | | Add new RailsHelpers module for specs Closes #66688 See merge request gitlab-org/gitlab-ce!32309 | ||||
| * | Use new RailsHelpers module13988-add-rails-helpers | Ash McKenzie | 2019-08-28 | 1 | -3/+5 |
| | | |||||
* | | Replace rails_helper.rb with spec_helper.rb66741-remove-spec-rails_helper-rb | Ash McKenzie | 2019-08-30 | 1 | -1/+1 |
|/ | | | | | rails_helper.rb's only logic was to require spec_helper.rb. | ||||
* | EE backport to CE of favicon_spec.rbsingle-codebase-favicon-specs-cemove-ee-favicon-spec-changes-to-ee | lmcandrew | 2019-05-13 | 1 | -1/+1 |
| | |||||
* | Fix favicon spec | Shinya Maeda | 2018-10-02 | 1 | -0/+1 |
| | |||||
* | Read asset host from ActionController::Base instead of application config | Douwe Maan | 2018-06-29 | 1 | -1/+1 |
| | |||||
* | Fix: Serve favicon image always from the main GitLab domain to avoid issues ↵ | Alexis Reigel | 2018-06-20 | 1 | -0/+15 |
| | | | | with CORS | ||||
* | Remove FaviconUploader favicon_main versiondm-remove-favicon-main-version | Douwe Maan | 2018-06-15 | 1 | -1/+1 |
| | | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/47677 for more information | ||||
* | Don't use Rails.root.join for upload fixture paths | Rémy Coutable | 2018-06-11 | 1 | -1/+1 |
| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | remove all .ico favicon variations, use png always | Alexis Reigel | 2018-06-05 | 1 | -5/+5 |
| | | | | | the ci status icons are generated client side, wo we don't need the static files anymore. | ||||
* | create favicon overlay on the client | Alexis Reigel | 2018-06-05 | 1 | -8/+22 |
| | | | | | | | | | | | | | the initial reason for this change was that graphicsmagick does not support writing to ico files. this fact lead to a chain of changes: 1. use png instead of ico (browser support is good enough) 2. render the overlays on the client using the canvas API. this way we only need to store the original favion and generate the overlay versions dynamically. this change also enables (next step) to simplify the handling of the stock favicons as well, as we don't need to generate all the versions upfront. | ||||
* | call Gitlab::Favicon.status in serializer | Alexis Reigel | 2018-06-05 | 1 | -8/+8 |
| | | | | | | | | | this ways we can keep the `lib/gitlab/ci/status/*` classes to return the bare favicon name as it was before. also the favicon uploader versions are now have the same names as the stock favicons (+ `favicon_` prefix), which makes working with the status names easier. | ||||
* | add request store caching to favicon | Alexis Reigel | 2018-06-05 | 1 | -1/+1 |
| | |||||
* | Add a '?' to the custom favicon's urls | Alexis Reigel | 2018-06-05 | 1 | -2/+2 |
| | | | | | | | | Without the '?' at the end of the favicon url the custom favicon (i.e. the favicons that are served through `UploadController`) are not shown in the browser. It may have something to do with how `#send_file` / `#send_data` set http headers. When serving the same icon file from the public directory everything is fine. | ||||
* | use custom favicon for ci build status favicons | Alexis Reigel | 2018-06-05 | 1 | -0/+13 |
| | |||||
* | extract favicon logic to lib class | Alexis Reigel | 2018-06-05 | 1 | -0/+25 |