summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab/legacy_github_import
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@12-4-stable-eeGitLab Bot2019-10-221-0/+8
|
* Add frozen_string_literal to lib part 2Thong Kuah2019-08-233-0/+6
| | | | | Using the sed script from https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
* Show upcoming status for releasesJason Goodman2019-07-032-1/+5
| | | | | | Add released_at field to releases API Add released_at column to releases table Return releases to the API sorted by released_at
* Improve the gitea importer testJohn Kristensen2019-06-141-15/+10
| | | | | | | | | The changes to the tests to support ignoring Gitea pull requests comments were a bit of a hack. The suggestions provided by Ash McKenzie in gitlab-org/gitlab-ce!29521 make things a bit more flexible if any future changes need to be made to the tests. The changes made to ignore
* Don't import pull request comments from Gitea reposJohn Kristensen2019-06-121-2/+8
| | | | | | | | | | | | The Gitea API does not provide the following API endpoint for pull request comments: /api/v1/repos/{owner}/{repo}/pulls/comments When the importer attempts to request this endpoint it receives a '404 Not Found' error which causes the import to fail. By skipping any attempts to import pull requests comments from Gitea we can ensure that the import can complete successfully.
* Merge branch '47327-fix-github-project-import-visibility' into 'master'Douwe Maan2019-04-101-3/+13
|\ | | | | | | | | Fix GitHub project import visibility See merge request gitlab-org/gitlab-ce!27133
| * Address style review commentDaniel Wyatt2019-04-091-2/+0
| |
| * Add test for github project import to user namespace.Daniel Wyatt2019-04-091-0/+12
| |
| * Fix GitHub project import visibilityDaniel Wyatt2019-04-081-2/+2
| |
* | Set release name when adding release notes to an existing tagJason Goodman2019-04-091-0/+1
|/ | | | Also set the release sha and author
* Add more tests and comments around Wiki formattingStan Hu2019-02-051-1/+7
|
* Add spec for Release APIShinya Maeda2018-12-311-1/+1
| | | | | Add spec for all release API - GET, POST, PUT, DELETE. Also, fixes some minior bugs.
* Removes all the irrelevant import related code and columnsTiago Botelho2018-11-271-1/+1
| | | | | Clears the import related columns and code from the Project model over to the ProjectImportState model
* Implement `expect_next_instance_of` and use itLin Jen-Shin2018-06-211-1/+4
| | | | | We need this because `expect_any_instance_of` doesn't work on prepended models. Now we could use the same code between CE/EE
* Use Github repo visibility during import while respecting restricted ↵Imre Farkas2018-06-061-6/+34
| | | | visibility levels
* Resolve "Namespace factory is problematic"Lin Jen-Shin2018-04-231-1/+1
|
* Rewrite the GitHub importer from scratchYorick Peterse2017-11-0713-0/+1461
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
View Lorry Controller Status