summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab
Commit message (Collapse)AuthorAgeFilesLines
* Stop matching on legacy app labelThong Kuah2019-06-191-10/+0
| | | | | | From now on, only match on the annotations, instead of falling back to legacy app label. This enables users to use the app label for other purposes such as helm charts.
* Turn on Cat-File cache by defaultZeger-Jan van de Weg2019-06-181-4/+8
| | | | | | | | | | | | | | | | The feature flag has been introduced an was turned off by default, now the it will default to be turned on. That change would still allow users to turn this feature off by leveraging the Rails console by running: `Feature.disable("gitaly_catfile-cache")` Another option is to manage the number of items the LRU cache will contain, by updating the `config.toml` for Gitaly. This would be the `catfile_cache_size`: https://gitlab.com/gitlab-org/gitaly/blob/0dcb5c579e63754f557aef91a4fa7a00e5b8b127/config.toml.example#L27 Closes: https://gitlab.com/gitlab-org/gitaly/issues/1712
* Move Gitaly feature flag logic to Feature::GitalyZeger-Jan van de Weg2019-06-181-14/+0
| | | | | | | The GitalyClient held a lot of logic which was all very tightly coupled. In this instance the feature logic was extracted to make it do just a little less and create a bit more focus in the GitalyClient's responsibilies.
* Introduce default: for gitlab-ci.ymlKamil Trzciński2019-06-189-184/+505
| | | | | | | | | | | This moves all existing `image/services/before_script/variables` into `default:`. This allows us to easily add a default and top-level entries. `default`: is keep backward compatible: to be considered to be job if `default:script:` is specified. This behavior should be removed. All existing `image/services/before_script/variables` are properly handled in root context.
* Make KubernetesService readonlyJames Fargher2019-06-181-14/+4
| | | | | | | | We are deprecating this service in favor of instance wide clusters. Therefore we removed some code that is not anymore needed for a readonly cluster and also we added some flags to allow for this deprecation. These flags are to be removed in the next release when we finally completelly remove KubernetesService.
* Merge branch '55362-refresh-blank-service-account-token' into 'master'Thong Kuah2019-06-171-1/+7
|\ | | | | | | | | Refresh service_account_token for kubernetes_namespaces See merge request gitlab-org/gitlab-ce!29657
| * Refresh service_account_token for kubernetes_namespaces55362-refresh-blank-service-account-tokenDylan Griffith2019-06-141-1/+7
| | | | | | | | | | | | | | There seems to be several examples where service_account_token is blank even in GitLab.com newly created kubernetes_namespaces . We have not figured out why they are blank but this should hopefully fix some issues similar to https://gitlab.com/gitlab-org/gitlab-ce/issues/55362
* | Merge branch 'generate-spans-for-sections' into 'master'Sean McGivern2019-06-172-32/+45
|\ \ | | | | | | | | | | | | Add collapsible sections to job log See merge request gitlab-org/gitlab-ce!28642
| * | Compact syntax for default class namesFabio Pitino2019-06-171-1/+1
| | |
| * | Make failing specs passgenerate-spans-for-sectionsFabio Pitino2019-06-171-5/+10
| | |
| * | Replace _ with - in section class namesFabio Pitino2019-06-141-3/+3
| | |
| * | Fixing specsFabio Pitino2019-06-141-27/+35
| | |
* | | Backport the EE schema and migrations to CEYorick Peterse2019-06-1717-938/+423
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This backports all EE schema changes to CE, including EE migrations, ensuring both use the same schema. == Updated tests A spec related to ghost and support bot users had to be modified to make it pass. The spec in question assumes that the "support_bot" column exists when defining the spec. In the single codebase setup this is not the case, as the column is backported in a later migration. Any attempt to use a different schema version or use of "around" blocks to conditionally disable specs won't help, as reverting the backport migration would also drop the "support_bot" column. Removing the "support_bot" tests entirely appears to be the only solution. We also need to update some foreign key tests now that we have backported the EE columns. Fortunately, these changes are very minor. == Backporting migrations This commit moves EE specific migrations (except those for the Geo tracking database) and related files to CE, and also removes any traces of the ee/db directory. Some migrations had to be modified or removed, as they no longer work with the schema being backported. These migrations were all quite old, so we opted for removing them where modifying them would take too much time and effort. Some old migrations were modified in EE, while also existing in CE. In these cases we took the EE code, and in one case removed them entirely. It's not worth spending time trying to merge these changes somehow as we plan to remove old migrations around the release of 12.0, see https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
* | | Allow custom names for concurrent foreign keysYorick Peterse2019-06-171-0/+27
| | | | | | | | | | | | | | | This is necessary for backporting the EE schema to ensure backported foreign keys use the same key names.
* | | Merge branch '58886-issue-tracker-fields' into 'master'Sean McGivern2019-06-171-0/+2
|\ \ \ | | | | | | | | | | | | | | | | Create models for issue trackers data See merge request gitlab-org/gitlab-ce!28598
| * | | Create models for issue trackers data58886-issue-tracker-fieldsJarka Košanová2019-06-131-0/+2
| | | | | | | | | | | | | | | | | | | | - create tables for storing issue trackers properties - add model and basic logic & spec
* | | | Fix GPG signature verification with recent versions of GnuPGDavid Palubin2019-06-171-0/+83
| | | |
* | | | Fix plan stage queryGosia Ksionek2019-06-177-8/+201
| | | | | | | | | | | | | | | | Fix plan stage query and the way it is displayed
* | | | Merge branch 'error-pipelines-for-blocked-users' into 'master'Grzegorz Bizon2019-06-171-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Preventing blocked users and their PipelineSchdules from creating new Pipelines Closes #47756 See merge request gitlab-org/gitlab-ce!27318
| * | | | preventing blocked users and their PipelineSchdules from creating new Pipelinesdrew cimino2019-06-041-1/+1
| | | | | | | | | | | | | | | | | | | | updated several specs and factories to accomodate new permissions
* | | | | Return boolean from Lexeme::Matches#evaluateboolean-values-from-matches-operatordrew cimino2019-06-142-43/+28
| | | | |
* | | | | Merge branch 'bvl-comments-graphql' into 'master'Jan Provaznik2019-06-141-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Expose comments on Noteables in GraphQL Closes #62825 See merge request gitlab-org/gitlab-ce!29212
| * | | | | Expose comments on Noteables in GraphQLBob Van Landuyt2019-06-141-0/+6
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This exposes `Note`s on Issues & MergeRequests using a `Types::Notes::NoteableType` in GraphQL. Exposing notes on a new type can be done by implementing the `NoteableType` interface on the type. The presented object should be a `Noteable`.
* | | | | Specify a dropdown name for dashboardsSarah Yasonik2019-06-143-2/+41
| | | | |
* | | | | Add basic support for AsciiDoc include directiveGuillaume Grossetie2019-06-141-8/+180
| | | | | | | | | | | | | | | | | | | | See http://asciidoctor.org/docs/user-manual/#include-directive
* | | | | Merge branch 'gitea_import_ignore_pull_request_comments' into 'master'Ash McKenzie2019-06-141-9/+10
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | Don't import pull request comments from Gitea repos Closes #63071 See merge request gitlab-org/gitlab-ce!29521
| * | | | Improve the gitea importer testJohn Kristensen2019-06-141-15/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes to the tests to support ignoring Gitea pull requests comments were a bit of a hack. The suggestions provided by Ash McKenzie in gitlab-org/gitlab-ce!29521 make things a bit more flexible if any future changes need to be made to the tests. The changes made to ignore
| * | | | Don't import pull request comments from Gitea reposJohn Kristensen2019-06-121-2/+8
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Gitea API does not provide the following API endpoint for pull request comments: /api/v1/repos/{owner}/{repo}/pulls/comments When the importer attempts to request this endpoint it receives a '404 Not Found' error which causes the import to fail. By skipping any attempts to import pull requests comments from Gitea we can ensure that the import can complete successfully.
* | | | Merge branch ↵Kamil Trzciński2019-06-132-0/+53
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '61157-reviewer-roulette-shouldn-t-include-the-author-as-a-possibility' into 'master' Review roulette excludes mr_author Closes #61157 See merge request gitlab-org/gitlab-ce!28886
| * | | | Excludes MR author from Review roulette61157-reviewer-roulette-shouldn-t-include-the-author-as-a-possibilityJacopo2019-06-122-0/+53
| | | | | | | | | | | | | | | | | | | | | | | | | Excludes MR author from gitlab_ui and single_codebase Review roulette results.
* | | | | Merge branch 'sh-update-openid-omniauth-gem' into 'master'Douglas Barbosa Alexandre2019-06-121-8/+0
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Bump omniauth_openid_connect to 0.3.1 See merge request gitlab-org/gitlab-ce!29387
| * | | | Bump omniauth_openid_connect to 0.3.1sh-update-openid-omniauth-gemStan Hu2019-06-081-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In https://gitlab.com/gitlab-org/gitlab-ce/issues/62208, users were seeing 404 errors when they configured their OpenID provider without a name parameter since OmniAuth would use the name `openidconnect` instead `openid_connect`. https://github.com/m0n9oose/omniauth_openid_connect/pull/23 makes the default parameter `openid_connect` so this additional initializer in GitLab is not necessary. Plus, this change enables users to use multiple OpenID Connect providers if they desire.
* | | | | Monitor only final statesrack-timeout-renameJan Provaznik2019-06-121-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no reason to monitor transition states so we ignore ready and active states. We can get ratio of completed vs failed requests from final states.
* | | | | Moved RackTimeout observer to a different locationJan Provaznik2019-06-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Because there will be similar observer for PumaWorkerKiller, it makes sense to keep both on better place.
* | | | | Rename `BatchCommitLoader` to `BatchLfsOidLoader`Bob Van Landuyt2019-06-111-1/+1
| |/ / / |/| | | | | | | | | | | | | | | Since we're not actually loading commits in that loader, but we're loading blobs with LFS oids in batch and returning only the oids.
* | | | Merge branch 'ignore-artifact-attirbutes-in-project-import-export' into 'master'James Lopez2019-06-111-1/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ignore legacy artifact columns in Project Import/Export Closes #63033 See merge request gitlab-org/gitlab-ce!29427
| * | | | Ignore legacy artifact columns in Project Import/ExportShinya Maeda2019-06-111-1/+4
| | | | | | | | | | | | | | | | | | | | Ignore some columns
* | | | | Merge branch 'prom-api-1' into 'master'Sean McGivern2019-06-114-6/+35
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Update server API to enable switch prometheus endpoint See merge request gitlab-org/gitlab-ce!29186
| * | | | | Switch errors to inherit from a base classprom-api-1syasonik2019-06-062-16/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Error classes associated with individual stages of dashboard processing tend to have very long names. As dashboard post-processing includes more steps, we will likely need to handle more error cases. Refactoring to have all errors inherit from a specific base class will help accommodate this and keep the code more readable.
| * | | | | Address rubocop errorssyasonik2019-06-061-1/+4
| | | | | |
| * | | | | Expose prometheus endpoint per metric in dashboardsyasonik2019-06-064-5/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a new stage to dashboard processesing step for the EnvironmentsController::metrics_dashboard endpoint. Allows the front end to avoid generating the endpoint unitutive string mutations.
* | | | | | Merge branch 'add-lfs-blob-ids-to-tree-type' into 'master'Filipa Lacerda2019-06-111-0/+23
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add LFS blob IDs to GraphQL tree type See merge request gitlab-org/gitlab-ce!28666
| * | | | | | Add LFS blob ID to GraphQL blob typePhil Hughes2019-06-101-0/+23
| | |/ / / / | |/| | | |
* | | | | | Merge branch 'sh-fix-utf-8-encoding-resolve-conflicts' into 'master'Dmitriy Zaporozhets2019-06-111-1/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix UTF-8 conversion issues when resolving conflicts Closes #63062 See merge request gitlab-org/gitlab-ce!29453
| * | | | | | Force source and target branch to binary modesh-fix-utf-8-encoding-resolve-conflictsStan Hu2019-06-101-8/+15
| | | | | | |
| * | | | | | Fix UTF-8 conversion issues when resolving conflictsStan Hu2019-06-101-1/+13
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to https://gitlab.com/gitlab-org/gitlab-ce/issues/63030, when the commit message in the /resolve_conflicts endpoint contains a UTF-8 character, the conversion to the Gitaly ASCII-8BIT value may flag an error. To fix this, we run `force_encoding` on the commit message. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63062
* | | | | | Avoid encoding errors for MergeToRefServiceosw-avoid-encoding-errors-on-merge-to-ref-serviceOswaldo Ferreira2019-06-101-0/+18
| | | | | |
* | | | | | Add metric for measuring PumaWorkerKiller activityJan Provaznik2019-06-101-0/+27
| |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | PumaWorkerKiller is used for periodically checking and killing workers (the biggest one) if overall memory reaches specified limit. This metric allows us to watch number of killed workers.
* | | | | Merge branch '33064-add-labels-to-note-event-payload' into 'master'Sean McGivern2019-06-101-0/+2
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | Adding labels to note event payload. Closes #33064 See merge request gitlab-org/gitlab-ce!29384
| * | | | Adding labels to note event payload.Sujay Patel2019-06-101-0/+2
| | | | |
View Lorry Controller Status