summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab
Commit message (Collapse)AuthorAgeFilesLines
* Replace rails_helper.rb with spec_helper.rb66741-remove-spec-rails_helper-rbAsh McKenzie2019-08-3028-28/+28
| | | | | rails_helper.rb's only logic was to require spec_helper.rb.
* Merge branch 'mk/simplify-internal-post-receive-messages' into 'master'Grzegorz Bizon2019-08-291-0/+121
|\ | | | | | | | | | | | | Simplify internal post receive messages Closes #59808 See merge request gitlab-org/gitlab-ce!31640
| * Simplify internal post receive messagesmk/simplify-internal-post-receive-messagesMichael Kozono2019-08-281-0/+121
| | | | | | | | | | | | | | | | Instead of sending varied data to Gitaly, and making Gitaly construct various messages, build the messages first and have Gitaly print either basic messages or alert messages, in the order they come. Depends on https://gitlab.com/gitlab-org/gitaly/merge_requests/1410
* | Merge branch 'performance-bar-warnings' into 'master'Stan Hu2019-08-291-0/+29
|\ \ | |/ |/| | | | | Add warnings to performance bar response See merge request gitlab-org/gitlab-ce!31054
| * Add top-level warnings key to performance bar responseperformance-bar-warningsSean McGivern2019-08-281-0/+29
| | | | | | | | | | | | This key is useful to reduce the amount of logic needed on the frontend: if `has_warnings` is true, then the frontend knows that the request in question has warnings for some metric.
* | Save board lists collapsed settingFelipe Artur2019-08-281-0/+1
| | | | | | | | Persists if a board list is collapsed for each user.
* | Support Gitaly feature flags in workhorseJacob Vosmaer2019-08-281-0/+13
| |
* | Merge branch 'sh-fix-issue-move-api' into 'master'Grzegorz Bizon2019-08-281-0/+17
|\ \ | | | | | | | | | | | | | | | | | | Fix moving issues API failing when text includes commit URLs Closes #66666 See merge request gitlab-org/gitlab-ce!32317
| * | Fix moving issues API failing when text includes commit URLssh-fix-issue-move-apiStan Hu2019-08-281-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a issue is moved from one project to another, all associated Markdown text is rewritten in the context of the new project. If the note contained a link to a commit URL, `CommitRewriter#rewrite` would fail because `Commit#link_reference_pattern` would match `nil` `commit` values in the HTML generated from the Markdown. These `nil` values were passed along to `Project#commits_by` because `Commit#reference_valid?` was always returning `true`. To prevent this issue from happening, we tighten up the check for `Commit#reference_valid?` to look for valid SHA values. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66666
* | | Changes snowplow to use cookies for sessionsJeremy Jackson2019-08-282-45/+88
|/ / | | | | | | | | This also restructures how and where the configuration for Snowplow lives.
* | Fix a nil error in Gitlab::Danger::TeammateRémy Coutable2019-08-271-0/+8
|/ | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch ↵Lin Jen-Shin2019-08-271-1/+1
|\ | | | | | | | | | | | | | | | | '65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master' Detect the new stage labels in `Gitlab::Danger::Teammate` Closes #65312 See merge request gitlab-org/gitlab-ce!32261
| * Detect the new stage labels in Gitlab::Danger::Teammate65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewersRémy Coutable2019-08-271-1/+1
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch '13806-fix' into 'master'Lin Jen-Shin2019-08-271-0/+11
|\ \ | |/ |/| | | | | | | | | Add nil check for Gitlab.config.prometheus Closes #13806 See merge request gitlab-org/gitlab-ce!32201
| * Add nil check for Gitlab.config.prometheus13806-fixrpereira22019-08-261-0/+11
| |
* | Update docs and comments about saml with allow_bypass_two_factordodocat2019-08-271-4/+18
| | | | | | | | allow_bypass_two_factor configration dose not work with saml provider
* | Revert "Merge branch 'user-tracking-settings' into 'master'"Jeremy Jackson2019-08-262-88/+45
| | | | | | | | This reverts merge request !31826
* | Changes snowplow to use cookies for sessionsJeremy Jackson2019-08-262-45/+88
| | | | | | | | | | This also restructures how and where the configuration for Snowplow lives.
* | Replace echo function with a resolverBrett Walker2019-08-262-3/+9
| | | | | | | | | | The `GraphQL::Function` has been deprecated in favor of resolvers.
* | Change default visibility level for FogBugz imported projects to PrivateGeorge Koltsov2019-08-261-0/+29
| |
* | Add usage pings for merge request creatingIgor2019-08-262-0/+10
| | | | | | | | Code Review Usage Ping for Create SMAU
* | Merge branch 'db_load_balancing_service_discovery_srv' into 'master'Kamil Trzciński2019-08-261-0/+11
|\ \ | | | | | | | | | | | | DB Load Balancing: Support SRV lookups See merge request gitlab-org/gitlab-ce!32135
| * | CE port: allow SRV records in DB service discoverydb_load_balancing_service_discovery_srvTiger2019-08-231-0/+11
| | |
* | | Add helper to exactly undo cleanup_concurrent_column_renameReuben Pereira2019-08-251-0/+106
| |/ |/| | | | | - Also add helper to undo rename_column_concurrently.
* | Drop existing trigger before creating new oneReuben Pereira2019-08-241-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - When renaming a column concurrently, drop any existing trigger before attempting to create a new one. When running migration specs multiple times (as it happens during local development), the down method of previous migrations are called. If any of the called methods contains a call to rename_column_concurrently, a trigger will be created and not removed. So, the next time a migration spec is run, if the same down method is executed again, it will cause an error when attempting to create the trigger (since it already exists). Dropping the trigger if it already exists will prevent this problem.
* | Add a link to docs in project descriptionReuben Pereira2019-08-231-0/+267
| | | | | | | | Add to the service and migration both.
* | Implement validation logic to ProjectStageAdam Hegyi2019-08-231-0/+10
| | | | | | | | | | | | - Introducting StageEvents to define the available events - Define the event pairing rules, since some events are not compatible - Express default Cycle Analytics stages with the event structure
* | Handle when server info doesn't have the storage in questionJohn Cai2019-08-231-0/+10
| |
* | Merge branch 'frozen_string_lib_2' into 'master'Nick Thomas2019-08-23168-1/+336
|\ \ | | | | | | | | | | | | Add frozen_string_literal to lib part 2 See merge request gitlab-org/gitlab-ce!32094
| * | Fix frozen string errorsThong Kuah2019-08-231-1/+1
| | |
| * | Add frozen_string_literal to lib part 2Thong Kuah2019-08-23168-0/+335
| | | | | | | | | | | | | | | Using the sed script from https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
* | | Exempt `jwt/auth` for user `gitlab-ci-token` from rate limitingMarius Bobin2019-08-231-2/+2
| |/ |/|
* | Expose namespace storage statistics with GraphQLAlessio Caiazza2019-08-221-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Root namespaces have storage statistics. This commit allows namespace owners to get those stats via GraphQL queries like the following one { namespace(fullPath: "a_namespace_path") { rootStorageStatistics { storageSize repositorySize lfsObjectsSize buildArtifactsSize packagesSize wikiSize } } }
* | Log time spent on CPU to sidekiq.logBalakumar2019-08-221-1/+36
| |
* | Merge branch 'feat/smime-signed-notification-emails' into 'master'Sean McGivern2019-08-224-3/+155
|\ \ | |/ |/| | | | | feat: smime signed notification emails See merge request gitlab-org/gitlab-ce!30644
| * feat: SMIME signed notification emailsDiego Louzán2019-08-204-3/+155
| | | | | | | | | | | | - Add mail interceptor the signs outgoing email with SMIME - Add lib and helpers to work with SMIME data - New configuration params for setting up SMIME key and cert files
* | Merge branch 'sidekiq-interrupt-running-jobs-deadset' into 'master'Stan Hu2019-08-211-1/+9
|\ \ | | | | | | | | | | | | Put cancelled job in DeadSet See merge request gitlab-org/gitlab-ce!32070
| * | Put cancelled job in DeadSetsidekiq-interrupt-running-jobs-deadsetKamil Trzciński2019-08-211-1/+9
| | | | | | | | | | | | | | | This replicates Sidekiq behavior of pushing dead job into DeadSet.
* | | Ensure CI matching operator receives an objectMarius Bobin2019-08-212-0/+56
|/ / | | | | | | | | Ensure the evaluation of right-hand side expression always results in the returning of an object or an empty String
* | Properly handle `sidekiq` skipsidekiq-interrupt-running-jobsKamil Trzciński2019-08-212-7/+19
| | | | | | | | Transform `CancelledError` into `JobRetry::Skip`
* | Improve resillency of monitorKamil Trzciński2019-08-212-15/+90
| | | | | | | | | | | | | | - Retry connection when it fails - Properly shutdown daemon - Stop monitor if the Exception is raised - Properly guard exception handling
* | Perform cheap thread findKamil Trzciński2019-08-211-3/+1
| | | | | | | | | | | | | | | | If we process message that is not designated to us previously we would fire a separate Thread for that. We don't need to do it. We can cheaply check if thread is available, if it is, we can perform expensive operation then.
* | Rework `Sidekiq::JobsThreads` into `Monitor`Kamil Trzciński2019-08-213-83/+235
| | | | | | | | | | | | | | | | | | | | This makes: - very shallow `Middleware::Monitor` to only request tracking of sidekiq jobs, - `SidekiqStatus::Monitor` to be responsible to maintain persistent connection to receive messages, - `SidekiqStatus::Monitor` to always use structured logging and instance variables
* | Allow to interrupt running jobsKamil Trzciński2019-08-211-0/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a middleware to track all threads for running jobs. This makes sidekiq to watch for redis-delivered notifications. This makes be able to send notification to interrupt running sidekiq jobs. This does not take into account any native code, as `Thread.raise` generates exception once the control gets back to Ruby. The separate measure should be taken to interrupt gRPC, shellouts, or anything else that escapes Ruby.
* | Introducing new Syntax for Ci::Build inclusion rulesdrew2019-08-209-19/+1080
| | | | | | | | | | | | | | | | - Added Gitlab::Ci::Config::Entry::Rules and Gitlab::Ci::Config::Entry::Rules:Rule to handle lists of Rule objects to be evalauted for job inclusion - Added `if:` and `changes:` as available Rules::Rule::Clause classes - Added Rules handling logic to Seed::Build#included? with extra specs - Use DisallowedKeysValidator to mutually exclude rules: from only:/except: on job config
* | Standardize remote_ip and path keys for auth.log and api_json.logStan Hu2019-08-201-2/+2
| | | | | | | | | | | | | | | | Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses `remote_ip` and `path` for the same fields. Let's standardize these namings to make it easier for people working with the data. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
* | Merge branch 'bvl-mr-commit-note-counter' into 'master'Douwe Maan2019-08-202-10/+24
|\ \ | | | | | | | | | | | | Count notes for commits and merge requests See merge request gitlab-org/gitlab-ce!31912
| * | Count comments on notes and merge requestsBob Van Landuyt2019-08-162-10/+24
| | | | | | | | | | | | | | | This extends our existing `Gitlab::UsageDataCounters::NoteCounter` to also count notes on commits and merge requests
* | | Allow measurement for Sidekiq jobs taking > 2.5sAndrew Newdigate2019-08-201-1/+1
| | | | | | | | | | | | Fix for https://gitlab.com/gitlab-org/gitlab-ce/issues/66319.
* | | Add support for sentry_extra_data in exceptionsAlex Kalderimis2019-08-191-2/+27
| | | | | | | | | | | | | | | This allows exceptions to advertise their support for sentry and provide structured data.