summaryrefslogtreecommitdiff
path: root/spec/lib
Commit message (Collapse)AuthorAgeFilesLines
* Decouple more of Repository from RuggedJacob Vosmaer (GitLab)2018-01-301-0/+25
|
* Merge branch '41972-make-sure-no-warnings' into 'master'Robert Speicher2018-01-292-2/+153
|\ | | | | | | | | | | | | Fail static-analysis if there's output to stderr Closes #41972 See merge request gitlab-org/gitlab-ce!16648
| * Use Process::Status rather than an integerLin Jen-Shin2018-01-262-9/+9
| | | | | | | | However keep backward compatibility
| * Fail static-analysis if there's output to stderrLin Jen-Shin2018-01-262-2/+153
| | | | | | | | TODO: fix offenders
* | Don't allow Repository#log with limit zeroJacob Vosmaer (GitLab)2018-01-291-0/+10
| |
* | fix specJames Lopez2018-01-261-1/+1
| |
* | add an extra specJames Lopez2018-01-261-1/+5
| |
* | fix validation error on servicesJames Lopez2018-01-261-1/+1
|/
* Fix rubocop offenses introduced in !16623Ahmad Sherif2018-01-251-2/+7
|
* Merge branch 'feature/migrate-repo-restorer-to-gitaly' into 'master'Robert Speicher2018-01-251-0/+36
|\ | | | | | | | | | | | | Migrate restoring repo from bundle to Gitaly Closes gitaly#946 See merge request gitlab-org/gitlab-ce!16623
| * Migrate restoring repo from bundle to Gitalyfeature/migrate-repo-restorer-to-gitalyAhmad Sherif2018-01-241-0/+36
| | | | | | | | Closes gitaly#946
* | Merge branch 'lint-rugged' into 'master'Rémy Coutable2018-01-251-3/+3
|\ \ | | | | | | | | | | | | Add a lint check to restrict use of Rugged See merge request gitlab-org/gitlab-ce!16656
| * | Look for rugged with static analysislint-ruggedJacob Vosmaer2018-01-251-3/+3
| | |
* | | Merge branch 'fix/batch-lfs-pointers-accepting-lazy-enum' into 'master'Grzegorz Bizon2018-01-251-0/+15
|\ \ \ | |/ / |/| | | | | | | | Fix .batch_lfs_pointers accepting a lazy enumerator See merge request gitlab-org/gitlab-ce!16701
| * | Fix .batch_lfs_pointers accepting a lazy enumeratorfix/batch-lfs-pointers-accepting-lazy-enumAhmad Sherif2018-01-251-0/+15
| | |
* | | Merge branch 'revert-430b3f0e' into 'master'Douwe Maan2018-01-251-0/+38
|\ \ \ | | | | | | | | | | | | | | | | Revert "Merge branch 'remove-rugged-walk' into 'master'" See merge request gitlab-org/gitlab-ce!16676
| * | | Revert "Merge branch 'remove-rugged-walk' into 'master'"revert-430b3f0eJacob Vosmaer (GitLab)2018-01-251-0/+38
| |/ / | | | | | | This reverts merge request !16525
* | | Merge branch 'jej/gitattributes-check-at-ref' into 'master'Rémy Coutable2018-01-253-25/+99
|\ \ \ | |/ / |/| | | | | | | | Can parse root .gitattributes file for a ref See merge request gitlab-org/gitlab-ce!16418
| * | Can parse root .gitattributes file for a refjej/gitattributes-check-at-refJames Edwards-Jones2018-01-243-25/+99
| | |
* | | Merge branch ↵Rémy Coutable2018-01-251-0/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '42161-gitaly-commitservice-encoding-undefinedconversionerror-u-c124-from-utf-8-to-ascii-8bit' into 'master' Resolve "Gitaly::CommitService: Encoding::UndefinedConversionError: U+C124 from UTF-8 to ASCII-8BIT" Closes #42161 See merge request gitlab-org/gitlab-ce!16637
| * | | Make sure we're passing ASCII-8BIT to Gitaly42161-gitaly-commitservice-encoding-undefinedconversionerror-u-c124-from-utf-8-to-ascii-8bitLin Jen-Shin2018-01-231-0/+23
| | | | | | | | | | | | | | | | when counting commit count.
* | | | Add a gRPC health check to ensure Gitaly is upsh-add-gitaly-health-checkStan Hu2018-01-243-0/+123
| | | | | | | | | | | | | | | | | | | | | | | | This will enable Geo to skip shards that not operational. Relates to gitlab-org/gitlab-ee#4329
* | | | Merge branch 'search-100' into 'master'Yorick Peterse2018-01-241-0/+58
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Use limit for search count queries See merge request gitlab-org/gitlab-ce!16502
| * | | | Use limit for search count queriessearch-100Jan Provaznik2018-01-231-0/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Search query is especially slow if a user searches a generic string which matches many records, in such case search can take tens of seconds or time out. To speed up the search query, we search only for first 1000 records, if there is >1000 matching records we just display "1000+" instead of precise total count supposing that with such amount the exact count is not so important for the user. Because for issues even limited search was not fast enough, 2-phase approach is used for issues: first we use simpler/faster query to get all public issues, if this exceeds the limit, we just return the limit. If the amount of matching results is lower than limit, we re-run more complex search query (which includes also confidential issues). Re-running the complex query should be fast enough in such case because the amount of matching issues is lower than limit. Because exact total_count is now limited, this patch also switches to to "prev/next" pagination. Related #40540
* | | | | Merge branch '40744-idempotent-ids' into 'master'Robert Speicher2018-01-246-7/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the DatabaseCleaner 'deletion' strategy instead of 'truncation' Closes #30783 See merge request gitlab-org/gitlab-ce!16516
| * | | | | Use the DatabaseCleaner 'deletion' strategy instead of 'truncation'Nick Thomas2018-01-246-7/+7
| | |_|_|/ | |/| | |
* | | | | Migrate .batch_lfs_pointers to Gitalyfeature/migrate-get-lfs-ptrs-to-gitalyAhmad Sherif2018-01-241-15/+28
|/ / / / | | | | | | | | | | | | Closes gitaly#921
* | | | Migrate repository bundling to Gitalyfeature/migrate-bundle-to-disk-to-gitalyAhmad Sherif2018-01-241-0/+28
|/ / / | | | | | | | | | Closes gitaly#929
* | | Fix a migration spec messing up the MergeRequestDiff DB schema42340-ci-failing-on-mergerequestdiff-commits_countRémy Coutable2018-01-231-0/+4
| | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | Merge branch 'gitaly-update-remote-mirror' into 'master'Rémy Coutable2018-01-231-0/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Incorporate Gitaly's RemoteService.UpdateRemoteMirror RPC Closes gitaly#936 See merge request gitlab-org/gitlab-ce!16536
| * | | Incorporate Gitaly's RemoteService.UpdateRemoteMirror RPCgitaly-update-remote-mirrorAlejandro Rodríguez2018-01-221-0/+14
| | | |
* | | | Merge branch 'gitaly-user-commit-files' into 'master'Douwe Maan2018-01-231-0/+3
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | Incorporate Gitaly's OperationService.UserCommitFiles RPC Closes gitaly#890 See merge request gitlab-org/gitlab-ce!16307
| * | | Ensure hooks are deleted regardless of the project forking methodAlejandro Rodríguez2018-01-191-0/+3
| | | |
* | | | Merge branch 'add-profiler-to-application' into 'master'Stan Hu2018-01-221-0/+156
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add Gitlab::Profiler for profiling from a console or runner See merge request gitlab-org/gitlab-ce!16552
| * | | | Add Gitlab::Profiler for profiling from a console or runnerSean McGivern2018-01-191-0/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gitlab::Profiler.profile takes a URL to profile, and returns the ruby-prof profile result. This is currently only for interactive use (in a console) or from the script runner. Note that when using this interactively, changes to the application within that console session will be used, so this can be used to test proposed performance changes.
* | | | | Fix Error 500 when repository has no avatarsh-fix-error-500-no-avatarsStan Hu2018-01-201-0/+12
| |_|/ / |/| | | | | | | | | | | Closes #42249
* | | | Merge branch '42159-utf8-uploads' into 'master'Douwe Maan2018-01-191-8/+9
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | Correctly escape UTF-8 path elements for uploads Closes #42159 See merge request gitlab-org/gitlab-ce!16560
| * | | Correctly escape UTF-8 path elements for uploadsNick Thomas2018-01-181-8/+9
| | | |
* | | | Merge branch 'background-migration-fix' into 'master'Douwe Maan2018-01-181-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | Reduce UPDATEs for background column type changes Closes #42158 See merge request gitlab-org/gitlab-ce!16551
| * | | Reduce UPDATEs for background column type changesbackground-migration-fixYorick Peterse2018-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit we would essentially update all rows in a table, even those where the source column (e.g. `issues.closed_at`) was NULL. This in turn could lead to statement timeouts when using the default batch size of 10 000 rows per job. To work around this we don't schedule jobs for rows where the source value is NULL. We also don't update rows where the source column is NULL (as an extra precaution) or the target column already has a non-NULL value. Using this approach it should be possible to update 10 000 rows in the "issues" table in about 7.5 - 8 seconds. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/42158
* | | | Merge branch 'gitaly-commit-signature' into 'master'Sean McGivern2018-01-183-14/+92
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Retrieve commit signatures with Gitaly Closes gitaly#923 See merge request gitlab-org/gitlab-ce!16467
| * | | | Retrieve commit signatures with GitalyJacob Vosmaer (GitLab)2018-01-183-14/+92
| |/ / /
* | | | Remove Rugged::Walker from Repository#logJacob Vosmaer (GitLab)2018-01-181-38/+0
|/ / /
* | | Merge branch 'sh-backport-10-3-4-security-fixes' into 'master'Oswaldo Ferreira2018-01-176-29/+181
|\ \ \ | |/ / |/| | | | | | | | Backport 10.3.4 security fixes into master See merge request gitlab-org/gitlab-ce!16509
| * | Make ruby lint happysh-backport-10-3-4-security-fixesOswaldo Ferreira2018-01-171-2/+2
| | |
| * | Merge branch 'fix/import-rce-10-3' into 'security-10-3'James Lopez2018-01-161-13/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [10.3] Fix RCE via project import mechanism See merge request gitlab/gitlabhq!2294 (cherry picked from commit dcfec507d6f9ee119d65a832393e7c593af1d3b2) 86d75812 Fix RCE via project import mechanism
| * | Merge branch ↵Robert Speicher2018-01-161-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '41293-fix-command-injection-vulnerability-on-system_hook_push-queue-through-web-hook' into 'security-10-3' Don't allow line breaks on HTTP headers See merge request gitlab/gitlabhq!2277 (cherry picked from commit 7fc0a6fc096768a5604d6dd24d7d952e53300c82) 073b8f9c Don't allow line breaks on HTTP headers
| * | Merge branch 'sh-migrate-can-push-to-deploy-keys-projects-10-3' into ↵Douwe Maan2018-01-162-12/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'security-10-3' [10.3] Migrate `can_push` column from `keys` to `deploy_keys_project` See merge request gitlab/gitlabhq!2276 (cherry picked from commit f6ca52d31bac350a23938e0aebf717c767b4710c) 1f2bd3c0 Backport to 10.3
| * | Merge branch 'ac/fix-path-traversal' into 'security-10-3'Robert Speicher2018-01-161-0/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [10.3] Fix path traversal in gitlab-ci.yml cache:key See merge request gitlab/gitlabhq!2270 (cherry picked from commit c32d0c6807dfd41d7838a35742e6d0986871b389) df29094a Fix path traversal in gitlab-ci.yml cache:key
| * | Merge branch 'ac/41346-xss-ci-job-output' into 'security-10-3'Robert Speicher2018-01-161-4/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [10.3] Fix XSS vulnerability in Pipeline job trace See merge request gitlab/gitlabhq!2258 (cherry picked from commit 44caa80ed9a2514a74a5eeab10ff51849d64851b) 5f86f3ff Fix XSS vulnerability in Pipeline job trace