summaryrefslogtreecommitdiff
path: root/spec/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'georgekoltsov/64377-add-better-log-msg-to-members-mapper' into ↵Ash McKenzie2019-07-231-0/+10
|\ | | | | | | | | | | | | 'master' Add better error message to MembersMapper#ensure_default_member! See merge request gitlab-org/gitlab-ce!30838
| * Add MembersMapper#ensure_default_user! specGeorge Koltsov2019-07-171-0/+10
| |
* | Bring backward compatibility for request profilesKamil Trzciński2019-07-232-7/+93
| | | | | | | | | | | | | | | | | | | | | | | | It seems that we missed the backward compatibility support for profiles in the existing folder. This commit also fixes some specs to be idempotent and work in a temporary directory which not always seems to be the case. This commit also brings the profile_spec.rb which seems to be missing.
* | Merge branch 'resolve-remaining-import-export-differences' into 'master'Robert Speicher2019-07-223-2/+9
|\ \ | | | | | | | | | | | | Resolve remaining import export differences See merge request gitlab-org/gitlab-ce!31012
| * | Backport import/export spec changes from EEresolve-remaining-import-export-differencesYorick Peterse2019-07-222-1/+7
| | | | | | | | | | | | This backports remaining import/export spec changes from EE to CE.
| * | Backport project.json fixture from EEYorick Peterse2019-07-221-1/+2
| | | | | | | | | | | | | | | This backports all changes made to an import/export fixture file from EE to CE.
* | | Remove duplicate entry from all_models.ymlremove-duplicate-all-models-entryYorick Peterse2019-07-221-1/+0
|/ / | | | | | | | | This line is already present further down in the YAML file. In EE the line is already removed.
* | OAuth2 support for GitLab personal access tokensSteve Abrams2019-07-221-0/+14
| | | | | | | | | | | | PATs are accepted using the OAuth2 compliant header "Authorization: Bearer {token}" in order to allow for OAuth requests while 2FA is enabled.
* | Count wiki page creationAlex Kalderimis2019-07-213-10/+119
| | | | | | | | | | | | | | This adds a counter to count page creation, which is reflected in the usage-data we collect. The number created is stored in Redis, avoiding DB access.
* | Merge branch 'sh-fix-gitaly-server-info-cache' into 'master'Mayra Cabrera2019-07-191-0/+13
|\ \ | | | | | | | | | | | | | | | | | | Fix Gitaly auto-detection caching Closes #64802 See merge request gitlab-org/gitlab-ce!30954
| * | Fix Gitaly auto-detection cachingStan Hu2019-07-191-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | If `GitalyClient#can_use_disk?` returned `false`, it was never cached properly and led to excessive number of Gitaly calls. Instead of using `cached_value.present?`, we need to check `cached_value.nil?`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64802
* | | Document database review processToon Claes2019-07-191-0/+30
| | | | | | | | | | | | See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
* | | Avoid increasing redis counters when usage_ping is disabledFrancisco Javier López2019-07-191-0/+33
|/ /
* | Adjust redis cache metricsBen Kochie2019-07-191-1/+9
| | | | | | | | | | | | * Remove `controller` and `action` labels from duration histogram. * Create a new simple counter for `controller` and `action`. * Adjust histogram buckets to observe smaller response times.
* | Added Usage Data for some Web IDE actionsFrancisco Javier López2019-07-192-10/+35
| | | | | | | | | | | | | | The actions tracked in the web IDE are: - creation of commits - creation of merge requests - projects loaded
* | Merge branch '64295-predictable-environment-slugs' into 'master'Lin Jen-Shin2019-07-191-0/+38
|\ \ | | | | | | | | | | | | Use predictable environment slugs See merge request gitlab-org/gitlab-ce!30551
| * | Introduce predictable environment slugs64295-predictable-environment-slugsTiger2019-07-191-0/+38
| | | | | | | | | | | | | | | | | | | | | If an environment slug is predictable given only the environment name, we can use the environment slug earlier in the CI variable evaluation process as we don't have to wait for the environment record itself to be persisted.
* | | Set Private visibility for restricted Internal imported projectsGeorge Koltsov2019-07-191-0/+20
|/ / | | | | | | | | | | | | | | | | With https://gitlab.com/gitlab-org/gitlab-ee/issues/12388 change going live there is potential risk of breaking imports of 'Internal' projects. This change makes sure if 'Internal' visibility level is restricted all 'Internal' projects will be marked as 'Private' See: https://gitlab.com/gitlab-org/gitlab-ce/issues/64311
* | Improves add_timestamps_with_timezone helperAlex Kalderimis2019-07-181-3/+74
| | | | | | | | | | | | | | | | | | This improves the `add_timestamps_with_timezone` helper by allowing the column names to be configured. This has the advantage that unnecessary columns can be avoided, saving space. A helper for removing the columns is also provided, to be used in the `down` method of migrations.
* | Merge branch 'sh-add-rugged-logs' into 'master'Douglas Barbosa Alexandre2019-07-181-0/+27
|\ \ | | | | | | | | | | | | | | | | | | Add Rugged calls and duration to API and Rails logs Closes #64676 See merge request gitlab-org/gitlab-ce!30871
| * | Add Rugged calls and duration to API and Rails logsStan Hu2019-07-181-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | This adds `rugged_duration_ms` and `rugged_calls` fields to `api_json.log` and `production_json.log`. This will make it easier to identify performance issues caused by excessive I/O. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64676
* | | Fix pid providing for PrometheusAleksei Lipniagov2019-07-181-0/+79
| | | | | | | | | | | | | | | | | | | | | Use relative worker identifier for metrics (instead of Process.pid) and identify when Unicorn/Puma/Sidekiq is used. Previously, it was assumed that all metrics are gathered from Unicorn due to hardcoded implementation which was incorrect.
* | | Merge branch 'sh-fix-redis-performance-bar' into 'master'Mayra Cabrera2019-07-181-11/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix inconsistency in Redis performance bar stats Closes #64707 See merge request gitlab-org/gitlab-ce!30866
| * | | Fix inconsistency in Redis performance bar statssh-fix-redis-performance-barStan Hu2019-07-171-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | peek-redis resets its counters at the start of an ActionController notification (`start_processing.action_controller`), which causes it to miss some Redis queries that precede it, such as the database load balancer and Rack Attack queries. This produces inconsistencies in the performance bar between the number of calls and their durations with the actual calls in the detailed view. We fix this by getting rid of peek-redis in favor of consolidating all logic into the `RedisDetailed` view, which tracks Redis queries using `RequestStore`. This has the nice property of removing thread-specific counters as well. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64707
* | | | Merge branch 'webide-commit-use-correct-parent' into 'master'Nick Thomas2019-07-181-0/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Use correct parent when committing in WebIDE See merge request gitlab-org/gitlab-ce!29598
| * | | | Add start_sha to commits APIMarkus Koller2019-07-181-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When passing start_branch on committing from the WebIDE, it's possible that the branch has changed since editing started, which results in the change being applied on top of the latest commit in the branch and overwriting the new changes. By passing the start_sha instead we can make sure that the change is applied on top of the commit which the user started editing from.
* | | | | Merge branch 'adjust-cycle-analytics-to-group-level' into 'master'Sean McGivern2019-07-1811-56/+437
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | Adjust cycle analytics to group level See merge request gitlab-org/gitlab-ce!30391
| * | | | Add code review remarksMałgorzata Ksionek2019-07-161-24/+22
| | | | | | | | | | | | | | | | | | | | Change small things for better readability
| * | | | Add timecop remarksMałgorzata Ksionek2019-07-161-30/+54
| | | | |
| * | | | Add code review remarksMałgorzata Ksionek2019-07-167-61/+57
| | | | | | | | | | | | | | | | | | | | Make specs more readable
| * | | | Fix test stage specsMałgorzata Ksionek2019-07-151-2/+2
| | | | |
| * | | | Add class for group level analyticsMałgorzata Ksionek2019-07-1510-42/+405
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add specs for group level Update entities Update base classes Add groups-centric changes Update plan and review stage Add summary classes Add summary spec Update specs files Add to specs test cases for group Add changelog entry Add group serializer Fix typo Fix typo Add fetching namespace in sql query Update specs Add rubocop fix Add rubocop fix Modify method to be in sync with code review Add counting deploys from subgroup To group summary stage Add subgroups handling In group stage summary Add additional spec Add additional specs Add more precise inheritance Add attr reader to group level Fix rubocop offence Fix problems with specs Add cr remarks Renaming median method and a lot of calls in specs Move spec setup Rename method in specs Add code review remarks regarding module Add proper module name
* | | | | Refactor RedisCounter and WebIdeCommitsCounterFrancisco Javier López2019-07-172-54/+21
| | | | | | | | | | | | | | | | | | | | | | | | | This MR refactor RedisCounter and WebIdeCommitsCounter to be reused by other components.
* | | | | Merge branch 'jc-wrap-rugged-calls-with-disk-access' into 'master'Stan Hu2019-07-172-3/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Wrap rugged calls with access disk block See merge request gitlab-org/gitlab-ce!30592
| * | | | | Wrap rugged calls with access disk blockjc-wrap-rugged-calls-with-disk-accessJohn Cai2019-07-162-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever we use the rugged implementation, we are going straight to disk so we want to bypass the disk access check.
* | | | | | Add tests for when deploy token usernames are not uniqueKrasimir Angelov2019-07-171-0/+64
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | Ensure correct behaviour when deploy tokens have the same username or deploy token and user have the same username.
* | | | | Merge branch 'issue-64645-asciidoctor-footnote-links' into 'master'Nick Thomas2019-07-171-0/+50
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | Preserve footnote link ids Closes #64645 See merge request gitlab-org/gitlab-ce!30790
| * | | | Preserve footnote link idsGuillaume Grossetie2019-07-171-0/+50
| | | | |
* | | | | Added submodule links to Submodule type in GraphQL APIIgor2019-07-172-0/+46
| |_|_|/ |/| | | | | | | | | | | This is part of migration of Folder View to Vue
* | | | Fetch latest link in the description for zoom link, add more tests and ↵Rajendra kadam2019-07-171-0/+24
| | | | | | | | | | | | | | | | remove frontend spec unnecessary tests
* | | | Merge branch 'ci-job-only-except-conflict-specs' into 'master'59381-cannot-show-closed-milestones-on-milestones-pageThong Kuah2019-07-161-62/+184
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Added specs for CI Job inclusion when only: and except: both match See merge request gitlab-org/gitlab-ce!30057
| * | | | Build instead of createci-job-only-except-conflict-specsdrew cimino2019-07-161-1/+1
| | | | |
| * | | | Polish for Ci::Pipeline::Seed::Build specsdrew cimino2019-07-111-62/+143
| | | | |
| * | | | Added specs for Ci::Pipeline::Seed::Builddrew cimino2019-07-111-8/+49
| | | | | | | | | | | | | | | | | | | | - #included? when only: and except: both match
* | | | | Rename Redactor classes to ReferenceRedactorSarah Yasonik2019-07-163-6/+6
| | | | |
* | | | | Refactored WebIdeCommitsCount classFrancisco Javier López2019-07-162-19/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're adding more redis base counters to the web ide and other classes. We're refactoring this class in other to use the logic in other places.
* | | | | Merge branch 'remove-support-for-legacy-pipeline-triggers' into 'master'Kamil Trzciński2019-07-163-4/+59
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | Remove support for legacy pipeline triggers Closes #30231 See merge request gitlab-org/gitlab-ce!30133
| * | | | Do not import legacy triggers from project JSONremove-support-for-legacy-pipeline-triggersFabio Pitino2019-07-152-3/+15
| | | | |
| * | | | Ensure ImportExport maintains trigger ownershipFabio Pitino2019-07-151-0/+1
| | | | |
| * | | | Allow use of legacy triggers with feature flagFabio Pitino2019-07-151-1/+43
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keep feature flag disabled by default and turn off all functionality related to legacy triggers. * Block legacy triggers from creating pipeline * Highlight legacy triggers to be invalid via the UI * Make legacy triggers invalid in the model
View Lorry Controller Status