| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously imports would fail if a merge request note included a
suggestion with an
`ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection`
exception.
This was happening because suggestions were listed as a descendant of
merge requests, but this doesn't work because suggestions are directly
associated with notes, not merge requests, and that association is lost.
Rails also disallows creating intializing a has_many association through
a different object.
We fix this by making `suggestions` a child of `notes` within a merge
request. This doesn't fix previously broken exported project exports,
but new exports will work.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65880
|
| |\
| |
| |
| |
| |
| |
| | |
Prevent rewritting plain links as embedded
Closes #58494
See merge request gitlab-org/gitlab-ce!31489
|
| | |
| |
| |
| |
| | |
Prevents rewritting plain image/video links as embedded when moving
issues.
|
| | |
| |
| |
| |
| |
| | |
Removes the feature flag that controls whether
metrics dashboard urls unfurl the metrics dashboard
charts.
|
| |\ \
| | |
| | |
| | |
| | | |
Revert "Merge branch '65152-selective-highlight' into 'master'"
See merge request gitlab-org/gitlab-ce!31643
|
| | | |
| | |
| | | |
This reverts merge request !31361
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix Sidekiq scheduling_latency_s
Closes #65748
See merge request gitlab-org/gitlab-ce!31650
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
This number was reporting a negative number because `current_time` was
a monotonic counter, not an absolute time.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65748
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will help identify Sidekiq jobs that invoke excessive number of
filesystem access.
The timing data is stored in `RequestStore`, but this is only active
within the middleware and is not directly accessible to the Sidekiq
logger. However, it is possible for the middleware to modify the job
hash to pass this data along to the logger.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
Remove KubernetesService integration
See merge request gitlab-org/gitlab-ce!31365
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Creating new records has been disabled, and all
existing records been migrated to clusters as of
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28534
|
| | | | |
|
| | | |
| | |
| | |
| | | |
As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593
|
| | | |
| | |
| | |
| | | |
Generalize wiki page counter for other page types to extend to.
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Makes section title clickable and collapsible
Closes #63181
See merge request gitlab-org/gitlab-ce!31571
|
| | | |
| | |
| | |
| | |
| | | |
In the job log, if the user clicks the section title
the job log section will be collapsed
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add missing report-uri to CSP config
See merge request gitlab-org/gitlab-ce!31593
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This is supported in Rails 5.2, although it may be
deprecated in the future by reports-to.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
- This will make it easy to identify the project even if admins change
the name of the project or move it.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/62971
Adds support to EnvironmentsController#metrics_dashboard
for the following params: group, title, y_label
These params are used to uniquely identify a panel on
the metrics dashboard.
Metrics are stored in several places, so this adds
utilities to find a specific panel from the database
or filesystem depending on the metric specified.
Also moves some shared utilities into separate classes,
notably default values and errors.
|
| |/ / /
| | |
| | |
| | | |
Squash this commit and reword before merging..
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add support for Content-Security-Policy
Closes #65330
See merge request gitlab-org/gitlab-ce!31402
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A nonce-based Content-Security-Policy thwarts XSS attacks by allowing
inline JavaScript to execute if the script nonce matches the header
value. Rails 5.2 supports nonce-based Content-Security-Policy headers,
so provide configuration to enable this and make it work.
To support this, we need to change all `:javascript` HAML filters to the
following form:
```
= javascript_tag nonce: true do
:plain
...
```
We use `%script` throughout our HAML to store JSON and other text, but
since this doesn't execute, browsers don't appear to block this content
from being used and require the nonce value to be present.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Kubernetes deployments on new clusters will now have
a separate namespace per project environment, instead
of sharing a single namespace for the project.
Behaviour of existing clusters is unchanged.
All new functionality is controlled by the
:kubernetes_namespace_per_environment feature flag,
which is safe to enable/disable at any time.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Closes #60024
- Change PrometheusClient.new to accept a base url instead of an
already created RestClient
- Use Gitlab::HTTP in PrometheusClient instead of creating RestClient
in PrometheusService
- Move http_options from PrometheusService to
PrometheusClient (follow_redirects: false)
- ensure that base urls don't have the trailing slash
- Created a `PrometheusClient#url` method that might not be strictly
required
- Change rescued exceptions from RestClient::* to
HTTParty::ResponseError where possible and StandardError for the
rest
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
Support selective highlighting of lines
See merge request gitlab-org/gitlab-ce!31361
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of highlighting all lines when not all of them are
needed, only highlight specific lines.
The `BlobPresenter#highlight` method has been updated to
support `since` and `to` params. These params will be used to
limit the content to be highlighted.
Modify `Gitlab::Highlight` to support `since` param which will
then be used to determine the starting line number.
|
| |\ \
| | |
| | |
| | |
| | | |
Make issue boards importable
See merge request gitlab-org/gitlab-ce!31434
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Added Importable to models/list.rb
- Did unless: :importable? on board validation
- Created changelog
- Modified haml to show issue boards are importable
- Added needed spec tests
- Modified project.json to include board information
- Added relevant models to all_models
- Added relevant models to import_export
- Added relevant models to safe_model_attributes
|
| | |/
|/| |
|
| |\ \
| |/
|/|
| |
| | |
Add outbound setting for system hooks
See merge request gitlab-org/gitlab-ce!31177
|
| | |
| |
| |
| |
| |
| | |
Simplify SystemHookUrlValidator to inherit from PublicUrlValidator
Refactor specs to move out shared examples to be used in both
system hooks and public url validators.
|
| | |
| |
| |
| |
| |
| |
| | |
This MR adds new application setting to network section
`allow_local_requests_from_system_hooks`. Prior to this change
system hooks were allowed to do local network requests by default
and we are adding an ability for admins to control it.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also creates specs
Only allow Helm to be uninstalled if it's the only app
- Remove Tiller leftovers after reser command
- Fixes specs and offenses
Adds changelog file
Fix reset_command specs
|
| |/
|
|
|
|
|
|
|
| |
This changes `needs:` from weak reference
to have a strong reference.
This means that job will not be created
unless all needs are present as part of
a pipeline.
|
| |
|
|
|
|
|
| |
Currently we write out empty CSS classes (`class=""`) every time we
create a new tag. This adds 9 unnecessary bytes per span element. In a
recent trace, I have counted 11950 span elements. So we transported 105
unnecessary kilobytes!
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, both InfluxSampler and RubySampler were relying on the
`GC::Profiler.total_time` data which is the sum over the list
of captured GC events. Also, both samplers asynchronously called
`GC::Profiler.clear` which led to incorrect metric data because
each sampler has the wrong assumption it is the only object who calls
`GC::Profiler.clear` and thus could rely on the gathered results between
such calls.
We should ensure that `GC::Profiler.total_time` is called only in one
place making it possible to rely on accumulated data between such wipes.
Also, we need to track the amount of profiler reports we lost.
|
| |\
| |
| |
| |
| | |
Add exclusive lease to mergeability check process
See merge request gitlab-org/gitlab-ce!31082
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Concurrent calls to UserMergeToRef RPC updating a single ref
can lead to an opaque fail that is being rescued at Gitaly.
So this commit adds an exclusive lease to the mergeability
check process with the key as the current MR ID.
|
| | |
| |
| |
| |
| |
| | |
This implements the support for `needs:` keyword
as part of GitLab CI. That makes some of the jobs
to be run out of order.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix SystemStackError when Peek bar is active with Rugged calls
Closes #65404
See merge request gitlab-org/gitlab-ce!31357
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Peek attempts to serialize results with `to_json`, which calls
`ActiveSupport::JSON`. If an object is passed to `to_json` that contains
instance variables, `ActiveSupport` will attempt to recursively traverse
all variables.
The problem is that we can get into an infinite loop if the instance
references to an instance that references to something else that points
back to the same instance.
To avoid this mess, we just call `to_s` on the object. It appears only
`Gitlab::Git::Repository` and `::Repository` are the culprits here.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65404
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add Feature.remove
Closes #65363
See merge request gitlab-org/gitlab-ce!31315
|
| | | |/
| |/| |
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
into 'master'
Resolve "Fix typo on clusters_applications_cert_managers factory"
Closes #65297
See merge request gitlab-org/gitlab-ce!31278
|
| | | |
| | |
| | |
| | |
| | | |
- the typo in this factory name was precluding us from properly
creating dynamic code to remove duplciation.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix sidekiq memory killer warning message
Closes gitlab-com/gl-infra/infrastructure#7371
See merge request gitlab-org/gitlab-ce!31264
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
undefined in prior stages
|
