| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Previously each tag in a push would invoke the Gitaly `FindAllTags` RPC
since the tag cache would be invalidated with every tag.
We can eliminate those extraneous calls by expiring the tag cache once
in `PostReceive` and taking advantage of the cached tags.
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/65795
|
|\
| |
| |
| |
| | |
Only expire branch cache once per push
See merge request gitlab-org/gitlab-ce!31653
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whenever `PostReceive` is enqueued, `UpdateMergeRequestsWorker`
is enqueued and `MergeRequests::RefreshService` is called, it'll
check if the source branch of each MR asssociated to the push exists
or not via `MergeRequest#source_branch_exists?`. The said method will
call `Repository#branch_exists?` which is cached in `Rails.cache`.
When the cache contains outdated data and the source branch actually
exists, the `MergeRequests#RefreshService` job will close associated
MRs which is not correct.
The fix is to expire the branches cache of the project so we have
updated data during the post receive hook which will help in the
accuracy of the check if we need to close associated MRs or not.
|
| |
| |
| |
| |
| |
| | |
Since we are unsure what would be the behavior of `stage:`
when we work on DAG. Let's make `stage:` to be required
today with `needs:`.
|
|\ \
| | |
| | |
| | |
| | | |
Load search result counts asynchronously (CE)
See merge request gitlab-org/gitlab-ce!31663
|
| | |
| | |
| | |
| | |
| | |
| | | |
Querying all counts for the different search results in the same request
led to timeouts, so we now only calculate the count for the *current*
search results, and request the others in separate asynchronous calls.
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Properly save suggestions in project exports
Closes #65880
See merge request gitlab-org/gitlab-ce!31690
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously imports would fail if a merge request note included a
suggestion with an
`ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection`
exception.
This was happening because suggestions were listed as a descendant of
merge requests, but this doesn't work because suggestions are directly
associated with notes, not merge requests, and that association is lost.
Rails also disallows creating intializing a has_many association through
a different object.
We fix this by making `suggestions` a child of `notes` within a merge
request. This doesn't fix previously broken exported project exports,
but new exports will work.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65880
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds highlight to collapsible line in job log
Closes #65790
See merge request gitlab-org/gitlab-ce!31665
|
| |/ /
| | |
| | |
| | |
| | | |
In the job log adds a highlight when hovering
the collapsible line
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Fix active metric files being wiped after the app starts
See merge request gitlab-org/gitlab-ce!31668
|
| |/ / |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Add author lines to project import comments
See merge request gitlab-org/gitlab-ce!31579
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Replace `username` field with `nickname` due to updates in
BitBucket Cloud API
- Add new imported spec validating addition of `authod_line`
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Prevent rewritting plain links as embedded
Closes #58494
See merge request gitlab-org/gitlab-ce!31489
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Prevents rewritting plain image/video links as embedded when moving
issues.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Removes the feature flag that controls whether
metrics dashboard urls unfurl the metrics dashboard
charts.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Revert "Merge branch '65152-selective-highlight' into 'master'"
See merge request gitlab-org/gitlab-ce!31643
|
| | | | |
| | | | |
| | | | | |
This reverts merge request !31361
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix Sidekiq scheduling_latency_s
Closes #65748
See merge request gitlab-org/gitlab-ce!31650
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This number was reporting a negative number because `current_time` was
a monotonic counter, not an absolute time.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65748
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This will help identify Sidekiq jobs that invoke excessive number of
filesystem access.
The timing data is stored in `RequestStore`, but this is only active
within the middleware and is not directly accessible to the Sidekiq
logger. However, it is possible for the middleware to modify the job
hash to pass this data along to the logger.
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Remove KubernetesService integration
See merge request gitlab-org/gitlab-ce!31365
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Creating new records has been disabled, and all
existing records been migrated to clusters as of
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28534
|
| |_|_|/
|/| | | |
|
| | | |
| | | |
| | | |
| | | | |
As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593
|
| | | |
| | | |
| | | |
| | | | |
Generalize wiki page counter for other page types to extend to.
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Makes section title clickable and collapsible
Closes #63181
See merge request gitlab-org/gitlab-ce!31571
|
| | | |
| | | |
| | | |
| | | |
| | | | |
In the job log, if the user clicks the section title
the job log section will be collapsed
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Add missing report-uri to CSP config
See merge request gitlab-org/gitlab-ce!31593
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
This is supported in Rails 5.2, although it may be
deprecated in the future by reports-to.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
- This will make it easy to identify the project even if admins change
the name of the project or move it.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/62971
Adds support to EnvironmentsController#metrics_dashboard
for the following params: group, title, y_label
These params are used to uniquely identify a panel on
the metrics dashboard.
Metrics are stored in several places, so this adds
utilities to find a specific panel from the database
or filesystem depending on the metric specified.
Also moves some shared utilities into separate classes,
notably default values and errors.
|
|/ / /
| | |
| | |
| | | |
Squash this commit and reword before merging..
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add support for Content-Security-Policy
Closes #65330
See merge request gitlab-org/gitlab-ce!31402
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A nonce-based Content-Security-Policy thwarts XSS attacks by allowing
inline JavaScript to execute if the script nonce matches the header
value. Rails 5.2 supports nonce-based Content-Security-Policy headers,
so provide configuration to enable this and make it work.
To support this, we need to change all `:javascript` HAML filters to the
following form:
```
= javascript_tag nonce: true do
:plain
...
```
We use `%script` throughout our HAML to store JSON and other text, but
since this doesn't execute, browsers don't appear to block this content
from being used and require the nonce value to be present.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Kubernetes deployments on new clusters will now have
a separate namespace per project environment, instead
of sharing a single namespace for the project.
Behaviour of existing clusters is unchanged.
All new functionality is controlled by the
:kubernetes_namespace_per_environment feature flag,
which is safe to enable/disable at any time.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Closes #60024
- Change PrometheusClient.new to accept a base url instead of an
already created RestClient
- Use Gitlab::HTTP in PrometheusClient instead of creating RestClient
in PrometheusService
- Move http_options from PrometheusService to
PrometheusClient (follow_redirects: false)
- ensure that base urls don't have the trailing slash
- Created a `PrometheusClient#url` method that might not be strictly
required
- Change rescued exceptions from RestClient::* to
HTTParty::ResponseError where possible and StandardError for the
rest
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
Support selective highlighting of lines
See merge request gitlab-org/gitlab-ce!31361
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of highlighting all lines when not all of them are
needed, only highlight specific lines.
The `BlobPresenter#highlight` method has been updated to
support `since` and `to` params. These params will be used to
limit the content to be highlighted.
Modify `Gitlab::Highlight` to support `since` param which will
then be used to determine the starting line number.
|
|\ \
| | |
| | |
| | |
| | | |
Make issue boards importable
See merge request gitlab-org/gitlab-ce!31434
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Added Importable to models/list.rb
- Did unless: :importable? on board validation
- Created changelog
- Modified haml to show issue boards are importable
- Added needed spec tests
- Modified project.json to include board information
- Added relevant models to all_models
- Added relevant models to import_export
- Added relevant models to safe_model_attributes
|
| |/
|/| |
|
|\ \
| |/
|/|
| |
| | |
Add outbound setting for system hooks
See merge request gitlab-org/gitlab-ce!31177
|
| |
| |
| |
| |
| |
| | |
Simplify SystemHookUrlValidator to inherit from PublicUrlValidator
Refactor specs to move out shared examples to be used in both
system hooks and public url validators.
|
| |
| |
| |
| |
| |
| |
| | |
This MR adds new application setting to network section
`allow_local_requests_from_system_hooks`. Prior to this change
system hooks were allowed to do local network requests by default
and we are adding an ability for admins to control it.
|