summaryrefslogtreecommitdiff
path: root/spec/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Merge branch 'dm-ldap-email-readonly' into 'master'Sean McGivern2017-12-152-13/+52
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure user email is read only when synced with LDAP Closes #41033 See merge request gitlab-org/gitlab-ce!15915
| * | | | | | | Make sure user email is read only when synced with LDAPDouwe Maan2017-12-152-13/+52
| | |_|_|_|_|/ | |/| | | | |
* | | | | | | Import gitlab_projects.rb from gitlab-shellNick Thomas2017-12-143-93/+492
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By importing this Ruby code into gitlab-rails (and gitaly-ruby), we avoid 200ms of startup time for each gitlab_projects subprocess we are eliminating. By not having a gitlab_projects subprocess between gitlab-rails / sidekiq and any git subprocesses (e.g. for fork_project, fetch_remote, etc, calls), we can also manage these git processes more cleanly, and avoid sending SIGKILL to them
* | | | | | Merge branch 'dm-dedicated-sidekiq-queues' into 'master'Sean McGivern2017-12-143-1/+88
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a dedicated queue for each Sidekiq worker See merge request gitlab-org/gitlab-ce!15882
| * | | | | | Use a dedicated queue for each workerDouwe Maan2017-12-123-1/+88
| |/ / / / /
* | | | | | Merge branch 'pawel/cache_feature_check_for_5_minutes_for_method_call' into ↵Robert Speicher2017-12-131-0/+32
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Cache feature check for 1 minute for MethodCall instrumentation toggle See merge request gitlab-org/gitlab-ce!15800
| * | | | | | fix test case descriptionPawel Chojnacki2017-12-131-1/+1
| | | | | | |
| * | | | | | Expire feature flag cache after 1minutePawel Chojnacki2017-12-121-5/+3
| | | | | | |
| * | | | | | use class variables instead of CONSTANTsPawel Chojnacki2017-12-121-2/+2
| | | | | | |
| * | | | | | Use AtomicFixNum to implement CAS isolated cache update.Pawel Chojnacki2017-12-121-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | i.e. Using compare and swap we update the expires_at value. The thread that actually is able to update this value will also set the cache holding method_call enabled state
| * | | | | | Implemente measurement enabled cache using AtomicReferencePawel Chojnacki2017-12-121-2/+2
| | | | | | |
| * | | | | | Implement simple in memory cache that expires after 5 minutesPawel Chojnacki2017-12-121-6/+24
| | | | | | |
| * | | | | | Cache feature check for 5 minutes for MethodCall instrumentation togglePawel Chojnacki2017-12-121-0/+11
| |/ / / / /
* | | | | | Merge branch 'add-tcp-check-rake-task' into 'master'Rémy Coutable2017-12-131-0/+32
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a gitlab:tcp_check rake task See merge request gitlab-org/gitlab-ce!15759
| * | | | | | Add a gitlab:tcp_check rake taskNick Thomas2017-12-131-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to avoid relying on telnet / netcat being installed
* | | | | | | Merge branch 'bvl-backport-migration-spec-changes-to-ce' into 'master'Douwe Maan2017-12-133-23/+26
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create models directly in migration specs See merge request gitlab-org/gitlab-ce!15874
| * | | | | | | Create models directly in migration specsbvl-backport-migration-spec-changes-to-ceBob Van Landuyt2017-12-123-23/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of using the factories. Since the factories might be using columns that aren't available in the schema at version the particular spec is running in.
* | | | | | | | Fix spec by avoiding monkeypatchingMichael Kozono2017-12-121-4/+13
| |_|_|_|_|_|/ |/| | | | | |
* | | | | | | Merge branch ↵Robert Speicher2017-12-121-0/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'tmlee/gitlab-ce-28004-consider-refactoring-member-view-by-using-presenter' into 'master' Refactor member view by using presenter Closes #28004 See merge request gitlab-org/gitlab-ce!15715
| * | | | | | | Present member collection at the controller leveltmlee/gitlab-ce-28004-consider-refactoring-member-view-by-using-presenterRémy Coutable2017-12-121-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | | | | | Merge branch 'zj-memoization-mr-commits' into 'master'Sean McGivern2017-12-121-0/+12
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | Use memoization for commits on diffs See merge request gitlab-org/gitlab-ce!15857
| * | | | | | | Fix rubocop offenceZeger-Jan van de Weg2017-12-121-1/+0
| | | | | | | |
| * | | | | | | Use memoization for commits on diffsZeger-Jan van de Weg2017-12-121-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Gitaly CommitService is being hammered by n + 1 calls, mostly when finding commits. This leads to this gRPC being turned of on production: https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378 Hunting down where it came from, most of them were due to MergeRequest#show. To prove this, I set a script to request the MergeRequest#show page 50 times. The GDK was being scraped by Prometheus, where we have metrics on controller#action and their Gitaly calls performed. On both occations I've restarted the full GDK so all caches had to be rebuild. Current master, 806a68a81f1baee, needed 435 requests After this commit, 154 requests
* | | | | | | | Merge branch 'jprovazn-description' into 'master'Sean McGivern2017-12-121-0/+12
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use message body for merge request description Closes #40968 See merge request gitlab-org/gitlab-ce!15839
| * | | | | | | Use message body for merge request descriptionjprovazn-descriptionJan Provaznik2017-12-111-0/+12
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a merge request is created from email, use message body as merge request description. If message body is empty then merge request description is still created from the source branch commit (if there is only single commit in the merge request). If message body is empty and there are multiple commits in the source branch, then merge request description is left empty. Closes #40968
* | | | | | | Merge branch 'gitaly-mirroring-prep' into 'master'Robert Speicher2017-12-111-18/+3
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gitaly mirroring migration prep Closes gitaly#816 See merge request gitlab-org/gitlab-ce!15775
| * | | | | | Add feature flag to use gitaly-ssh mirroring when cloning internal reposAlejandro Rodríguez2017-12-061-18/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also allows us to simplify the naming since we can make some fetching methods private.
* | | | | | | Merge branch 'sh-remove-allocation-tracking-influxdb' into 'master'Yorick Peterse2017-12-112-46/+0
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove allocation tracking code from InfluxDB sampler for performance Closes gitlab-com/infrastructure#3250 See merge request gitlab-org/gitlab-ce!15834
| * | | | | | Remove RubySampler#sample_objects for performance as wellStan Hu2017-12-111-23/+0
| | | | | | |
| * | | | | | Remove allocation tracking code from InfluxDB sampler for performancesh-remove-allocation-tracking-influxdbStan Hu2017-12-101-23/+0
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On GitLab.com, InfluxSampler#sample_objects appears to take 1.2 s or so to iterate through 1059 objects. This had led to delays of a couple hundred milliseconds in processing in the main thread. Remove this code since it's not really being used. Closes gitlab-com/infrastructure#3250
* | | | | | Remove the need for destroy and add a comment in the specStan Hu2017-12-101-4/+3
| | | | | |
* | | | | | Use build instead of create in importer specStan Hu2017-12-101-1/+1
| | | | | |
* | | | | | Fix failing importer test case on MySQL due to missing trailing slash in ↵sh-fix-import-rake-taskStan Hu2017-12-082-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | root path
* | | | | | Fix gitlab:import:repos Rake task moving repositories into the wrong locationStan Hu2017-12-081-0/+14
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the source import directory were different from the destination directory, GitLab would first create a blank repository and then erroneously move the original one into a subdirectory. Adding an import type prevents this the project from being initialized in the first place. It was accidentally removed in 1f917cbd49. Closes #40765
* | | | | Allow git pull/push on project redirectsMayra Cabrera2017-12-083-10/+135
| | | | |
* | | | | Merge branch 'jprovazn-ignore-anchors' into 'master'Sean McGivern2017-12-082-0/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use prefix for TableOfContents filter hrefs Closes #38473 See merge request gitlab-org/gitlab-ce!15806
| * | | | | Use prefix for TableOfContents filter hrefsJan Provaznik2017-12-082-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TableOfContents filter generates hrefs for each header in markdown, if the header text consists from digits and redacted symbols only, e.g. "123" or "1.0 then the auto-generated href has the same format as issue references. If the generated id contains only digits, then 'anchor-' prefix is prepended to the id. Closes #38473
* | | | | | Merge branch 'fix/gb/fix-pipeline-build-chain-tag-evaluation' into 'master'Douwe Maan2017-12-088-37/+260
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix invalid pipeline build chain tag evaluation Closes #40944 See merge request gitlab-org/gitlab-ce!15805
| * | | | | | Fix RubocopKamil Trzcinski2017-12-081-1/+1
| | | | | | |
| * | | | | | Add Chain::Command specsfix/gb/fix-pipeline-build-chain-tag-evaluationKamil Trzcinski2017-12-082-1/+186
| | | | | | |
| * | | | | | Implement and use Gitlab::Ci::Pipeline::Chain::CommandKamil Trzcinski2017-12-087-45/+50
| | | | | | |
| * | | | | | Fix invalid pipeline build chain tag evaluationGrzegorz Bizon2017-12-081-2/+35
| |/ / / / /
* | | | | | Move the circuitbreaker check out in a separate processbvl-circuitbreaker-processBob Van Landuyt2017-12-089-155/+366
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running.
* | | | | | Merge branch 'jprovazn-testfix2' into 'master'Stan Hu2017-12-081-5/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean test path between merge request handler tests Closes #40900 See merge request gitlab-org/gitlab-ce!15792
| * | | | | | Clean test path between merge request handler testsjprovazn-testfix2Jan Provaznik2017-12-071-5/+5
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | create_merge_request_handler_spec needs a repository for some tests but this repository lasts on disk by default which causes failures of other tests. TestEnv.clean_test_path is used to get rid of the repository after each test. Closes #40900
* | | | | | Merge branch 'fix_39233' into 'master'Sean McGivern2017-12-071-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix #39233 - 500 in merge request Closes #39233 See merge request gitlab-org/gitlab-ce!15774
| * | | | | | fix #39233 - 500 in merge requestMartin Nowak2017-12-071-0/+4
| | |/ / / / | |/| | | | | | | | | | | | | | | | - handle unchanged empty lines in inline diff
* | | | | | Merge branch 'dm-commit-diff-discussions-in-mr-context' into 'master'Douwe Maan2017-12-072-0/+37
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow commenting on individual commits inside an MR Closes #31847 See merge request gitlab-org/gitlab-ce!12148
| * | | | | | adding view and feature specsmicael.bergeron2017-12-071-0/+12
| | | | | | |
| * | | | | | add support for the commit reference filtermicael.bergeron2017-12-071-0/+25
| | | | | | |
View Lorry Controller Status