summaryrefslogtreecommitdiff
path: root/spec/models/cycle_analytics/test_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Change from double click to single click to open dropdownch-test-2Clement Ho2017-06-061-2/+1
|
* Fix SpecsFelipe Artur2017-05-081-0/+1
|
* Reduce the number of loops that Cycle Analytics specs users-why-five-times-surely-twice-is-enoughRobert Speicher2017-02-011-29/+21
| | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/27402
* Use `:empty_project` where possible in model specsrs-empty_project-modelsRobert Speicher2017-01-261-1/+1
|
* refactor fetcher and fixed specsJames Lopez2017-01-171-5/+5
|
* more refactoring and fixing old specsJames Lopez2017-01-171-1/+1
|
* Merge branch 'jej-fix-missing-access-check-on-issues' into 'security'Douwe Maan2016-11-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested - [x] :white_check_mark: app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] :traffic_light: app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] :white_check_mark: app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
* fixed newlineJames Lopez2016-10-121-1/+0
|
* Ignore deployment for statistics in Cycle Analytics, except in staging and ↵James Lopez2016-10-121-5/+0
| | | | | | production stages Also, updated specs and docs.
* Implement a second round of review comments from @DouweM.Timothy Andrew2016-09-211-15/+16
| | | | | | | | | | | | | | - Don't use `TableReferences` - using `.arel_table` is shorter! - Move some database-related code to `Gitlab::Database` - Remove the `MergeRequest#issues_closed` and `Issue#closed_by_merge_requests` associations. They were either shadowing or were too similar to existing methods. They are not being used anywhere, so it's better to remove them to reduce confusion. - Use Rails 3-style validations - Index for `MergeRequest::Metrics#first_deployed_to_production_at` - Only include `CycleAnalyticsHelpers::TestGeneration` for specs that need it. - Other minor refactorings.
* Fix all cycle analytics specs.Timothy Andrew2016-09-201-3/+22
| | | | | A number of failures were introduced due to performance improvements (like pre-calculating metrics).
* Consolidate all cycle analytics helper methods.Timothy Andrew2016-09-071-16/+0
| | | | | | | 1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration` 2. Move all helper methods (previously placed in each individual spec file) to `CycleAnalyticsHelpers`
* Test the `test` cycle analytics phase.Timothy Andrew2016-09-071-0/+90
View Lorry Controller Status