summaryrefslogtreecommitdiff
path: root/spec/models/diff_note_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@13-4-stable-eeGitLab Bot2020-09-191-1/+3
|
* Add latest changes from gitlab-org/gitlab@13-2-stable-eeGitLab Bot2020-07-201-1/+1
|
* Add latest changes from gitlab-org/gitlab@13-1-stable-eeGitLab Bot2020-06-181-5/+25
|
* Add latest changes from gitlab-org/gitlab@13-0-stable-eeGitLab Bot2020-05-201-0/+18
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-12-231-4/+4
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-12-181-7/+113
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-11-201-1/+3
|
* Make diff_refs_match_commit validation reusablePatrick Bajao2019-08-011-0/+4
| | | | | Move it to DiffPositionableNote concern which will be re-used in EE in DraftNote model.
* Avoid 500's when commit is not reachableOswaldo Ferreira2019-06-051-0/+8
|
* Add # frozen_string_literal to spec/modelsThong Kuah2019-04-011-0/+2
| | | | Adds `# frozen_string_literal: true` to spec/models ruby files
* Implement multi-line suggestions filteringOswaldo Ferreira2019-03-201-0/+10
| | | | | Implements the filtering logic for `suggestion:-x+y` syntax.
* Add image_diff_note_on_merge_request factoryDouwe Maan2018-12-201-16/+1
|
* Allow suggesting single line changes in diffsOswaldo Ferreira2018-12-131-0/+18
|
* Persist truncated note diffs on a new table45190-create-notes-diff-filesOswaldo Ferreira2018-05-241-1/+61
| | | | | We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
* Use persisted diff data instead fetching Git on discussionsOswaldo Ferreira2018-04-301-5/+28
| | | | Today, when fetching diffs of a note, we always go to Gitaly in order to diff between commits and return the diff of each discussion note. With this change we avoid doing that for notes on the "current version" of the MR.
* Improve performance of DiffDiscussion#truncated_diff_lines and ↵Douwe Maan2017-12-221-16/+0
| | | | DiffNote#diff_line by removing expensive diff position calculation and comparison
* adding view and feature specsmicael.bergeron2017-12-071-17/+12
|
* Prevents position update for image diff notesissue_40058Felipe Artur2017-11-131-0/+6
|
* Move line code generation into Gitlab::Gitconflict-resolution-refactorAlejandro Rodríguez2017-10-121-1/+1
| | | | Having a distinct class just for that was a bit overkill
* Create a Gitlab::Git submodule for conlict-related filesAlejandro Rodríguez2017-10-121-1/+1
| | | | Rename classes to (hopefully) clearer names while we're doing that.
* Move Gitlab::Diff::LineCode to module Gitlab::GitAlejandro Rodríguez2017-10-121-1/+1
|
* Commenting on image diffsFelipe Artur2017-10-071-3/+37
|
* Remove superfluous lib: true, type: redis, service: true, models: true, ↵Rémy Coutable2017-07-271-1/+1
| | | | | | services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
* Update diff discussion position per discussion instead of per notedm-update-discussion-diff-positionDouwe Maan2017-05-311-23/+4
|
* Pass fallback_diff_refs to Diff::File instead of using view helpersDouwe Maan2017-05-231-2/+2
|
* Allow commenting on older versions of the diff and comparisons between diff ↵dm-link-discussion-to-outdated-diffDouwe Maan2017-05-031-17/+35
| | | | versions
* Add specsDouwe Maan2017-04-101-0/+17
|
* Don't use original_discussion_idDouwe Maan2017-04-051-25/+0
|
* Add specsDouwe Maan2017-04-051-1/+23
|
* Add option to start a new discussion on an MRDouwe Maan2017-04-051-283/+4
|
* Use `:empty_project` where possible in model specsrs-empty_project-modelsRobert Speicher2017-01-261-2/+2
|
* Optimize discussion notes resolving and unresolving21109-discussion-resolve-runs-a-single-update-query-per-note-but-should-run-a-single-update-query-for-all-notes-insteadAlejandro Rodríguez2016-09-061-0/+37
| | | | | | | Use `update_all` to only require one query per discussion to update the notes resolved status. Some changes had to be made to the discussion spec to accout for the fact that notes are not individually updated now
* Store discussion_id on Note for faster discussion lookup.Douwe Maan2016-08-171-0/+50
|
* Address review feedbackDouwe Maan2016-08-161-1/+1
|
* Add specs for new Note and DiffNote methods.Douwe Maan2016-08-121-0/+246
|
* Speedup DiffNote#active? on discussions, preloading noteables and avoid ↵Paco Guzman2016-08-021-2/+2
| | | | | | | | | | | touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha.
* Make `DiffNote#update_position` privateDouwe Maan2016-07-071-39/+44
|
* Add tests for DiffNoteDouwe Maan2016-07-061-0/+186