summaryrefslogtreecommitdiff
path: root/spec/models/members
Commit message (Collapse)AuthorAgeFilesLines
* Optimize Event queries by removing default order23106-events-default-scope-results-in-a-slow-queryAlejandro Rodríguez2016-10-271-2/+2
|
* Remove redundant class_name and foreign_key overridesDavid Wagner2016-10-241-1/+1
| | | | | | They were Rails' default and are unnecessarily overridden. Signed-off-by: David Wagner <david@marvid.fr>
* Differentiate the expire from leave eventCallum Dryden2016-10-201-0/+11
| | | | | | | | | | At the moment we cannot see weather a user left a project due to their membership expiring of if they themselves opted to leave the project. This adds a new event type that allows us to make this differentiation. Note that is not really feasable to go back and reliably fix up the previous events. As a result the events for previous expire removals will remain the same however events of this nature going forward will be correctly represented.
* Allow Member.add_user to handle access requestersRémy Coutable2016-09-282-17/+60
| | | | | | | | | | | | | | | | | | | | | Changes include: - Ensure Member.add_user is not called directly when not necessary - New GroupMember.add_users_to_group to have the same abstraction level as for Project - Refactor Member.add_user to take a source instead of an array of members - Fix Rubocop offenses - Always use Project#add_user instead of project.team.add_user - Factorize users addition as members in Member.add_users_to_source - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects - Destroy any requester before adding them as a member - Improve the way we handle access requesters in Member.add_user Instead of removing the requester and creating a new member, we now simply accepts their access request. This way, they will receive a "access request granted" email. - Fix error that was previously silently ignored - Stop raising when access level is invalid in Member, let Rails validation do their work Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove schema annotations completelyValery Sizov2016-09-162-38/+0
|
* remove Ability.abilitieshttp://jneen.net/2016-08-301-4/+2
|
* remove six, and use a Set insteadhttp://jneen.net/2016-08-301-2/+1
|
* New AccessRequests API endpoints for Group & ProjectRémy Coutable2016-08-101-1/+2
| | | | | | | | Also, mutualize AccessRequests and Members endpoints for Group & Project. New API documentation for the AccessRequests endpoints. Signed-off-by: Rémy Coutable <remy@rymai.me>
* adds second batch of tests changed to active tenseactive-tense-test-coveragetiagonbotelho2016-08-092-3/+3
|
* Fix Rename `add_users_into_project` and `projects_ids`Herminio Torres2016-08-041-2/+2
| | | | | | We never add things `into` projects, we just add them `to` projects. So how about we rename this to `add_users_to_project`. Rename `projects_ids` to `project_ids` by following the convention of rails.
* Avoid `describe`-ing symbols in specsrs-describe-symbolsRobert Speicher2016-07-121-2/+2
|
* Enable Style/EmptyLines cop, remove redundant onesrubocop/enable-cops-for-empty-linesGrzegorz Bizon2016-07-011-1/+0
|
* New Members::DestroyServiceRémy Coutable2016-06-182-20/+0
| | | | | | | This is to ensure we don't send unwanted notifications when deleting a project. In other words, stop abusing AR callbacks and use services. Signed-off-by: Rémy Coutable <remy@rymai.me>
* UI and copywriting improvements13948-access-request-to-projects-and-groupsRémy Coutable2016-06-142-16/+28
| | | | | | | | | + Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add request access for groupsRémy Coutable2016-06-142-1/+43
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix broken specsLong Nguyen2016-05-211-3/+3
|
* Fix broken specsLong Nguyen2016-05-211-1/+0
|
* Remove todos when destroy project member and specsLong Nguyen2016-05-211-0/+43
|
* Tag model specsDouwe Maan2015-12-092-2/+2
|
* Rename abilities to correspond contoller/model action namesrename-abilitiesDmitriy Zaporozhets2015-06-261-1/+1
| | | | | | | | | | | | | | | | | write_ was renamed to create_ modify_ was renamed to update_ So now in update action we have next code def create can?(current_user, :create_issue, @issue) end def update can?(current_user, :update_issue, @issue) end Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Update mock and stub syntax for specsRobert Speicher2015-06-221-2/+6
|
* Re-annotate modelsStan Hu2015-05-032-2/+10
|
* Use `group_member` instead of `users_group` or `membership`.Douwe Maan2015-03-151-6/+6
|
* Updated rspec to rspec 3.x syntaxJeroen van Baarsen2015-02-122-16/+16
| | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Make the structure of spec/models match app/modelsRobert Speicher2015-01-302-0/+138
View Lorry Controller Status