Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix RSpec/DescribeSymbol cop violations | Robert Speicher | 2017-03-24 | 1 | -1/+1 |
| | |||||
* | Use `:empty_project` where possible in model specsrs-empty_project-models | Robert Speicher | 2017-01-26 | 1 | -3/+3 |
| | |||||
* | Merge branch 'jej-24637-move-issue-visible_to_user-to-finder' into 'security' | Sean McGivern | 2016-12-15 | 1 | -5/+6 |
| | | | | | | | Issue#visible_to_user moved to IssuesFinder Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24637. See merge request !2039 | ||||
* | Add shorthand support to gitlab markdown references | Oswaldo Ferreira | 2016-12-02 | 1 | -0/+14 |
| | |||||
* | Add a starting date to milestonesmilestone_start_date | Valery Sizov | 2016-11-23 | 1 | -17/+26 |
| | |||||
* | Allowing ">" to be used for Milestone models's title and storing the value ↵ | Makoto Scott-Hinkle | 2016-09-29 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | in db as unescaped. Updating test value for milestone title Adding API test for title with reserved HTML characters. Updating changelog Adding the MR number for fixing bug #22452. removing duplicate line Updating MR number. | ||||
* | adds second batch of tests changed to active tenseactive-tense-test-coverage | tiagonbotelho | 2016-08-09 | 1 | -10/+10 |
| | |||||
* | Avoid `describe`-ing symbols in specsrs-describe-symbols | Robert Speicher | 2016-07-12 | 1 | -5/+5 |
| | |||||
* | Return a relation with Postgres17227-upcoming-milestone-is-confusing-when-projects-have-different-milestones | Sean McGivern | 2016-05-16 | 1 | -1/+3 |
| | | | | | | | | | Postgres only needs to select a single column, so that can used as a sub-query where `Milestone.upcoming_ids_by_projects` is actually used in `IssuableFinder`. MySQL needs to select the `due_date` column because it's used in the `HAVING` clause, so it has to return an array of IDs. | ||||
* | Make upcoming milestone work across projects | Sean McGivern | 2016-05-16 | 1 | -0/+31 |
| | | | | | | | | | | | | | | | | | | | | | | Before: we took the next milestone due across all projects in the search and found issues whose milestone title matched that one. Problems: 1. The milestone could be closed. 2. Different projects have milestones with different schedules. 3. Different projects have milestones with different titles. 4. Different projects can have milestones with different schedules, but the _same_ title. That means we could show issues from a past milestone, or one that's far in the future. After: gather the ID of the next milestone on each project we're looking at, and find issues with those milestone IDs. Problems: 1. For a lot of projects, this can return a lot of IDs. 2. The SQL query has to be different between Postgres and MySQL, because MySQL is much more lenient with HAVING: as well as the columns appearing in GROUP BY or in aggregate clauses, MySQL allows them to appear in the SELECT list (un-aggregated). | ||||
* | Merge branch 'remove-annotate-gem' into 'master' | Yorick Peterse | 2016-05-10 | 1 | -15/+0 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the annotate gem and delete old annotations In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382 /cc @yorickpeterse See merge request !4099 | ||||
| * | Remove the annotate gem and delete old annotations | Jeroen van Baarsen | 2016-05-09 | 1 | -15/+0 |
| | | | | | | | | | | | | | | | | | | In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382 | ||||
* | | Sanitize milestones and label titlesissue_15394 | Felipe Artur | 2016-05-05 | 1 | -0/+8 |
|/ | |||||
* | Restrict access for confidential issues on milestone view | Douglas Barbosa Alexandre | 2016-03-17 | 1 | -10/+10 |
| | |||||
* | Use ILIKE/LIKE for searching milestones | Yorick Peterse | 2016-03-11 | 1 | -0/+30 |
| | |||||
* | Updates from last code review.issue_13621_2 | Rubén Dávila | 2016-03-06 | 1 | -2/+1 |
| | |||||
* | Validate uniqueness of milestone title per project | Zeger-Jan van de Weg | 2016-02-08 | 1 | -0/+14 |
| | | | | Fixes #3903 | ||||
* | Tag model specs | Douwe Maan | 2015-12-09 | 1 | -1/+1 |
| | |||||
* | Improve performance of sorting milestone issues | Yorick Peterse | 2015-10-19 | 1 | -0/+28 |
| | | | | | | | | | | | | | | This cuts down the time it takes to sort issues of a milestone by about 10x. In the previous setup the code would run a SQL query for every issue that had to be sorted. The new setup instead runs a single SQL query to update all the given issues at once. The attached benchmark used to run at around 60 iterations per second, using the new setup this hovers around 600 iterations per second. Timing wise a request to update a milestone with 40-something issues would take about 760 ms, in the new setup this only takes about 130 ms. Fixes #3066 | ||||
* | Fix rubocop warnings in spec/models | Guilherme Garnier | 2015-10-03 | 1 | -3/+3 |
| | |||||
* | Update mock and stub syntax for specs | Robert Speicher | 2015-06-22 | 1 | -7/+7 |
| | |||||
* | Change percent_complete rescue value from 100 to 0 | Jonah Bishop | 2015-05-26 | 1 | -1/+1 |
| | | | | | | | | | The percent_complete method returns a value of 100 when a ZeroDivisionError occurs. That seems like a very strange default for an error case, and results in a bug when a milestone has no corresponding issues (new, empty milestones show 100% completion). This commit changes the rescue value to 0, and subsequently fixes #1656, which reported this problem. | ||||
* | Updated rspec to rspec 3.x syntax | Jeroen van Baarsen | 2015-02-12 | 1 | -21/+21 |
| | | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> | ||||
* | Remove mass assgnment specs | Dmitriy Zaporozhets | 2014-06-26 | 1 | -1/+0 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Re-annotate models | Dmitriy Zaporozhets | 2014-04-09 | 1 | -2/+2 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Reannotate | Dmitriy Zaporozhets | 2013-08-21 | 1 | -0/+1 |
| | |||||
* | Look for milestone by iid in milestone controller | Dmitriy Zaporozhets | 2013-08-21 | 1 | -0/+1 |
| | |||||
* | Fix typos | Johannes Schleifenbaum | 2013-07-29 | 1 | -2/+2 |
| | |||||
* | cattr_accessor is not threadsafe! | Dmitriy Zaporozhets | 2013-06-11 | 1 | -1/+0 |
| | |||||
* | remove trailing spaces | Andrey Kumanyaev | 2013-05-05 | 1 | -1/+1 |
| | |||||
* | reannotated | Dmitriy Zaporozhets | 2013-03-15 | 1 | -1/+1 |
| | |||||
* | Creating test values moved to before | Andrew8xx8 | 2013-02-18 | 1 | -6/+11 |
| | |||||
* | Additional tests added to Milestone | Andrew8xx8 | 2013-02-18 | 1 | -0/+27 |
| | |||||
* | Milestone uses StateMachine now | Andrew8xx8 | 2013-02-18 | 1 | -7/+2 |
| | |||||
* | Merge Request uses StateMachine now | Andrew8xx8 | 2013-02-18 | 1 | -1/+1 |
| | |||||
* | Rspec models Milestone, Commit, UsersProject | Dmitriy Zaporozhets | 2013-01-03 | 1 | -0/+50 |
| | |||||
* | Fixed tests. added test for gitlab_ci_service model | Dmitriy Zaporozhets | 2013-01-03 | 1 | -0/+1 |
| | |||||
* | Annotated. schema updated | Dmitriy Zaporozhets | 2012-11-19 | 1 | -6/+6 |
| | |||||
* | Remove backward compatibility of factories. | Vincent Bonmalais | 2012-11-13 | 1 | -2/+2 |
| | |||||
* | Annotated | Dmitriy Zaporozhets | 2012-10-09 | 1 | -0/+14 |
| | |||||
* | tests fix | Andrey Kumanyaev | 2012-10-09 | 1 | -1/+1 |
| | |||||
* | set activerecord whitelist_attributes to true | Nihad Abbasov | 2012-09-26 | 1 | -0/+4 |
| | |||||
* | add validations for boolean attributes | Nihad Abbasov | 2012-09-05 | 1 | -0/+1 |
| | |||||
* | Remove annotations from specs | Robert Speicher | 2012-08-29 | 1 | -14/+0 |
| | |||||
* | Simple model spec changes made possible by new factories | Robert Speicher | 2012-08-28 | 1 | -5/+2 |
| | |||||
* | Minor cleanup to Milestone model and spec | Robert Speicher | 2012-08-25 | 1 | -9/+18 |
| | | | | Back-ported from my still-in-progress major cleanup. | ||||
* | Fully embrace Ruby 1.9 hash syntax | Robert Speicher | 2012-08-10 | 1 | -4/+4 |
| | | | | Didn't bother with files in db/, config/, or features/ | ||||
* | Reannotated | randx | 2012-06-26 | 1 | -0/+14 |
| | |||||
* | first pack of tests for milestones | Dmitriy Zaporozhets | 2012-04-09 | 1 | -1/+36 |
| | |||||
* | Milestone basic scaffold | Dmitriy Zaporozhets | 2012-04-09 | 1 | -0/+5 |