summaryrefslogtreecommitdiff
path: root/spec/models/milestone_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Update MR based on Sean's feedbackrz_fix_milestone_countEagllus2018-10-261-5/+5
|
* Removed the print in testRonald van Zon2018-10-251-3/+0
|
* Update related tests based on commentEagllus2018-10-221-6/+11
|
* Moving state_count to Milestone model and related testsEagllus2018-10-171-0/+35
| | | | | By moving and improving state_count the functions in GlobalMilestone are no longer used.
* Don't use MilestoneFinder for group milestonesDouglas Barbosa Alexandre2018-09-181-0/+18
| | | | | | This refactors the DashboardGroupMilestone model so that it no longer uses the MilestoneFinder, instead using methods defined on the Milestone model directly.
* Fix ordering by name on milestones pageDouglas Barbosa Alexandre2018-07-301-0/+20
| | | | | We should sort by title because name is only an alias for the title attribute on the milestone model.
* Clarify scope for AtomicInternalId shared specShinya Maeda2018-05-141-0/+2
|
* Atomic internal ids for all modelsAndreas Brandl2018-04-201-0/+20
|
* Resolve "Improve tooltips of collapsed sidebars"Dennis Tang2018-04-191-4/+8
|
* Changed validation error message on wrong milestone datesXurxo Méndez Pérez2017-11-181-1/+1
|
* Fix rewriting issue references with group milestonesGrzegorz Bizon2017-09-201-5/+10
|
* Support references to group milestonesSean McGivern2017-08-071-7/+31
| | | | | Group milestones can only be referred to by name, not IID. They also do not support cross-project references.
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-021-8/+8
|
* Use described_class when possibleRémy Coutable2017-07-271-5/+5
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove superfluous lib: true, type: redis, service: true, models: true, ↵Rémy Coutable2017-07-271-1/+1
| | | | | | services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
* Native group milestonesFelipe Artur2017-07-071-11/+33
|
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-4/+4
|
* Remove old specs and add new onesFelipe Artur2017-06-161-29/+0
|
* Fix: Milestone - Participants list is showing duplicate assigneesfix_duplicated_assignees_on_milestone_pageValery Sizov2017-05-291-0/+13
|
* Removed `Milestone#is_empty?`Jacopo2017-04-071-12/+0
| | | | Removed `Milestone#is_empty?` because is not used anymore in the codebase
* Fix RSpec/DescribeSymbol cop violationsRobert Speicher2017-03-241-1/+1
|
* Use `:empty_project` where possible in model specsrs-empty_project-modelsRobert Speicher2017-01-261-3/+3
|
* Merge branch 'jej-24637-move-issue-visible_to_user-to-finder' into 'security' Sean McGivern2016-12-151-5/+6
| | | | | | | Issue#visible_to_user moved to IssuesFinder Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24637. See merge request !2039
* Add shorthand support to gitlab markdown referencesOswaldo Ferreira2016-12-021-0/+14
|
* Add a starting date to milestonesmilestone_start_dateValery Sizov2016-11-231-17/+26
|
* Allowing ">" to be used for Milestone models's title and storing the value ↵Makoto Scott-Hinkle2016-09-291-2/+2
| | | | | | | | | | | | | | | | in db as unescaped. Updating test value for milestone title Adding API test for title with reserved HTML characters. Updating changelog Adding the MR number for fixing bug #22452. removing duplicate line Updating MR number.
* adds second batch of tests changed to active tenseactive-tense-test-coveragetiagonbotelho2016-08-091-10/+10
|
* Avoid `describe`-ing symbols in specsrs-describe-symbolsRobert Speicher2016-07-121-5/+5
|
* Return a relation with Postgres17227-upcoming-milestone-is-confusing-when-projects-have-different-milestonesSean McGivern2016-05-161-1/+3
| | | | | | | | | Postgres only needs to select a single column, so that can used as a sub-query where `Milestone.upcoming_ids_by_projects` is actually used in `IssuableFinder`. MySQL needs to select the `due_date` column because it's used in the `HAVING` clause, so it has to return an array of IDs.
* Make upcoming milestone work across projectsSean McGivern2016-05-161-0/+31
| | | | | | | | | | | | | | | | | | | | | | Before: we took the next milestone due across all projects in the search and found issues whose milestone title matched that one. Problems: 1. The milestone could be closed. 2. Different projects have milestones with different schedules. 3. Different projects have milestones with different titles. 4. Different projects can have milestones with different schedules, but the _same_ title. That means we could show issues from a past milestone, or one that's far in the future. After: gather the ID of the next milestone on each project we're looking at, and find issues with those milestone IDs. Problems: 1. For a lot of projects, this can return a lot of IDs. 2. The SQL query has to be different between Postgres and MySQL, because MySQL is much more lenient with HAVING: as well as the columns appearing in GROUP BY or in aggregate clauses, MySQL allows them to appear in the SELECT list (un-aggregated).
* Merge branch 'remove-annotate-gem' into 'master' Yorick Peterse2016-05-101-15/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the annotate gem and delete old annotations In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382 /cc @yorickpeterse See merge request !4099
| * Remove the annotate gem and delete old annotationsJeroen van Baarsen2016-05-091-15/+0
| | | | | | | | | | | | | | | | | | In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
* | Sanitize milestones and label titlesissue_15394Felipe Artur2016-05-051-0/+8
|/
* Restrict access for confidential issues on milestone viewDouglas Barbosa Alexandre2016-03-171-10/+10
|
* Use ILIKE/LIKE for searching milestonesYorick Peterse2016-03-111-0/+30
|
* Updates from last code review.issue_13621_2Rubén Dávila2016-03-061-2/+1
|
* Validate uniqueness of milestone title per projectZeger-Jan van de Weg2016-02-081-0/+14
| | | | Fixes #3903
* Tag model specsDouwe Maan2015-12-091-1/+1
|
* Improve performance of sorting milestone issuesYorick Peterse2015-10-191-0/+28
| | | | | | | | | | | | | | This cuts down the time it takes to sort issues of a milestone by about 10x. In the previous setup the code would run a SQL query for every issue that had to be sorted. The new setup instead runs a single SQL query to update all the given issues at once. The attached benchmark used to run at around 60 iterations per second, using the new setup this hovers around 600 iterations per second. Timing wise a request to update a milestone with 40-something issues would take about 760 ms, in the new setup this only takes about 130 ms. Fixes #3066
* Fix rubocop warnings in spec/modelsGuilherme Garnier2015-10-031-3/+3
|
* Update mock and stub syntax for specsRobert Speicher2015-06-221-7/+7
|
* Change percent_complete rescue value from 100 to 0Jonah Bishop2015-05-261-1/+1
| | | | | | | | | The percent_complete method returns a value of 100 when a ZeroDivisionError occurs. That seems like a very strange default for an error case, and results in a bug when a milestone has no corresponding issues (new, empty milestones show 100% completion). This commit changes the rescue value to 0, and subsequently fixes #1656, which reported this problem.
* Updated rspec to rspec 3.x syntaxJeroen van Baarsen2015-02-121-21/+21
| | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Remove mass assgnment specsDmitriy Zaporozhets2014-06-261-1/+0
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Re-annotate modelsDmitriy Zaporozhets2014-04-091-2/+2
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* ReannotateDmitriy Zaporozhets2013-08-211-0/+1
|
* Look for milestone by iid in milestone controllerDmitriy Zaporozhets2013-08-211-0/+1
|
* Fix typosJohannes Schleifenbaum2013-07-291-2/+2
|
* cattr_accessor is not threadsafe!Dmitriy Zaporozhets2013-06-111-1/+0
|
* remove trailing spacesAndrey Kumanyaev2013-05-051-1/+1
|
View Lorry Controller Status