Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Shut up, RuboCopfeature/note-validator | Robert Speicher | 2016-05-29 | 1 | -2/+2 |
| | | | | :heart: | ||||
* | Minor changes in note validation specs | Grzegorz Bizon | 2016-05-29 | 1 | -5/+6 |
| | |||||
* | Update specs to carry out changes in note factory | Grzegorz Bizon | 2016-05-29 | 1 | -2/+8 |
| | |||||
* | Add more validation tests for note model | Grzegorz Bizon | 2016-05-29 | 1 | -0/+27 |
| | |||||
* | Update note factory to include noteable association | Grzegorz Bizon | 2016-05-29 | 1 | -3/+3 |
| | |||||
* | Update specs | Douwe Maan | 2016-05-13 | 1 | -75/+1 |
| | |||||
* | Extract LegacyDiffNote out of Note | Douwe Maan | 2016-05-13 | 1 | -6/+2 |
| | |||||
* | Remove the annotate gem and delete old annotations | Jeroen van Baarsen | 2016-05-09 | 1 | -21/+0 |
| | | | | | | | | | In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382 | ||||
* | Merge branch 'rs-note-active-spec' into 'master' | Robert Speicher | 2016-03-14 | 1 | -1/+61 |
|\ | | | | | | | | | | | Add unit specs for `Note#active?` See merge request !3133 | ||||
| * | Add unit specs for `Note#active?`rs-note-active-spec | Robert Speicher | 2016-03-11 | 1 | -1/+61 |
| | | |||||
* | | Disallow blank (non-null) values for a Note's `line_code` attributers-disallow-blank-line-code | Robert Speicher | 2016-03-11 | 1 | -0/+8 |
|/ | | | | | | | | | | | | | It's unclear how these blank values got added, but GitLab.com had a few: ``` irb(main):002:0> Note.where("line_code IS NOT NULL AND line_code = ''").count => 439 ``` We've added a migration to convert any existing records to use a NULL value when blank, and updated Note to set blank values to nil before validation. | ||||
* | Use ILIKE/LIKE for searching notes | Yorick Peterse | 2016-03-11 | 1 | -3/+9 |
| | |||||
* | Remove redundant integration tests | Robert Speicher | 2016-03-07 | 1 | -1/+1 |
| | | | | | | | | | | These three tests were essentially checking that adding a note to something updated its `noteable`'s `updated_at` attribute. This is well-tested Rails behavior and we shouldn't feel the need to write an integration test to verify it. At most we should be ensuring that the association definition adds the `touch: true` option, which we now do in Note's unit test. | ||||
* | Rename Tasks to Todos | Douglas Barbosa Alexandre | 2016-02-20 | 1 | -1/+1 |
| | |||||
* | Use destroy, in case we ever have before_destroy callbacks on Task | Douglas Barbosa Alexandre | 2016-02-20 | 1 | -1/+1 |
| | |||||
* | Create a pending task when a user is mentioned on a note | Douglas Barbosa Alexandre | 2016-02-20 | 1 | -0/+2 |
| | |||||
* | Improve #set_award! on the Note model12792-emoji-as-text-diff-comment | Zeger-Jan van de Weg | 2016-02-19 | 1 | -1/+4 |
| | |||||
* | Emoji reponses on diffs aren't award emoji | Zeger-Jan van de Weg | 2016-02-19 | 1 | -2/+7 |
| | |||||
* | Fix specs and rubocop warningsfix/private-references | Rémy Coutable | 2016-01-14 | 1 | -2/+2 |
| | |||||
* | Add spec for Note#cross_reference_not_visible_for? | Rémy Coutable | 2016-01-13 | 1 | -0/+24 |
| | |||||
* | Add regression test.fix-banzai-cache | Douwe Maan | 2016-01-06 | 1 | -1/+14 |
| | |||||
* | revert back vote buttons to issue and MR pages | Valery Sizov | 2015-12-25 | 1 | -3/+8 |
| | |||||
* | fix specemoji-picker-fix | Valery Sizov | 2015-12-24 | 1 | -2/+2 |
| | |||||
* | emoji aliases problem | Valery Sizov | 2015-12-11 | 1 | -0/+9 |
| | |||||
* | Don't allow to edit award emoji commentsemoji_edit_disallow | Valery Sizov | 2015-12-10 | 1 | -0/+17 |
| | |||||
* | Tag model specs | Douwe Maan | 2015-12-09 | 1 | -1/+1 |
| | |||||
* | Update annotations | Stan Hu | 2015-12-08 | 1 | -0/+1 |
| | |||||
* | fox testsemoji_votes | Valery Sizov | 2015-11-19 | 1 | -3/+2 |
| | |||||
* | added specs | Valery Sizov | 2015-11-19 | 1 | -0/+13 |
| | |||||
* | added spinach tests | Valery Sizov | 2015-11-19 | 1 | -75/+0 |
| | |||||
* | Fix mentionable specs | Douwe Maan | 2015-10-12 | 1 | -3/+2 |
| | |||||
* | Re-annotate models | Stan Hu | 2015-09-06 | 1 | -0/+1 |
| | |||||
* | Case-insensetive search for commentscomment-case-insensetive-search | Dmitriy Zaporozhets | 2015-08-19 | 1 | -0/+6 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Revert "Update noteable after a new note is added"revert_touch | Valery Sizov | 2015-08-05 | 1 | -1/+1 |
| | | | | This reverts commit fbdaf0e2a517660c0e4e3960f20b2d3568c33e78. | ||||
* | Rename abilities to correspond contoller/model action namesrename-abilities | Dmitriy Zaporozhets | 2015-06-26 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | write_ was renamed to create_ modify_ was renamed to update_ So now in update action we have next code def create can?(current_user, :create_issue, @issue) end def update can?(current_user, :update_issue, @issue) end Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Update noteable after a new note is added | Jeroen van Baarsen | 2015-06-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | **What does this do?** It makes sure that whenever a new note is added to an noteable item, the updated_at of that item is also updated. **Why is this needed?** At this moment when you post a comment on an issue or add a label to an issue, the updated_at is not changed. Because of this the filtering for least recently updated is not really useful (since it only takes in account the original text from the noteable). Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> | ||||
* | Simplify Note model specs | Robert Speicher | 2015-05-11 | 1 | -213/+34 |
| | |||||
* | Add a SystemNoteService class | Robert Speicher | 2015-05-11 | 1 | -256/+0 |
| | | | | | There's a lot of code in the Note model that only deals with creating system notes, so we're going to split that into its own class. | ||||
* | Note's voting specs don't need to persist to the database | Robert Speicher | 2015-05-10 | 1 | -18/+16 |
| | |||||
* | Link cross-project cross-reference notes to correct project. | Douwe Maan | 2015-04-24 | 1 | -11/+11 |
| | |||||
* | Use project.commit convenience method. | Douwe Maan | 2015-04-24 | 1 | -3/+3 |
| | |||||
* | Correct usage of `subject` in specs | Robert Speicher | 2015-04-16 | 1 | -1/+2 |
| | |||||
* | Fix cross references when usernames, milestones, or project names contain ↵ | Stan Hu | 2015-03-19 | 1 | -11/+142 |
| | | | | | | underscores. Remove emphasis from system notes to avoid Markdown conflicts in names. | ||||
* | Updated rspec to rspec 3.x syntax | Jeroen van Baarsen | 2015-02-12 | 1 | -87/+204 |
| | | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> | ||||
* | Create a failing test where commit in mr creates a mr mention note. | Marin Jankovski | 2014-11-05 | 1 | -0/+6 |
| | |||||
* | Fix tests | Dmitriy Zaporozhets | 2014-10-10 | 1 | -2/+2 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Use short_id instead of [0..N] for short version of commit sha | Dmitriy Zaporozhets | 2014-10-10 | 1 | -2/+2 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Prevent PG::Error exception when check commit reference on commit | Dmitriy Zaporozhets | 2014-10-06 | 1 | -0/+20 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Make Mentionables work for cross-project refs | Vinnie Okada | 2014-10-03 | 1 | -2/+2 |
| | | | | | Add a note to merge requests and issues when they're mentioned by a merge request, issue, or commit in another project. | ||||
* | Replace project_access attribute with access_level in specs and API | Dmitriy Zaporozhets | 2014-09-15 | 1 | -7/+7 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> |