summaryrefslogtreecommitdiff
path: root/spec/models/project_services
Commit message (Collapse)AuthorAgeFilesLines
* Use stubs instead of modifying global statesno-include-on-top-levelLin Jen-Shin2016-11-031-1/+3
|
* Try not to include anything globally!Lin Jen-Shin2016-11-031-1/+2
|
* Use the server's base URL without relative URL part when creating links in JIRABrian Kintz2016-11-021-0/+22
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Finish updates to use JIRA gemFelipe Artur2016-10-261-41/+30
| | | | Code improvements, bug fixes, finish documentation and specs
* Return truncation for notification descriptions, fix minor bugs with renderingAirat Shigapov2016-10-201-6/+6
|
* Tests for markdown HipChat notificationsDavid Eisner2016-10-201-6/+6
|
* Render hipchat notification descriptions as HTML instead of raw markdownAirat Shigapov2016-10-201-10/+10
|
* Prevent wrong markdown on issue ids when project has Jira service activatedissue_828Felipe Artur2016-10-192-0/+17
|
* Merge remote-tracking branch 'upstream/master' into pipeline-emailsLin Jen-Shin2016-10-081-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (292 commits) Deletes extra empty line breaking the build Optimize the `award_user_list` helper spec Fix typo and add he MWBS accronym for "Merge When Build Succeeds" Added missing content and improved layout ExpireBuildArtifactsWorker query builds table without ordering enqueuing one job per build to cleanup Improve the contribution and MR review guide Updates test in order to look for link Make projects API docs match parameter style Fix Event#reset_project_activity updates Update user whitelist reject message Call ensure_secret_token! in secret token test's before block since it would be called in an initializer. Add a CHANGELOG for CacheMarkdownField Enable CacheMarkdownField for the remaining models Make search results use the markdown cache columns, treating them consistently Use CacheMarkdownField for notes Add markdown cache columns to the database, but don't use them yet Update issue board spec Link to Registry docs from project settings Truncate long labels with ellipsis in labels page Improve issue load time performance by avoiding ORDER BY in find_by call ...
| * Merge branch 'feature/improve-async-pipeline-processing' into 'master' Kamil Trzciński2016-10-061-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve asynchronous pipeline processing ## What does this MR do? This MR improves asynchronous processing of pipeline. ## Why was this MR needed? It eliminates some race conditions and improves performance. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing ## What are the relevant issue / merge request numbers? Related merge request: !6410 Extracted from !6411 See merge request !6650
| | * Fix hipchat service specs after changes in pipelineGrzegorz Bizon2016-10-041-1/+1
| | |
* | | Merge remote-tracking branch 'upstream/master' into pipeline-emailsLin Jen-Shin2016-10-046-20/+36
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (372 commits) Enable Lint/StringConversionInInterpolation cop and autocorrect offenses resolve duplicated changelog entry credit myself :smile: change determine conditions override subject method in devise mailer follow the styleguide: Don't use parentheses around a literal wrap subject with method subject move spec back into shared example `an email sent from GitLab` stub config settings in spec remove empty line at block body end remove extra entry create new test in `spec/mailers/notify_spec.rb` move changelog to 8.13 add configurable email subject suffix Fixes sidebar navigation. Convert "SSH Keys" Spinach features to RSpec Enable import/export back for non-admins Update gitlab-shell to 3.6.3 Updated artwork of empty group state. Better empty state for Groups view. ...
| * | Changed Slack service user referencing from full name to usernamesecustor2016-10-035-20/+20
| |/
| * added more specsJames Lopez2016-09-261-0/+16
| |
* | Fix test by having a real commitLin Jen-Shin2016-09-231-1/+5
| |
* | Merge remote-tracking branch 'upstream/master' into pipeline-emailsLin Jen-Shin2016-09-1920-401/+0
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (97 commits) Add missing spec for ProtectedBranches::CreateService Add specs that target status failure Return created status Document how to download the latest build artifacts Clarify why GH integration is the preferred importing method Refactor GitHub importing documentation Update GitHub importer documentation to reflect current importer state Formatting fix in doc/ci/examples/README.md Refactor boards_spec.rb to avoid code duplication Replace contributions calendar timezone payload with dates Use oj gem for faster JSON processing Render invalid template for merge requests without source project and open Bump fog-aws and other dependent modules Fix API notes endpoint when posting only emoji Doesnt run JS if active element doesnt exist Add missing CHANGELOG entry Remove schema annotations completely fixed incorrect reference to @repository.root_ref in _readme.html.haml. #22083 Scrolls active tab into middle of nav on mobile MergeRequest#environments now returns an empty array when diff_head_commit is nil ...
| * Remove schema annotations completelyValery Sizov2016-09-1620-401/+0
| |
* | test for realLin Jen-Shin2016-09-141-34/+82
| |
* | Fix pipeline emails and add testsLin Jen-Shin2016-09-141-0/+130
|/
* Remove redundant tests, feedback:pipeline-hooksLin Jen-Shin2016-09-062-24/+0
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14993999
* I am too used to have no spaces around default argsLin Jen-Shin2016-08-292-2/+2
|
* Use a completely fake webhook URL, feedback:Lin Jen-Shin2016-08-291-1/+1
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14665966
* empty lines between blocksLin Jen-Shin2016-08-291-1/+1
|
* pipeline/build succeeded/failed, feedback:Lin Jen-Shin2016-08-292-4/+4
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14664613
* Shorten the line and use methods, feedback:Lin Jen-Shin2016-08-292-12/+21
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14664637
* somewhere -> example.gitlab, feedback:Lin Jen-Shin2016-08-292-8/+8
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14664661
* Empty line between message =, feedback:Lin Jen-Shin2016-08-292-3/+9
| | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5525#note_14664714
* Remove old stuffsLin Jen-Shin2016-08-241-2/+2
|
* Merge remote-tracking branch 'upstream/master' into pipeline-hooksLin Jen-Shin2016-08-2417-76/+229
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (1174 commits) Added CHANGELOG Added unfold test to parallel and added 'diff discussion' context Fix Spinach branches spec Better first match on this MR also Change merge_error column from string to text type Fix typo in gitlab_flow.md entities: make Environment inherit EnvironmentBasic Updated to optimized specs from !5864 Added 'with an unfolded line should not allow commenting' scenario (line 125) Added addtional 'renderable' validator to check 'data-note-type' attr exists Allow passing an index to selectRowAtIndex Fixed enter key in search input not working Fix file links on project page Files view Fix incorrect "stopped impersonation" log message 8.11 is released, long live 8.12 Also check if Akismet is enabled, before showing the `Submit as spam` button. fix location of markdown help location Fix for update 8.10-to-8.11.md doc. Appease the linter. Add Ruby 2.3 upgrade notes. ...
| * Make rubocop happyKamil Trzcinski2016-08-151-9/+9
| |
| * Merge branch 'fix-failing-tests' into pipeline-hooks-without-slackKamil Trzcinski2016-08-151-10/+11
| |\
| | * This fixes a long running tests due to changed Sidekiq statefix-failing-testsKamil Trzcinski2016-08-151-10/+11
| | |
| * | Merge remote-tracking branch 'origin/master' into pipeline-hooks-without-slackKamil Trzcinski2016-08-151-0/+71
| |\ \ | | |/
| | * Ability to specify branches for pivotal tracker integrationEgor Lynko2016-08-151-0/+71
| | |
| * | Simplify the name for data builder, feedback:Lin Jen-Shin2016-08-1211-30/+24
| | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13671791
| * | Merge remote-tracking branch 'origin/master' into pipeline-hooks-without-slackKamil Trzcinski2016-08-112-1/+60
| |\ \ | | |/ | | | | | | | | | | | | | | | # Conflicts: # app/models/ci/pipeline.rb # app/services/ci/create_pipeline_service.rb # spec/models/project_services/hipchat_service_spec.rb
| | * Merge branch 'refactor-builds-creation-service' into 'master' Rémy Coutable2016-08-111-1/+2
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor pipeline creation service ## What does this MR do? This refactors GitLab CI build processing: all builds for pipeline are pre-created when a pipeline object is created. The builds are created with a new introduced status `created`. The builds are then automatically promoted to `pending` when a previous stage do succeed. This significantly simplifies pipeline processing code solving a lot of problems of lazily initialisation of previous approach (builds were created on-demand). ## Why was this MR needed? The previous mechanism had a lot of flows (shown in related issues) in how it work, but also in code design. Removing cross model-service-library dependencies. The current approach moves a build creation to single place `CreatePipelineService` and removes a dynamic dependency on `config_processor` significantly simplifying a build creation and pipeline processing. Pipeline processing is implemented in `ProcessPipelineService`. This also allows to easily extend GitLab with Manual Actions which is part of 8.10 direction issue. ## Migration problem ~~This MR removes the a on-demand creation of builds in pipelines. Pipelines that are running and are in mid-stage (some stages started, but not all) will not be fully evaluated after application restart. This happens, because the code responsible for on-demand creation is removed. There's no easy way to migrate existing pipelines, other than doing offline migration and putting pipeline processing in migration code (which seems to be a really bad idea).~~ To support old pipelines I added a lazy initialization of builds if none is found. ## What are the relevant issue numbers? Fixes: https://gitlab.com/gitlab-org/gitlab-ce/issues/12839 Solves: https://gitlab.com/gitlab-org/gitlab-ce/issues/18644 https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/289 Allows to easily implement: https://gitlab.com/gitlab-org/gitlab-ce/issues/17010 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5295
| | | * Pre-create all builds for Pipeline when a trigger is receivedKamil Trzcinski2016-08-111-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change simplifies a Pipeline processing by introducing a special new status: created. This status is used for all builds that are created for a pipeline. We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped). This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled. This also allows us to visualise a full pipeline (with created builds). This also removes an after_touch used for updating a pipeline state parameters. Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
| | * | Merge branch '13333-consider-updating-http-parser-rb-to-0-6-0' into 'master' Rémy Coutable2016-08-111-0/+58
| | |\ \ | | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the tinder gem by bare HTTP requests ## What does this MR do? It removes the `tinder` gem (used to talk to the Campfire API) and replaces its use by bare HTTP requests. ## Are there points in the code the reviewer needs to double check? N/A. ## Why was this MR needed? To simplify the potential dependency hell discussed in #13333. The initial issue was about updating `http_parser.rb` which was required by `twitter-stream` which was required by `tinder`. Those 3 gems are not needed anymore. ## What are the relevant issue numbers? #13333 ## Screenshots (if relevant) N/A. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) Closes #13333 See merge request !5758
| | | * Replace the tinder gem by bare HTTP requestsThomas Balthazar2016-08-111-0/+58
| | | |
| * | | Merge remote-tracking branch 'upstream/master' into pipeline-hooks-without-slackLin Jen-Shin2016-08-1113-48/+49
| |\ \ \ | | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (233 commits) Fix awardable button mutuality loading spinners Update CHANGELOG for 8.10.5 Clean up project destruction Small refactor of doc/development/README.md Avoid commit lookup on diff_helper Removed extra newline from redis_spec.rb Used cached value of project count to reduce DB load Remove duplicate link_to statements Mention add_column_with_default in downtime guide Add missing space to generic badge template Rename `run` task helper method to prevent conflict with StateMachine Add a method in Project to return a cached value of total count of projects spellcheck Add svg guidelines to ui guide Add Changelog entry for Grape upgrade [ci skip] Fix Grape tests. Retain old behavior Update Grape from 0.13.0 to 0.15.0. adds second batch of tests changed to active tense fixes part1 of files to start using active tense ...
| | * | adds second batch of tests changed to active tenseactive-tense-test-coveragetiagonbotelho2016-08-0913-48/+49
| | |/
| * | Missed renaming themLin Jen-Shin2016-08-051-5/+7
| | |
| * | Move those builders to their own namespace, feedback:Lin Jen-Shin2016-08-0410-18/+42
| |/ | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13540099
* | Fix the test due to the format changedLin Jen-Shin2016-08-011-7/+9
| |
* | Slack pipeline events test and fix some issues along the wayLin Jen-Shin2016-08-011-4/+62
| |
* | Add pipeline_events to Slack service:Lin Jen-Shin2016-07-301-0/+58
|/ | | | | | | | Also add Service#event_names so that we don't have to hard code all event names in ServiceParams. Note that I don't know why we want to call plural on issue_event and merge_request_event so that we still need to hard code them for issues_event and merge_requests_event. See app/helpers/services_helper.rb for those special rules.
* Little refactor, add specs, and a CHANGELOG entryRémy Coutable2016-07-261-6/+24
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Refactor service settings viewissue_8110Felipe Artur2016-07-201-5/+5
|
* Allow slack service to send messages on different channelsFelipe Artur2016-07-191-0/+71
|
View Lorry Controller Status