| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| | |
Disallow invalid MR branch name
See merge request gitlab/gitlabhq!3052
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prevents refspec as branch name, which would bypass branch protection
when used in conjunction with rebase.
HEAD seems to be a special case with lots of occurrence,
so it is considered valid for now.
Another special case is `refs/head/*`, which can be imported.
|
| | |
| |
| |
| |
| |
| | |
Gitlab::HTTP now resolves the hostname only once, verifies the IP is not
blocked, and then uses the same IP to perform the actual request, while
passing the original hostname in the `Host` header and SSL SNI field.
|
| | |
| |
| |
| | |
Added a changelog entry for the feature
|
| | |
| |
| |
| |
| | |
These two methods were used in emitting AUTO_DEVOPS_DOMAIN which has now
been dropped.
|
| | |
| |
| |
| | |
Update documentation to reflect removal
|
| |\ \
| | |
| | |
| | |
| | | |
Bump shoulda-matchers to 4.0.1
See merge request gitlab-org/gitlab-ce!28443
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Starting with Rails 5, belongs_to now adds a presence validation to the
association, and so as of shoulda-matchers 4.0.0 the belong_to matcher
follows suit and tests that this validation is there by setting the
association to nil and asserting that there are validation errors. This
exposed an error with the `validate_branches` method: we need to check
the source and target project exist.
|
| | | |
| | |
| | |
| | |
| | | |
Rails 5 requires that belongs_to associations have the associated record
present. These tests were failing because they had nil values.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When Kubernetes clusters were originally built they could only
exist at the project level, and so there was logic included
that assumed there would only ever be a single Kubernetes
namespace per cluster. We now support clusters at the group
and instance level, which allows multiple namespaces.
This change consolidates various project-specific fallbacks to
generate namespaces, and hands all responsibility to the
Clusters::KubernetesNamespace model. There is now no concept of
a single namespace for a Clusters::Platforms::Kubernetes; to
retrieve a namespace a project must now be supplied in all cases.
This simplifies upcoming work to use a separate Kubernetes
namespace per project environment (instead of a namespace
per project).
|
| | |
| |
| |
| |
| |
| | |
As this method does have `deployment_platform(environment: self.name)`,
which is what the form EE needs. Allows us to remove two overrides in
EE.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Immediate configuration is not ideal for group and instance
level clusters as projects that may never be deployed would
still have Kubernetes namespaces and service accounts created
for them.
As of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25586
we now create only the resources that are required for the
project being deployed, at the time of deployment.
|
| |\ \
| | |
| | |
| | |
| | | |
Omit max-count for diverging_commit_counts behind feature flag
See merge request gitlab-org/gitlab-ce!28157
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We want to optimize the query for the CountDivergingCommits rpc by
removing the --max-count argument now that we have commit graphs
enabled for all repositories during housekeeping. However, we want to
test this first behind a feature flag.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Sessions can be listed for a given user
See merge request gitlab-org/gitlab-ce!28306
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds ActiveSession#session_ids_for_user for listing session IDs for a
given user, and adds ActiveSession#list_sessions for listing session
data directly.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Optimise upload path calls
See merge request gitlab-org/gitlab-ce!28264
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
String#underscore isn't particularly slow, but it's possible for us to
call it many times in a users autocomplete request, with mostly-static
values ('User', 'Group', etc.). We can memoise this and save a
surprising amount of time (around 10% of the total request time in some
cases).
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix project visibility level validation
Closes #59379
See merge request gitlab-org/gitlab-ce!28305
|
| | |/ / / / |
|
| |/ / / /
| | | |
| | | |
| | | |
| | | | |
Adds suffix to enum methods and changes `in_groups` to
`of_groups`
|
| |/ / / |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Udpated user_edit_profile_spec with time preferences
Minor update form fields
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
CE Show disabled project repo mirrors
See merge request gitlab-org/gitlab-ce!27326
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Show disabled mirrors with a badge so that they
can be deleted by project owners.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Removed the conditions added to
Project.with_feature_available_for_user, and moved to the
IssuableFinder. Now, we ensure that, in the projects retrieved
in the Finder, the user has enough access for the feature.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Strip whitespace for PipelineSchedule#cron
See merge request gitlab-org/gitlab-ce!27990
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Instance level k8s clusters
See merge request gitlab-org/gitlab-ce!27196
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
There are two cluster hierarchies one for the deployment platform and
one for controllers. The main difference is that deployment platforms do
not check user permissions and only return the first match.
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | | |
Instance level clusters were already mostly supported, this change adds
admin area controllers for cluster CRUD
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If the UI sends a string value for lock_version (e.g. "0"), then the
previous monkey patch did not properly handle that properly. This
commit casts the value to an integer to determine whether to look for
NULL lock_versions.
For merge requests, GitLab sends a POST request to
`namespace/project/merge_requests/:iid` with the
`merge_request[lock_version]` parameter with a string `0`. The string
value comes from the form field, which explains why
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28145 wasn't
sufficient.
|
| | |/ /
|/| | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add env_var and file as supported types for CI variables. Variables of
type file expose to users existing gitlab-runner behaviour - save
variable value into a temp file and set the path to this file in an ENV
var named after the variable key.
Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/46806.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove cleaned up OIDs from database and cache
Closes #30093
See merge request gitlab-org/gitlab-ce!26555
|
| | | | | |
|
| |/ / /
| | |
| | |
| | | |
Refactor
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is step one of resolving
https://gitlab.com/gitlab-org/gitlab-ce/issues/56838.
Here is what changed:
- Revert the security fix from bdee9e8412d.
- Do not leak repository information (tag name, commit) to guests in API
responses.
- Do not include links to source code in API responses for users that do
not have download_code access.
- Show Releases in sidebar for guests.
- Do not display links to source code under Assets for users that do not
have download_code access.
GET ':id/releases/:tag_name' still do not allow guests to access
releases. This is to prevent guessing tag existence.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When this option is enabled, GitLab will create namespaces and service
accounts as usual. When disabled, GitLab wont create any project
specific kubernetes resources
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56557
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Adds an endpoint on PipelinesController
- Adds a service that iterates over every build in a stage and
plays it.
- Includes 'play_manual' details on EntitySerializer
- Builds a new Stage state: PlayManual. An stage can take this status if
it has manual builds or an skipped, scheduled or manual status
- Includes FE modifications and specs
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The new two-step Gitaly `Rebase` RPC yields the rebase commit SHA to the
client before proceeding with the rebase.
This avoids an issue where the rebase commit SHA was returned when the
RPC had fully completed, and in some cases this would be after the Rails
`post_receive` worker services had already run. In these situations,
the merge request did not yet have its rebase_commit_sha attribute set
introducing the possibility for bugs (such as previous approvals being
reset).
https://gitlab.com/gitlab-org/gitlab-ee/issues/5966
|
| | | |
| | |
| | |
| | |
| | | |
Include link to user and commit title.
Rearrange text
|
| | | |
| | |
| | |
| | |
| | | |
This new field will allow to keep track of the storage used by the
packages features, it provides also aggregation at namespace level.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
[CE] Remove deprecated usage of `attribute_changed?`
See merge request gitlab-org/gitlab-ce!27577
|
| | | | |
| | | |
| | | |
| | | | |
Prepares us for upgrade to Rails 5.2
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
'53064-bypassing-pipeline-jobs-by-canceling-the-pipeline-and-manually-running-later-jobs' into 'master'
Disable retrying cancelled jobs
Closes #53064
See merge request gitlab-org/gitlab-ce!27503
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Specs that test canceled jobs now
- expect them not to be retryable or playable
- expect them not to show retry buttons
Specs that test retryability now
- use failed status instead of canceled status
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Allow a member to have an access level equal to parent group
Closes gitlab-ee#11323
See merge request gitlab-org/gitlab-ce!27913
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Suppose you have this configuration:
1. Subgroup `hello/world`
2. Subgroup `hello/mergers`.
3. Project `hello/world/my-project` has invited group `hello/world` to
access protected branches.
4. The rule allows the group to merge but no one can push.
5. User `newuser` has Owner access to the parent group `hello`.
Previously, there was no way for the user `newuser` to be added to the
`hello/mergers` group since the validation only allowed a user to be
added at a higher access level.
Since membership in a subgroup confers certain access rights, such as
being able to merge or push code to protected branches, we have to
loosen the validation and allow someone to be added at an equal level
granted by the parent group.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11323
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Updates the EnvironmentController#metrics_dashboard endpoint
to support a "dashboard" param, which can be used to specify
the filepath of a dashboard configuration from a project
repository. Dashboard configurations are expected to be
stored in .gitlab/dashboards/.
Updates dashboard post-processing steps to exclude custom
metrics, which should only display on the system dashboard.
|
