summaryrefslogtreecommitdiff
path: root/spec/models
Commit message (Collapse)AuthorAgeFilesLines
* Migrate null values for users.private_profileAdam Hegyi2019-07-151-0/+12
| | | | | - Background migration for changing null values to false - Set false as default value for private_profile DB column
* Merge branch 'georgekoltsov/63955-fix-import-with-source-branch-deleted' ↵Robert Speicher2019-07-151-6/+17
|\ | | | | | | | | | | | | into 'master' Always return MR diff_refs if importing See merge request gitlab-org/gitlab-ce!30630
| * Add commit_id to AttributeCleaner::ALLOWED_REFERENCESgeorgekoltsov/63955-fix-import-with-source-branch-deletedGeorge Koltsov2019-07-151-2/+2
| |
| * Add MergeRequest#diff_refs specGeorge Koltsov2019-07-111-6/+17
| |
* | Fix typo "beetween" in timeout validation messageDaniel Danner2019-07-131-1/+1
| |
* | Fix saving domain without certificate for auto_sslfix-only-https-pages-domainsVladimir Shushlin2019-07-121-10/+19
| |
* | Merge branch 'bvl-rename-routes-after-user-rename' into 'master'Jan Provaznik2019-07-122-18/+49
|\ \ | | | | | | | | | | | | Set the name of a user-namespace to the user name See merge request gitlab-org/gitlab-ce!23272
| * | Set the name of a user-namespace to the user nameBob Van Landuyt2019-07-092-18/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of setting the name of the namespace to the user's username, set it to the user's name. This is more consistent with how we name the routes: The route-name of a namespace is the human name of the routable. In the case of a user-namespace, this is the owner's name. When we change a user's name (both on create and update), we now also update the namespace-name to the user's name. This will make sure that if we also correctly update all the nested routes.
* | | Upgrade to Rails 5.2upgrade-rails-5-2-ceHeinrich Lee Yu2019-07-123-5/+5
| |/ |/| | | | | Updates changed method names and fixes spec failures
* | Merge branch '64161-gitlab-fqdn' into 'master'Grzegorz Bizon2019-07-111-0/+1
|\ \ | | | | | | | | | | | | | | | | | | Add CI variable to provide GitLab FQDN Closes #64161 See merge request gitlab-org/gitlab-ce!30417
| * | Add CI variable to provide GitLab FQDNBalasankar "Balu" C2019-07-101-0/+1
| | | | | | | | | | | | Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
* | | Merge branch 'fix-issue-trackers-spec' into 'master'Thong Kuah2019-07-116-12/+24
|\ \ \ | | | | | | | | | | | | | | | | Make sure all specs run properly See merge request gitlab-org/gitlab-ce!30367
| * | | Make sure all specs run properlyJarka Košanová2019-07-116-12/+24
| | |/ | |/| | | | | | | | | | | | | - handling properties needs to be skipped when creating test records in order to test the legacy data
* | | Merge branch 'banzai-avoid-redis-if-db-cache' into 'master'Douwe Maan2019-07-113-5/+39
|\ \ \ | | | | | | | | | | | | | | | | Banzai - avoid redis if attr is in DB cache See merge request gitlab-org/gitlab-ce!30334
| * | | Banzai - avoid redis if attr is in DB cachebanzai-avoid-redis-if-db-cacheMario de la Ossa2019-07-103-5/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When cache_collection_render runs we end up reading and writing things to redis even if we already have the rendered field cached in the DB. This commit avoids using redis at all whenever we have the field already rendered in the DB cache.
* | | | Upgrade rspec-rails to 3.8.2 and dependenciessh-bump-rspec-versionsDouglas Barbosa Alexandre2019-07-101-4/+3
| |_|/ |/| | | | | | | | | | | | | | | | | | | | This brings the rspec-core version in line with the Gitaly changes and introduces Rails 5.1/5.2 improvements. Full CHANGELOG: https://github.com/rspec/rspec-rails/blob/master/Changelog.md
* | | Merge branch 'prepare-cycle-analytics-for-group-level' into 'master'Douglas Barbosa Alexandre2019-07-108-11/+17
|\ \ \ | | | | | | | | | | | | | | | | Prepare cycle analytics for group level See merge request gitlab-org/gitlab-ce!30356
| * | | Add newline before subjectprepare-cycle-analytics-for-group-levelMałgorzata Ksionek2019-07-106-0/+6
| | | | | | | | | | | | | | | | Fix rubocop offences
| * | | Add cr remarksMałgorzata Ksionek2019-07-098-8/+8
| | | |
| * | | Add code review remarksMałgorzata Ksionek2019-07-091-2/+2
| | | |
| * | | Move project level specsMałgorzata Ksionek2019-07-091-2/+2
| | | |
| * | | Update class callsMałgorzata Ksionek2019-07-097-7/+7
| | |/ | |/|
* | | GraphQL support for Notes created in discussions62826-graphql-note-mutationsLuke Duncalfe2019-07-101-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A new `discussion_id` argument on the `createNote` mutation allows people to create a note within that discussion. The ability to lazy-load Discussions has been added, so GraphQL.object_from_id can treat Discussions the same as AR objects and batch load them. https://gitlab.com/gitlab-org/gitlab-ce/issues/62826 https://gitlab.com/gitlab-org/gitlab-ee/issues/9489
* | | Merge branch 'master' into sathieu/gitlab-ce-project_apiDouglas Barbosa Alexandre2019-07-0914-441/+489
|\ \ \ | |/ /
| * | Merge branch 'allow-reactive-caching-of-nil' into 'master'Stan Hu2019-07-091-27/+29
| |\ \ | | | | | | | | | | | | | | | | Allow ReactiveCaching to support nil value See merge request gitlab-org/gitlab-ce!30456
| | * | Allow ReactiveCaching to support nil valueFabio Pitino2019-07-081-27/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When :calculate_reactive_caching returns a nil value this caused ReactiveCaching to schedule a worker every time the code using :with_reactive_cache was called. This issue caused an increasing amount of Sidekiq jobs being created continuously. Implementing this fix behind feature flag :reactive_caching_check_key_exists
| * | | Schedule namespace aggregation in other contextsMayra Cabrera2019-07-081-0/+43
| |/ / | | | | | | | | | | | | | | | | | | Schedules a Namespace::AggregationSchedule worker if some of the project statistics are refreshed. The worker is only executed if the feature flag is enabled.
| * | Merge branch 'run-pipeline-for-merge-train-at-train-ref-ce' into 'master'Kamil Trzciński2019-07-081-0/+30
| |\ \ | | | | | | | | | | | | | | | | CE Port: Fix race condition of `refs/merge` competing overwrite See merge request gitlab-org/gitlab-ce!30308
| | * | Fix race condition on merge train ref generationrun-pipeline-for-merge-train-at-train-ref-ceShinya Maeda2019-07-081-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Today, Pipelines for merge train run on `refs/merge`, however, this causes a race condition that it can be overwritten by CheckMergeabilityService. This patch fixes the problem by generating `refs/train` for those pipelines.
| * | | Merge branch '63475-fix-n-1' into 'master'Lin Jen-Shin2019-07-083-149/+127
| |\ \ \ | | | | | | | | | | | | | | | | | | | | Reduce N+1 queries in MergeRequestsController#ci_environment_status See merge request gitlab-org/gitlab-ce!30224
| | * | | Restore fallback to deployment_platform_clusterThong Kuah2019-07-081-0/+12
| | | | | | | | | | | | | | | | | | | | In 12.2 we will remove this fallback.
| | * | | Remove un-used methodThong Kuah2019-07-081-28/+0
| | | | | | | | | | | | | | | | | | | | We stopped calling the fallback so we can remove this now
| | * | | Extract deployment_metrics into own objectThong Kuah2019-07-082-107/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can now share project so that we don't have to load project twice. Also, this extracts non-relevant logic out of Deployment. Update DeploymentsController accordingly
| | * | | Share project object in EnvironmentStatusThong Kuah2019-07-081-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Otherwise, each EnvironmentStatus object instantiates its own project when really they are the same. Improves query count performance
| | * | | Remove fallback to project.deployment_platformThong Kuah2019-07-081-12/+0
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves query performance of MergeRequestsController#ci_environments_status a lot. However this means old deployments that deployed to kubernetes clusters with prometheus installations will no longer show performance metrics as we cannot backfill cluster_id from deployment_platform with certainty (clusters may be edited/added/deleted, which changes the results of deployment_platform).
| * | | Merge branch '40379-CJK-search-min-chars' into 'master'Andreas Brandl2019-07-081-0/+10
| |\ \ \ | | | | | | | | | | | | | | | | | | | | Remove minimum required characters for fuzzy search if no trigram is used See merge request gitlab-org/gitlab-ce!29810
| | * | | Ignore min_chars_for_partial_matching unles trigrm40379-CJK-search-min-charsMario de la Ossa2019-07-041-0/+10
| | | |/ | | |/| | | | | | | | | | | | | If we're not using a trigram index, then ignore the min_chars_for_partial_matching setting
| * | | Create CTE query for clusters hierarchyThong Kuah2019-07-082-1/+90
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - This enables us to use a scope to query all clusters in group hierarchy order in one query, and also enables us to union to instance clusters later. - Handle case where clusters not present at level. In which case the query should go ahead and return the next level's clusters. - Swap with new CTE query behind Feature flag. This FF is default disabled.
| * | Prevent amplification of ReactiveCachingWorker jobs upon failuressh-disable-reactive-caching-automatic-retriesStan Hu2019-07-061-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `ReactiveCachingWorker` hits an SSL or other exception that occurs quickly and reliably, automatically rescheduling a new worker could lead to excessive number of jobs being scheduled. This happens because not only does the failed job get rescheduled in a minute, but each Sidekiq retry will also add even more rescheduled jobs. In busy instances, this can become an issue because large numbers of `ReactiveCachingWorker` running can cause high rates of `ExclusiveLease` reads to occur and possibly saturate the Redis server with queries. We now disable this automatic retry and rely on Sidekiq to perform its 3 retries with a backoff period. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64176
| * | Add OpenSSL::OpenSSLError to HTTP_ERRORSDouglas Barbosa Alexandre2019-07-051-0/+9
| | | | | | | | | | | | | | | | | | Some services can raise OpenSSL::X509::CertificateError due to an invalid SSL certificates, with OpenSSL::OpenSSLError we can handle these errors.
| * | Merge branch 'create-merge-train-ref-ce' into 'master'Douwe Maan2019-07-051-2/+3
| |\ \ | | | | | | | | | | | | | | | | CE Port: Extend `MergeToRefService` to create merge ref from an arbitrary ref See merge request gitlab-org/gitlab-ce!30361
| | * | Extend MergeToRefService for creating merge ref from the other refShinya Maeda2019-07-051-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, MergeToRefService is specifically designed for createing merge commits from source branch and target branch of merge reqeusts. We extend this behavior to source branch and any target ref paths.
| * | | Remove now unused KubernetesService methodsremove_unused_k8s_service_methodsJames Fargher2019-07-052-235/+0
| |/ / | | | | | | | | | | | | Now that KubernetesService can no longer be a DeploymentPlatform we can remove all kubernetes client code and KubernetesService edge cases.
| * | Merge branch '54117-transactional-rebase' into 'master'Douglas Barbosa Alexandre2019-07-041-24/+91
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow asynchronous rebase operations to be monitored Closes #54117 See merge request gitlab-org/gitlab-ce!29940
| | * | Allow asynchronous rebase operations to be monitoredNick Thomas2019-07-041-24/+91
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | This MR introduces tracking of the `rebase_jid` for merge requests. As with `merge_ongoing?`, `rebase_in_progress?` will now return true if a rebase is proceeding in sidekiq. After one release, we should remove the Gitaly-based lookup of rebases. It is much better to track this kind of thing via the database.
| * | Implements lease_release on NamespaceAggregationMayra Cabrera2019-07-041-1/+30
| | | | | | | | | | | | | | | | | | | | | Sets lease_release? to false to prevent the job to be re-executed more often than lease timeout Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64079
| * | Refactor pipeline errors_messagerefactor-pipeline-errors_message-ceShinya Maeda2019-07-041-0/+24
| |/ | | | | | | Use the shared method in Ci::Pipeline
| * Fix order-dependent spec failure in appearance_spec.rbStan Hu2019-07-031-1/+1
| | | | | | | | | | | | | | | | | | When file_mover_spec.rb ran, it would initialize fog-aws with `Fog::AWS::Storage::Real` service instead of `Fog::AWS::Storage::Mock` because `Fog.mock!` was not called. Ensure that we use `stub_uploads_object_storage` to prevent that from happening. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64083
| * Put a failed example from appearance_spec in quarantineIgor2019-07-031-1/+1
| |
* | Add auto_devops_* to project APIMathieu Parent2019-07-031-2/+23
| | | | | | | | | | The auto_devops object sometimes doesn't exists. We may need to create it.
View Lorry Controller Status