summaryrefslogtreecommitdiff
path: root/spec/models
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'if-64257-active_session_lookup_key_cleanup' into 'master'Bob Van Landuyt2019-07-231-1/+1
|\ | | | | | | | | Rake task to cleanup expired ActiveSession lookup keys See merge request gitlab-org/gitlab-ce!30668
| * Rake task to cleanup expired ActiveSession lookup keysif-64257-active_session_lookup_key_cleanupImre Farkas2019-07-221-1/+1
| | | | | | | | | | | | | | In some cases ActiveSession.cleanup was not called after authentication, so for some user ActiveSession lookup keys grew without ever cleaning up. This Rake task manually iterates over the lookup keys and removes ones without existing ActiveSession.
* | Merge branch 'gsemet/gitlab-ce-gsemet-master-patch-33258' into 'master'Sean McGivern2019-07-231-0/+20
|\ \ | | | | | | | | | | | | Multiple pipeline support for Build status See merge request gitlab-org/gitlab-ce!30828
| * | Add specs for specifying pipeline behaviorMatija Čupić2019-07-231-0/+20
| | | | | | | | | | | | | | | Adds specs for testing the new behavior of specifying a pipeline when POSTing a status.
* | | Merge branch 'group_with_cluster_factory' into 'master'Robert Speicher2019-07-221-6/+4
|\ \ \ | | | | | | | | | | | | | | | | Adds cluster_for_group factory for convenience See merge request gitlab-org/gitlab-ce!30826
| * | | Adds cluster_for_group factory for convienencegroup_with_cluster_factoryThong Kuah2019-07-191-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also means we don't have to resort to an update statement to set parent for child groups who also have clusters. This is much shorter than ``` create(:cluster, :provided_by_gcp, :group, groups: [group]) ```
* | | | Validate certificate chain only if it's changedVladimir Shushlin2019-07-221-0/+24
| | | | | | | | | | | | | | | | | | | | This validation prevents the domain from being saved from the UI e.g. when user tries to enable Let's Encrypt integration
* | | | Merge branch 'maintainers-can-create-subgroup' into 'master'Sean McGivern2019-07-221-0/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add a group setting to allow Maintainers to create sub-groups See merge request gitlab-org/gitlab-ce!29718
| * | | | Make subgroup_creation_level default to maintainer at SQL levelFabio Papa2019-07-191-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Migration updates existing groups to "owner", then sets default to "maintainer" so that new groups will default to that - Update spec examples
| * | | | Make maintainers the default setting for creating subgroupsFabio Papa2019-07-191-0/+8
| | | | |
| * | | | Remove an example that is no longer necessaryFabio Papa2019-07-191-9/+0
| | | | |
| * | | | Style rules; Revert some examplesFabio Papa2019-07-191-2/+4
| | | | |
| * | | | Make subgroup_creation_level default to maintainer at SQL levelFabio Papa2019-07-191-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Migration updates existing groups to "owner", then sets default to "maintainer" so that new groups will default to that - Update spec examples
| * | | | Make maintainers the default setting for creating subgroupsFabio Papa2019-07-191-0/+8
| | | | |
| * | | | Remove an example that is no longer necessaryFabio Papa2019-07-191-9/+0
| | | | |
| * | | | Style rules; Revert some examplesFabio Papa2019-07-191-1/+2
| | | | |
| * | | | Add examples specing the setting to choose who can create subgroupsFabio Papa2019-07-191-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This setting is at the group level only. The default is specified to be maintainers and owners. **Specs only**, all failing.
* | | | | Removed project autocomplete paginationJan Provaznik2019-07-221-20/+0
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | This pagination is not used anywhere so there is no reason to keep it. It seems the usage of offset_id was probably removed in 90c60138db4e1f86026aac5760febe4ba066ca30
* | | | Handle trailing slashes when generating Jira URLs63833-fix-jira-issues-urlHeinrich Lee Yu2019-07-221-1/+23
| | | | | | | | | | | | | | | | Applies to issues_url and new_issue_url
* | | | Fix the project auto devops APINick Thomas2019-07-191-15/+36
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If `project_auto_devops.enabled` is nil for a project, when setting any auto devops values via the API, we try to create a new row in the DB, instead of re-using the existing one. This leads to the project_id being set to nil, and the database `NOT NULL` constraint leading to a 500 response. This commit resolves the issue by correctly detecting the presence of a ProjectAutoDevops row and re-using it. Persistence is also moved away from explicit `update!` calls and into relying on `autosave: true` on the model.
* | | Introduce predictable environment slugs64295-predictable-environment-slugsTiger2019-07-191-26/+0
| | | | | | | | | | | | | | | | | | | | | If an environment slug is predictable given only the environment name, we can use the environment slug earlier in the CI variable evaluation process as we don't have to wait for the environment record itself to be persisted.
* | | CE port for milestones should not be set on epics issue promotionEugenia Grieff2019-07-181-0/+21
| | |
* | | Merge branch 'adjust-cycle-analytics-to-group-level' into 'master'Sean McGivern2019-07-189-14/+60
|\ \ \ | |/ / |/| | | | | | | | Adjust cycle analytics to group level See merge request gitlab-org/gitlab-ce!30391
| * | Add code review remarksMałgorzata Ksionek2019-07-161-2/+2
| | | | | | | | | | | | Change small things for better readability
| * | Add class for group level analyticsMałgorzata Ksionek2019-07-159-14/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add specs for group level Update entities Update base classes Add groups-centric changes Update plan and review stage Add summary classes Add summary spec Update specs files Add to specs test cases for group Add changelog entry Add group serializer Fix typo Fix typo Add fetching namespace in sql query Update specs Add rubocop fix Add rubocop fix Modify method to be in sync with code review Add counting deploys from subgroup To group summary stage Add subgroups handling In group stage summary Add additional spec Add additional specs Add more precise inheritance Add attr reader to group level Fix rubocop offence Fix problems with specs Add cr remarks Renaming median method and a lot of calls in specs Move spec setup Rename method in specs Add code review remarks regarding module Add proper module name
* | | Merge branch 'remove_clusters_cte_feature_flag' into 'master'Douglas Barbosa Alexandre2019-07-171-17/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Removes clusters_cte feature flag Closes #64259 See merge request gitlab-org/gitlab-ce!30827
| * | | Removes clusters_cte feature flagremove_clusters_cte_feature_flagThong Kuah2019-07-171-17/+1
| | |/ | |/| | | | | | | | | | | | | This has been enabled on production without issue https://gitlab.com/gitlab-org/gitlab-ce/issues/64259
* | | Fix wrong pages access level defaultVladimir Shushlin2019-07-171-0/+28
| | | | | | | | | | | | | | | - Set access level in before_validation hook - Add post migration for updating existing project_features
* | | Do Redis lookup in batches in ActiveSession.sessions_from_idsImre Farkas2019-07-171-0/+13
|/ / | | | | | | | | | | By doing smaller mget calls to Redis, it can better schedule the workload. Currently a single mget with a lot of keys can keep Redis busy for long, while nothing in its queue gets processed.
* | Don't use transactions and exceptionsReuben Pereira2019-07-161-0/+111
| | | | | | | | Instead return error objects.
* | Enable GitLabb runner to be uninstalled from clusterJoão Cunha2019-07-161-1/+32
| | | | | | | | | | | | - Set as uninstallable app - Update docs - Adjust specs
* | Merge branch 'remove-support-for-legacy-pipeline-triggers' into 'master'Kamil Trzciński2019-07-161-4/+16
|\ \ | | | | | | | | | | | | | | | | | | Remove support for legacy pipeline triggers Closes #30231 See merge request gitlab-org/gitlab-ce!30133
| * | Allow use of legacy triggers with feature flagFabio Pitino2019-07-151-4/+16
| |/ | | | | | | | | | | | | | | | | Keep feature flag disabled by default and turn off all functionality related to legacy triggers. * Block legacy triggers from creating pipeline * Highlight legacy triggers to be invalid via the UI * Make legacy triggers invalid in the model
* | Migrate null values for users.private_profileAdam Hegyi2019-07-151-0/+12
| | | | | | | | | | - Background migration for changing null values to false - Set false as default value for private_profile DB column
* | Merge branch 'georgekoltsov/63955-fix-import-with-source-branch-deleted' ↵Robert Speicher2019-07-151-6/+17
|\ \ | |/ |/| | | | | | | | | into 'master' Always return MR diff_refs if importing See merge request gitlab-org/gitlab-ce!30630
| * Add commit_id to AttributeCleaner::ALLOWED_REFERENCESgeorgekoltsov/63955-fix-import-with-source-branch-deletedGeorge Koltsov2019-07-151-2/+2
| |
| * Add MergeRequest#diff_refs specGeorge Koltsov2019-07-111-6/+17
| |
* | Fix typo "beetween" in timeout validation messageDaniel Danner2019-07-131-1/+1
| |
* | Fix saving domain without certificate for auto_sslfix-only-https-pages-domainsVladimir Shushlin2019-07-121-10/+19
| |
* | Merge branch 'bvl-rename-routes-after-user-rename' into 'master'Jan Provaznik2019-07-122-18/+49
|\ \ | | | | | | | | | | | | Set the name of a user-namespace to the user name See merge request gitlab-org/gitlab-ce!23272
| * | Set the name of a user-namespace to the user nameBob Van Landuyt2019-07-092-18/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of setting the name of the namespace to the user's username, set it to the user's name. This is more consistent with how we name the routes: The route-name of a namespace is the human name of the routable. In the case of a user-namespace, this is the owner's name. When we change a user's name (both on create and update), we now also update the namespace-name to the user's name. This will make sure that if we also correctly update all the nested routes.
* | | Upgrade to Rails 5.2upgrade-rails-5-2-ceHeinrich Lee Yu2019-07-123-5/+5
| |/ |/| | | | | Updates changed method names and fixes spec failures
* | Merge branch '64161-gitlab-fqdn' into 'master'Grzegorz Bizon2019-07-111-0/+1
|\ \ | | | | | | | | | | | | | | | | | | Add CI variable to provide GitLab FQDN Closes #64161 See merge request gitlab-org/gitlab-ce!30417
| * | Add CI variable to provide GitLab FQDNBalasankar "Balu" C2019-07-101-0/+1
| | | | | | | | | | | | Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
* | | Merge branch 'fix-issue-trackers-spec' into 'master'Thong Kuah2019-07-116-12/+24
|\ \ \ | | | | | | | | | | | | | | | | Make sure all specs run properly See merge request gitlab-org/gitlab-ce!30367
| * | | Make sure all specs run properlyJarka Košanová2019-07-116-12/+24
| | |/ | |/| | | | | | | | | | | | | - handling properties needs to be skipped when creating test records in order to test the legacy data
* | | Merge branch 'banzai-avoid-redis-if-db-cache' into 'master'Douwe Maan2019-07-113-5/+39
|\ \ \ | | | | | | | | | | | | | | | | Banzai - avoid redis if attr is in DB cache See merge request gitlab-org/gitlab-ce!30334
| * | | Banzai - avoid redis if attr is in DB cachebanzai-avoid-redis-if-db-cacheMario de la Ossa2019-07-103-5/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When cache_collection_render runs we end up reading and writing things to redis even if we already have the rendered field cached in the DB. This commit avoids using redis at all whenever we have the field already rendered in the DB cache.
* | | | Upgrade rspec-rails to 3.8.2 and dependenciessh-bump-rspec-versionsDouglas Barbosa Alexandre2019-07-101-4/+3
| |_|/ |/| | | | | | | | | | | | | | | | | | | | This brings the rspec-core version in line with the Gitaly changes and introduces Rails 5.1/5.2 improvements. Full CHANGELOG: https://github.com/rspec/rspec-rails/blob/master/Changelog.md
* | | Merge branch 'prepare-cycle-analytics-for-group-level' into 'master'Douglas Barbosa Alexandre2019-07-108-11/+17
|\ \ \ | | | | | | | | | | | | | | | | Prepare cycle analytics for group level See merge request gitlab-org/gitlab-ce!30356