summaryrefslogtreecommitdiff
path: root/spec/requests
Commit message (Collapse)AuthorAgeFilesLines
* Enable Style/SpaceAfterComma Rubocop coprubocop/enable-space-after-copsGrzegorz Bizon2016-06-291-3/+3
|
* Improve commit builds API endpoint RESTful behaviorGrzegorz Bizon2016-06-281-15/+48
| | | | | | | | 1. Return 404 if commit is not found (RESTful resource not found) 2. Return an empty array if pipeline is not found (resource present, no associated builds found) 3. Return an empty array if pipeline found but no builds there (resource present, no associated builds)
* Find all builds for commit if multiple pipelinesGrzegorz Bizon2016-06-281-2/+6
|
* Rename Licenses API to License Templates APIDrew Blessing2016-06-271-1/+1
|
* Use HTTP matchers if possibleZ.J. van de Weg2016-06-2739-884/+884
|
* gitlab-org/gitlab-ce#17818 - add api call for issues by groupMarc Siegfriedt2016-06-231-0/+142
| | | | | rely only on IssuesFinder docs and changelog
* Fix builds API response not including commit dataGrzegorz Bizon2016-06-211-3/+8
|
* Merge branch '17521-gitlab-ci-yml-templates' into 'master' Jacob Schatz2016-06-212-29/+52
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GitLab CI Yaml template dropdown ## What does this MR do? Make it possible to select a dropdown for an easy start with GitLab CI. ## What are the relevant issue numbers? Closes #17521 ## TODO - [ ] Backend - [x] CHANGELOG item - [x] Fix rubocop failure - [x] API Support - [x] New tests - [x] Add disclaimer to the top of the gitlab-ci.yml - [ ] Frontend - [x] New tests See merge request !4411
| * Incorporate reviewZ.J. van de Weg2016-06-201-0/+9
| |
| * Implement backend gitlab ci dropdownZ.J. van de Weg2016-06-202-29/+43
| | | | | | | | | | | | | | This commit builds on the groundwork in ee008e300b1ec0abcc90e6a30816ec0754cea0dd, which refactored the backend so the same code could be used for new dropdowns. In this commit its used for templates for the `.gitlab-ci.yml` files.
| * Refactor Gitlab::GitignoresZJ van de Weg2016-06-201-1/+1
| |
* | Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2016-06-204-22/+305
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | feature/runner-lock-on-project * upstream/master: (353 commits) Put some admin settings in dropdown Add styleguide on configuration settings documentation Remove Duplicated keys add UNIQUE index to fingerprint Avoid autoload issue such as 'Mail::Parsers::AddressStruct' Move appearance settings as sub tab to application settings use rails root join fixed a couple of errors spotted in production Fix RangeError exceptions when referring to issues or merge requests outside of max database values Fix bug in `WikiLinkFilter`. Grammar and typographic changes to artifacts documentation Tweak grammar Small frontend code fixes and restore 8a2d88f commit Warn about admin privilege to disable GitHub Webhooks Listing GH Webhooks doesn't stop import process for non GH admin users fixup! updated docs for api endpoint award emoji Update CHANGELOG Ensure Todos counters doesn't count Todos for projects pending delete Add endpoints for award emoji on notes Sort API endpoints and implement feedback Add endpoints for Award Emoji ...
| * Merge branch 'issue_12758' into 'master' Douwe Maan2016-06-171-5/+8
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement custom notification level options ![Screen_Shot_2016-06-17_at_15.31.43](/uploads/3fc47d2f461b3e8b67bb8acaa304cf99/Screen_Shot_2016-06-17_at_15.31.43.png) ![Screenshot_from_2016-06-15_10-52-27](/uploads/88dbdd21d97e80ee772fe08fa0c9b393/Screenshot_from_2016-06-15_10-52-27.png) part of #12758 See merge request !4389
| | * Merge master into issue_12758issue_12758Felipe Artur2016-06-172-33/+59
| | |\
| | * \ Re-use notifications dropdown/modal for user profileFelipe Artur2016-06-171-5/+24
| | |\ \
| | | * | Expose notification setting events in APIFelipe Artur2016-06-131-5/+24
| | | | |
| * | | | fixup! updated docs for api endpoint award emojiZ.J. van de Weg2016-06-171-1/+1
| | | | |
| * | | | Add endpoints for award emoji on notesZ.J. van de Weg2016-06-171-5/+54
| | | | | | | | | | | | | | | | | | | | Docs also added.
| * | | | Add endpoints for Award EmojiZ.J. van de Weg2016-06-171-0/+149
| | | | | | | | | | | | | | | | | | | | | | | | | This only supports Issues and MergeRequests right now because of the consistency of the routes those models provide.
| * | | | Fixed Rubocop errorPatricio Cano2016-06-171-0/+40
| | |_|/ | |/| |
| * | | Fix `api_helpers_spec`2979-personal-access-tokensTimothy Andrew2016-06-161-6/+6
| | | |
| * | | Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokensTimothy Andrew2016-06-165-2/+100
| |\ \ \ | | |/ /
| * | | Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokensTimothy Andrew2016-06-143-2/+26
| |\ \ \ | | | |/ | | |/|
| * | | Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokensTimothy Andrew2016-06-101-1/+82
| |\ \ \
| * \ \ \ Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokensTimothy Andrew2016-06-0910-57/+382
| |\ \ \ \
| * \ \ \ \ Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokensTimothy Andrew2016-06-0316-65/+413
| |\ \ \ \ \
| * \ \ \ \ \ Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokensTimothy Andrew2016-05-119-15/+236
| |\ \ \ \ \ \
| * | | | | | | Combine `API::Helpers::Core` and `API::Helpers::Authentication` back into ↵Timothy Andrew2016-04-282-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `API::Helpers` - Makes the MR easier to read; this can go in a separate MR - This is a (sort of) revert of 99bea01
| * | | | | | | Allow expiration of personal access tokens.Timothy Andrew2016-04-281-16/+56
| | | | | | | |
| * | | | | | | Rename `api_helpers_spec` to `api_authentication_spec`Timothy Andrew2016-04-281-14/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - And fix all tests.
| * | | | | | | Refactor `API::Helpers` into `API::Helpers::Core` and ↵Timothy Andrew2016-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `API::Helpers::Authentication`
* | | | | | | | Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2016-06-175-2/+100
|\ \ \ \ \ \ \ \ | | |_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | feature/runner-lock-on-project * upstream/master: (337 commits) Update CHANGELOG for !4659 Center the header logo for all Devise emails Add previews for all customized Devise emails Customize the Devise `unlock_instructions` email Customize the Devise `reset_password_instructions` email Customize the Devise `password_change` emails Use gitlab-git 10.2.0 Use Git cached counters on project show page Fix indentation scss-lint errors Added title attribute to enties in tree view Closes #18353 Banzai::Filter::ExternalLinkFilter use XPath Reduce queries in IssueReferenceFilter Use gitlab_git 10.1.4 Fixed ordering in Project.find_with_namespace Fix images in emails Banzai::Filter::UploadLinkFilter use XPath Turn Group#owners into a has_many association Make project_id nullable CHANGELOG [ci skip] CHANGELOG [ci skip] ...
| * | | | | | | Merge branch '18451-track-new-redis-connections' into 'master' Douwe Maan2016-06-151-1/+1
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Track the number of new Redis connections per transaction" ## What does this MR do? Add a new metric counter, `new_redis_connections`, that contains the number of calls to `Redis::Client#connect` in the current transaction. ## Are there points in the code the reviewer needs to double check? Not sure. I tested this in kind of a brute-force way: 1. Add a debugger in the monkey-patched `connect` method. 2. With metrics enabled, start the app and load a page. 3. The first Redis connection is created by `Rack::Attack` and isn't in a transaction, but still works fine. 4. The second Redis connection is within a transaction (the page load), and increments the counter. 5. If I reload the page, neither debugger is hit. 6. If I use a Redis client and do `CLIENT KILL` on my two existing clients, then reload the page, I get 3 and 4 again. 7. If I disable metrics collection, the debugger never gets hit. ## Why was this MR needed? We may have a Redis connection leak somewhere, so adding metrics will let us track this. ## What are the relevant issue numbers? Closes #18451. ## Screenshots (if relevant) Hahaha nope, not relevant. ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - [ ] Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc @yorickpeterse See merge request !4649
| | * | | | | | | Fix spec description typo18451-track-new-redis-connectionsSean McGivern2016-06-141-1/+1
| | | | | | | | |
| * | | | | | | | Merge remote-tracking branch 'origin/master' into artifacts-expire-dateKamil Trzcinski2016-06-143-2/+38
| |\ \ \ \ \ \ \ \ | | |/ / / / / / /
| | * | | | | | | Project members with guest role can't access confidential issuesDouglas Barbosa Alexandre2016-06-132-1/+37
| | | |_|_|_|_|/ | | |/| | | | |
| * | | | | | | Improve testsKamil Trzcinski2016-06-131-2/+2
| | | | | | | |
| * | | | | | | Improve design based on reviewKamil Trzcinski2016-06-132-7/+6
| | | | | | | |
| * | | | | | | Added keep artifacts API endpointKamil Trzcinski2016-06-131-0/+27
| | | | | | | |
| * | | | | | | Support expiration date in CI API when uploading artifactsKamil Trzcinski2016-06-131-0/+36
| | | | | | | |
* | | | | | | | Merge branch 'prefer-assign_to' into feature/runner-lock-on-projectLin Jen-Shin2016-06-141-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * prefer-assign_to: Give 409 Conflict whenever the runner was already enabled We're checking return value rather than rescuing exceptions Prefer Runner#assign_to instead of creating directly
| * | | | | | | | Give 409 Conflict whenever the runner was already enabledprefer-assign_toLin Jen-Shin2016-06-141-1/+1
| | |/ / / / / / | |/| | | | | |
* | | | | | | | Merge branch 'master' into feature/runner-lock-on-projectLin Jen-Shin2016-06-144-3/+108
|\ \ \ \ \ \ \ \ | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (147 commits) Update CHANGELOG Remove deprecated issues_tracker and issues_tracker_id from project Schema doesn’t reflect the changes of the last 3 migrations Revert CHANGELOG Also rename "find" in the specs Change to new Notes styleguide Add guide on changing a document's location Change logs.md location in README Move logs/logs.md to administration/logs.md Make "four phase test" Only show branches for revert / cherry-pick Instrument all Banzai::ReferenceParser classes Removed old comment from update_column_in_batches Update columns in batches until no rows are left Remove counters from Pipeline navigation Handle NULL migration errors in migration helpers Fix typo causing related branches to Error 500 Improved SVG sanitizer specs to include smoke tests for clean. Refactored SVG sanitizer Added SVG sanitizer fix to the changelog ...
| * | | | | | | Merge branch 'gitlab-auth-method-names' into 'master' Douwe Maan2016-06-131-1/+1
| |\ \ \ \ \ \ \ | | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve Gitlab::Auth method names Auth.find was a very generic name for a very specific method. Auth.find_in_gitlab_or_ldap was inaccurate in GitLab EE where it also looks in Kerberos. See merge request !4589
| | * | | | | | Improve Gitlab::Auth method namesJacob Vosmaer2016-06-101-1/+1
| | | |_|_|_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Auth.find was a very generic name for a very specific method. Auth.find_in_gitlab_or_ldap was inaccurate in GitLab EE where it also looks in Kerberos.
| * | | | | | Fix Error 500 when using closes_issues API with an external issue trackerStan Hu2016-06-111-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #18484
| * | | | | | Merge branch 'rename-ci-commit-phase-4' into 'master' Rémy Coutable2016-06-101-1/+1
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename Commit to Pipeline in TriggerRequest Changes in TriggerRequest a `commit` to `pipeline`. See merge request !4505
| | * \ \ \ \ \ Merge remote-tracking branch 'origin/master' into rename-ci-commit-phase-4Kamil Trzcinski2016-06-101-1/+82
| | |\ \ \ \ \ \ | | | |/ / / / /
| | * | | | | | Rename commit to pipeline in TriggerRequestKamil Trzcinski2016-06-091-1/+1
| | | |_|_|_|/ | | |/| | | |
| * | | | | | Rename MergeRequest#cannot_be_merged_because_build_is_not_success? to ↵Rémy Coutable2016-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #mergeable_ci_state? The logic of the method was obviously inverted. Signed-off-by: Rémy Coutable <remy@rymai.me>
View Lorry Controller Status